test(sdk): Ensure EventCacheStoreLockGuard::clear_dirty is called!

This patch ensures that the `EventCacheStoreLockGuard::clear_dirty`
method is correctly called.

Author: Hywan

crates/matrix-sdk-base/src/event_cache/store/mod.rs

@@ -119,6 +119,11 @@ impl EventCacheStoreLockGuard {
     pub fn clear_dirty(this: &Self) {
         this.cross_process_lock_guard.clear_dirty();
     }
+
+    /// Force to [`CrossProcessLockGuard::is_dirty`].
+    pub fn is_dirty(this: &Self) -> bool {
+        this.cross_process_lock_guard.is_dirty()
+    }
 }
 
 #[cfg(not(tarpaulin_include))]

crates/matrix-sdk/src/event_cache/room/mod.rs

@@ -1108,6 +1108,11 @@ mod private {
         {
             self.state.room_linked_chunk.revents().find_map(|(_position, event)| predicate(event))
         }
+
+        #[cfg(test)]
+        pub fn is_dirty(&self) -> bool {
+            EventCacheStoreLockGuard::is_dirty(&self.store)
+        }
     }
 
     impl<'a> RoomEventCacheStateLockWriteGuard<'a> {
@@ -2072,6 +2077,11 @@ mod private {
 
             Ok(())
         }
+
+        #[cfg(test)]
+        pub fn is_dirty(&self) -> bool {
+            EventCacheStoreLockGuard::is_dirty(&self.store)
+        }
     }
 
     /// Load a linked chunk's full metadata, making sure the chunks are
@@ -4114,6 +4124,9 @@ mod timed_tests {
                 // shared access.
                 // See `RoomEventCacheStateLock::read` to learn more.
 
+                // The lock is no longer marked as dirty, it's been cleaned.
+                assert!(guard.is_dirty().not());
+
                 // The reload can be observed via the updates too.
                 assert_matches!(
                     updates_stream.recv().await.unwrap(),
@@ -4167,6 +4180,9 @@ mod timed_tests {
                 // Guard is kept alive, to ensure we can have multiple read guards alive with a
                 // shared access.
 
+                // The lock is no longer marked as dirty, it's been cleaned.
+                assert!(guard.is_dirty().not());
+
                 // The reload can be observed via the updates too.
                 assert_matches!(
                     updates_stream.recv().await.unwrap(),
@@ -4220,6 +4236,9 @@ mod timed_tests {
 
                 let guard = room_event_cache.inner.state.write().await.unwrap();
 
+                // The lock is no longer marked as dirty, it's been cleaned.
+                assert!(guard.is_dirty().not());
+
                 // The reload can be observed via the updates too.
                 assert_matches!(
                     updates_stream.recv().await.unwrap(),
@@ -4267,6 +4286,9 @@ mod timed_tests {
 
                 let guard = room_event_cache.inner.state.write().await.unwrap();
 
+                // The lock is no longer marked as dirty, it's been cleaned.
+                assert!(guard.is_dirty().not());
+
                 // The reload can be observed via the updates too.
                 assert_matches!(
                     updates_stream.recv().await.unwrap(),