Adding different assertions for the different model sizes.

Author: debymf

+llms/+utils/errorMessageCatalog.m

@@ -55,4 +55,5 @@
 catalog("llms:pngExpected") = "Argument must be a PNG image.";
 catalog("llms:warningJsonInstruction") = "When using JSON mode, you must also prompt the model to produce JSON yourself via a system or user message.";
 catalog("llms:apiReturnedError") = "OpenAI API Error: {1}";
+catalog("llms:dimensionsMustBeSmallerThan") = "Dimensions must be less than or equal to {1}.";
 end

extractOpenAIEmbeddings.m

@@ -27,7 +27,7 @@
     nvp.ModelName  (1,1) {mustBeMember(nvp.ModelName,["text-embedding-ada-002", ...
                         "text-embedding-3-large", "text-embedding-3-small"])} = "text-embedding-ada-002"
     nvp.TimeOut    (1,1) {mustBeReal,mustBePositive} = 10
-    nvp.Dimensions (1,1) {mustBeInteger,mustBePositive, mustBeLessThanOrEqual(nvp.Dimensions, 1536)}
+    nvp.Dimensions (1,1) {mustBeInteger,mustBePositive}
     nvp.ApiKey           {llms.utils.mustBeNonzeroLengthTextScalar}
 end
 
@@ -42,6 +42,7 @@
         error("llms:invalidOptionForModel", ...
             llms.utils.errorMessageCatalog.getMessage("llms:invalidOptionForModel", "Dimensions", nvp.ModelName));
     end
+    mustBeCorrectDimensions(nvp.Dimensions,nvp.ModelName);
     parameters.dimensions = nvp.Dimensions;
 end
 
@@ -53,4 +54,19 @@
     emb = emb';
 else
     emb = [];
+end
+
+
+end
+
+function mustBeCorrectDimensions(dimensions,modelName)
+    model2dim = ....
+    dictionary(["text-embedding-3-large", "text-embedding-3-small"], ...
+    [3072,1536]);
+
+    if dimensions>model2dim(modelName)
+        error("llms:dimensionsMustBeSmallerThan", ...
+            llms.utils.errorMessageCatalog.getMessage("llms:dimensionsMustBeSmallerThan", ...
+            string(model2dim(modelName))));
+    end
 end

tests/textractOpenAIEmbeddings.m

@@ -96,9 +96,15 @@ function testInvalidInputs(testCase, InvalidInput)
         "Input",{{"bla", "Dimensions", "-11" }},...
         "Error","MATLAB:validators:mustBeNumericOrLogical"),...
     ...
-    "LargeDimensionValue",struct( ...
-        "Input",{{"bla", "Dimensions", 100000 }},...
-        "Error","MATLAB:validators:mustBeLessThanOrEqual"),...
+    "LargeDimensionValueForModelLarge",struct( ...
+        "Input",{{"bla", "ModelName", "text-embedding-3-large", ...
+            "Dimensions", 3073, "ApiKey", "fake-key"  }},...
+        "Error","llms:dimensionsMustBeSmallerThan"),...
+    ...
+    "LargeDimensionValueForModelSmall",struct( ...
+        "Input",{{"bla", "ModelName", "text-embedding-3-small", ...
+            "Dimensions", 1537, "ApiKey", "fake-key" }},...
+        "Error","llms:dimensionsMustBeSmallerThan"),...
     ...
     "InvalidDimensionSize",struct( ...
         "Input",{{"bla", "Dimensions", [123, 123] }},...