Fix argument validation for extractOpenAIEmbeddings

Author: debymf

extractOpenAIEmbeddings.m

@@ -20,14 +20,14 @@
 %   [emb, response] = EXTRACTOPENAIEMBEDDINGS(...) also returns the full
 %   response from the OpenAI API call.
 %
-%   Copyright 2023 The MathWorks, Inc.
+%   Copyright 2023-2024 The MathWorks, Inc.
 
 arguments
-    text           (1,:) {mustBeText}
+    text           (1,:) {mustBeNonzeroLengthText}
     nvp.ModelName  (1,1) {mustBeMember(nvp.ModelName,["text-embedding-ada-002", ...
                         "text-embedding-3-large", "text-embedding-3-small"])} = "text-embedding-ada-002"
     nvp.TimeOut    (1,1) {mustBeReal,mustBePositive} = 10
-    nvp.Dimensions (1,1) {mustBeInteger}
+    nvp.Dimensions (1,1) {mustBeInteger,mustBePositive, mustBeLessThanOrEqual(nvp.Dimensions, 1536)}
     nvp.ApiKey           {llms.utils.mustBeNonzeroLengthTextScalar}
 end
 

tests/textractOpenAIEmbeddings.m

@@ -56,6 +56,14 @@ function testInvalidInputs(testCase, InvalidInput)
 
 function invalidInput = iGetInvalidInput
 invalidInput = struct( ...
+    "InvalidEmptyText", struct( ...
+        "Input",{{ "" }},...
+        "Error", "MATLAB:validators:mustBeNonzeroLengthText"), ...
+    ...
+    "InvalidEmptyTextArray", struct( ...
+        "Input",{{ ["", ""] }},...
+        "Error", "MATLAB:validators:mustBeNonzeroLengthText"), ...
+    ...
     "InvalidTimeOutType", struct( ...
         "Input",{{ "bla", "TimeOut", "2" }},...
         "Error", "MATLAB:validators:mustBeReal"), ...
@@ -66,7 +74,7 @@ function testInvalidInputs(testCase, InvalidInput)
     ...
     "WrongTypeText",struct( ...
         "Input",{{ 123 }},...
-        "Error","MATLAB:validators:mustBeText"),...
+        "Error","MATLAB:validators:mustBeNonzeroLengthText"),...
     ...
     "InvalidModelNameType",struct( ...
         "Input",{{"bla", "ModelName", 0 }},...
@@ -84,6 +92,14 @@ function testInvalidInputs(testCase, InvalidInput)
         "Input",{{"bla", "Dimensions", "123" }},...
         "Error","MATLAB:validators:mustBeNumericOrLogical"),...
     ...
+    "InvalidDimensionValue",struct( ...
+        "Input",{{"bla", "Dimensions", "-11" }},...
+        "Error","MATLAB:validators:mustBeNumericOrLogical"),...
+    ...
+    "LargeDimensionValue",struct( ...
+        "Input",{{"bla", "Dimensions", 100000 }},...
+        "Error","MATLAB:validators:mustBeLessThanOrEqual"),...
+    ...
     "InvalidDimensionSize",struct( ...
         "Input",{{"bla", "Dimensions", [123, 123] }},...
         "Error","MATLAB:validation:IncompatibleSize"),...