added for attribute to checkbox and radio labels and added specific id attribute to checkbox and radio inputs

Author: jonasjabari

app/concepts/matestack/ui/core/form/select/select.haml

@@ -26,24 +26,26 @@
   %div{id: component_id, ref: "select.multiple.#{attr_key}", "init-value": init_value}
     - if options[:options].is_a?(Hash)
       - options[:options].each do |key, value|
-        %input{@tag_attributes,
+        %input{@tag_attributes.except(:id),
+        id: id_for_option(value),
         type: :checkbox,
         "#{model_binding}": input_key,
         "@change": "inputChanged(\"#{attr_key}\")",
         "value-type": options_type,
         name: value,
         value: key}/
-        %label=value
+        %label{for: id_for_option(value)}=value
     - if options[:options].is_a?(Array)
       - options[:options].each do |value|
-        %input{@tag_attributes,
+        %input{@tag_attributes.except(:id),
+        id: id_for_option(value),
         type: :checkbox,
         "#{model_binding}": input_key,
         "@change": "inputChanged(\"#{attr_key}\")",
         "value-type": options_type,
         name: value,
         value: value}/
-        %label=value
+        %label{for: id_for_option(value)}=value
   %span{class: "errors", "v-if": error_key }
     %span{class: "error", "v-for": "error in  #{error_key}"}
       {{ error }}
@@ -53,24 +55,26 @@
   %div{id: component_id, ref: "select.#{attr_key}", "init-value": init_value}
     - if options[:options].is_a?(Hash)
       - options[:options].each do |key, value|
-        %input{@tag_attributes,
+        %input{@tag_attributes.except(:id),
         type: :radio,
+        id: id_for_option(value),
         "#{model_binding}": input_key,
         "@change": "inputChanged(\"#{attr_key}\")",
         "value-type": options_type,
         name: "#{attr_key}_#{key}",
         value: key}/
-        %label=value
+        %label{for: id_for_option(value)}=value
     - if options[:options].is_a?(Array)
       - options[:options].each do |value|
-        %input{@tag_attributes,
+        %input{@tag_attributes.except(:id),
         type: :radio,
+        id: id_for_option(value),
         "#{model_binding}": input_key,
         "@change": "inputChanged(\"#{attr_key}\")",
         "value-type": options_type,
         name: "#{attr_key}_#{value}",
         value: value}/
-        %label=value
+        %label{for: id_for_option(value)}=value
   %span{class: "errors", "v-if": error_key }
     %span{class: "error", "v-for": "error in  #{error_key}"}
       {{ error }}

app/concepts/matestack/ui/core/form/select/select.rb

@@ -3,6 +3,12 @@ class Select < Matestack::Ui::Core::Component::Static
 
     REQUIRED_KEYS = [:options]
 
+    def setup
+      if @tag_attributes[:id].nil?
+        @tag_attributes[:id] = attr_key
+      end
+    end
+
     def input_key
       'data["' + options[:key].to_s + '"]'
     end
@@ -68,6 +74,10 @@ def init_value
       end
     end
 
+    def id_for_option value
+      return "#{attr_key}_#{value}"
+    end
+
 
   end
 end