be more specfic on error mapping spec for normal forms (no nested form included)

Author: jonasjabari

spec/test/components/dynamic/form/errors_spec.rb

@@ -45,9 +45,49 @@ def form_config
     expect(page).to have_content('seems to be invalid', count: 2)
     expect(page).to have_selector('#text-input.error')
     expect(page).to have_selector('#textarea.error')
+    expect(page).to have_selector("#text-input + .errors > .error", text: "seems to be invalid")
+    expect(page).to have_selector("#textarea + .errors > .error", text: "seems to be invalid")
     expect(page).to have_xpath('//div[@class="errors"]/div[@class="error" and contains(.,"seems to be invalid")]', count: 2)
   end
 
+  it "should reset error messages properly when missing data is provided" do
+    class ExamplePage < Matestack::Ui::Page
+      def response
+        matestack_form form_config do
+          form_input id: "text-input", key: :foo, type: :text
+          button "Submit me!"
+          plain "Errors: {{errors}}"
+        end
+      end
+
+      def form_config
+        {
+          for: :my_object,
+          method: :post,
+          path: form_error_failure_form_test_path(id: 42),
+        }
+      end
+    end
+
+    visit "/example"
+
+    fill_in "text-input", with: "text"
+
+    click_button "Submit me!"
+
+    expect(page).to have_content('Errors: { "foo": [ "seems to be invalid" ] }')
+
+    fill_in "text-input", with: "texttext"
+
+    page.find("#text-input").native.send_keys :tab
+
+    expect(page).to have_content('Errors: {}')
+
+    expect(page).not_to have_content('seems to be invalid')
+    expect(page).not_to have_selector('#text-input.error')
+    expect(page).not_to have_selector("#text-input + .errors > .error", text: "seems to be invalid")
+  end
+
   it "can turn off error messages with form config and turn explicit on" do
     class ExamplePage < Matestack::Ui::Page
       def response
@@ -67,7 +107,7 @@ def form_config
         }
       end
     end
-    
+
     visit "/example"
     fill_in "text-input", with: "text"
     fill_in "textarea", with: "area"
@@ -78,7 +118,7 @@ def form_config
     expect(page).not_to have_xpath('//div[@class="errors"]/div[@class="error" and contains(.,"seems to be invalid")]')
     expect(page).to have_xpath('//span[@class="errors"]/span[@class="error" and contains(.,"seems to be invalid")]')
   end
-  
+
   it "lets you turn errors of component based" do
     class ExamplePage < Matestack::Ui::Page
       def response
@@ -112,7 +152,7 @@ def form_config
     expect(page).not_to have_selector('#textarea.error')
     expect(page).to have_xpath('//div[@class="errors"]/div[@class="error" and contains(.,"seems to be invalid")]', count: 1)
   end
-  
+
   it "lets you customize errors and errors wrapper" do
     class ExamplePage < Matestack::Ui::Page
       def response
@@ -127,13 +167,13 @@ def form_config
           for: :my_object,
           method: :post,
           path: form_error_failure_form_test_path(id: 42),
-          errors: { 
-            wrapper: { 
-              tag: :div, 
+          errors: {
+            wrapper: {
+              tag: :div,
               class: 'my-errors'
-            }, 
-            tag: :div, 
-            class: 'my-error' 
+            },
+            tag: :div,
+            class: 'my-error'
           }
         }
       end
@@ -146,4 +186,4 @@ def form_config
     expect(page).to have_xpath('//div[@class="my-errors"]/div[@class="my-error" and contains(.,"seems to be invalid")]')
   end
 
-end
+end