Skip to content

Commit a498bec

Browse files
(Picklist, Lookup): resolve VRT issues
1 parent b3ceb0c commit a498bec

File tree

2 files changed

+72
-68
lines changed

2 files changed

+72
-68
lines changed

src/scripts/Lookup.tsx

Lines changed: 40 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -1364,24 +1364,28 @@ export const Lookup = createFC<LookupProps, { isFormElement: boolean }>(
13641364
</div>
13651365
</div>
13661366
</div>
1367-
<LookupDropdown
1368-
portalClassName={containerClassNames}
1369-
opened={opened}
1370-
loading={loading}
1371-
listboxId={listboxId}
1372-
dropdownRef={dropdownRef}
1373-
listHeader={listHeader}
1374-
listHeaderIdSeed={listHeaderIdSeed}
1375-
listFooter={listFooter}
1376-
listFooterIdSeed={listFooterIdSeed}
1377-
filteredData={filteredData}
1378-
focusedValue={focusedValue}
1379-
getOptionId={getOptionId}
1380-
onOptionClick={onOptionClick}
1381-
onOptionFocus={onOptionFocus}
1382-
onBlur={onInputBlur}
1383-
onKeyDown={onInputKeyDown}
1384-
/>
1367+
<div className='slds-combobox_container'>
1368+
<div className={comboboxClassNames}>
1369+
<LookupDropdown
1370+
portalClassName={containerClassNames}
1371+
opened={opened}
1372+
loading={loading}
1373+
listboxId={listboxId}
1374+
dropdownRef={dropdownRef}
1375+
listHeader={listHeader}
1376+
listHeaderIdSeed={listHeaderIdSeed}
1377+
listFooter={listFooter}
1378+
listFooterIdSeed={listFooterIdSeed}
1379+
filteredData={filteredData}
1380+
focusedValue={focusedValue}
1381+
getOptionId={getOptionId}
1382+
onOptionClick={onOptionClick}
1383+
onOptionFocus={onOptionFocus}
1384+
onBlur={onInputBlur}
1385+
onKeyDown={onInputKeyDown}
1386+
/>
1387+
</div>
1388+
</div>
13851389
</div>
13861390
</FormElement>
13871391
);
@@ -1410,25 +1414,25 @@ export const Lookup = createFC<LookupProps, { isFormElement: boolean }>(
14101414
onInputKeyDown={onInputKeyDown}
14111415
onSearchIconClick={onSearchIconClick}
14121416
/>
1417+
<LookupDropdown
1418+
portalClassName={containerClassNames}
1419+
opened={opened}
1420+
loading={loading}
1421+
listboxId={listboxId}
1422+
dropdownRef={dropdownRef}
1423+
listHeader={listHeader}
1424+
listHeaderIdSeed={listHeaderIdSeed}
1425+
listFooter={listFooter}
1426+
listFooterIdSeed={listFooterIdSeed}
1427+
filteredData={filteredData}
1428+
focusedValue={focusedValue}
1429+
getOptionId={getOptionId}
1430+
onOptionClick={onOptionClick}
1431+
onOptionFocus={onOptionFocus}
1432+
onBlur={onInputBlur}
1433+
onKeyDown={onInputKeyDown}
1434+
/>
14131435
</div>
1414-
<LookupDropdown
1415-
portalClassName={containerClassNames}
1416-
opened={opened}
1417-
loading={loading}
1418-
listboxId={listboxId}
1419-
dropdownRef={dropdownRef}
1420-
listHeader={listHeader}
1421-
listHeaderIdSeed={listHeaderIdSeed}
1422-
listFooter={listFooter}
1423-
listFooterIdSeed={listFooterIdSeed}
1424-
filteredData={filteredData}
1425-
focusedValue={focusedValue}
1426-
getOptionId={getOptionId}
1427-
onOptionClick={onOptionClick}
1428-
onOptionFocus={onOptionFocus}
1429-
onBlur={onInputBlur}
1430-
onKeyDown={onInputKeyDown}
1431-
/>
14321436
</div>
14331437
</FormElement>
14341438
);

src/scripts/Picklist.tsx

Lines changed: 32 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -607,39 +607,39 @@ export const Picklist: (<MultiSelect extends boolean | undefined>(
607607
textColor='default'
608608
/>
609609
</div>
610-
</div>
611-
{opened && (
612-
<AutoAlign
613-
triggerSelector='.react-slds-picklist'
614-
alignmentStyle='menu'
615-
portalClassName={containerClassNames}
616-
portalStyle={menuStyle}
617-
size={menuSize}
618-
>
619-
{({ autoAlignContentRef }) => (
620-
<div
621-
id={listboxId}
622-
className={dropdownClassNames}
623-
role='listbox'
624-
aria-label='Options'
625-
tabIndex={0}
626-
aria-busy={false}
627-
ref={useMergeRefs([dropdownRef, autoAlignContentRef])}
628-
>
629-
<ul
630-
className='slds-listbox slds-listbox_vertical'
631-
role='presentation'
632-
onKeyDown={onKeyDown}
633-
onBlur={onBlur}
610+
{opened && (
611+
<AutoAlign
612+
triggerSelector='.react-slds-picklist'
613+
alignmentStyle='menu'
614+
portalClassName={containerClassNames}
615+
size={menuSize}
616+
>
617+
{({ autoAlignContentRef }) => (
618+
<div
619+
id={listboxId}
620+
className={dropdownClassNames}
621+
role='listbox'
622+
aria-label='Options'
623+
tabIndex={0}
624+
aria-busy={false}
625+
ref={useMergeRefs([dropdownRef, autoAlignContentRef])}
626+
style={menuStyle}
634627
>
635-
<PicklistContext.Provider value={contextValue}>
636-
{children}
637-
</PicklistContext.Provider>
638-
</ul>
639-
</div>
640-
)}
641-
</AutoAlign>
642-
)}
628+
<ul
629+
className='slds-listbox slds-listbox_vertical'
630+
role='presentation'
631+
onKeyDown={onKeyDown}
632+
onBlur={onBlur}
633+
>
634+
<PicklistContext.Provider value={contextValue}>
635+
{children}
636+
</PicklistContext.Provider>
637+
</ul>
638+
</div>
639+
)}
640+
</AutoAlign>
641+
)}
642+
</div>
643643
</div>
644644
</FormElement>
645645
);

0 commit comments

Comments
 (0)