Skip to content

Commit 78a7f0f

Browse files
(Lookup): remove scopeId that wouldn't be necessary
1 parent 5edc2d8 commit 78a7f0f

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

src/scripts/Lookup.tsx

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,6 @@ type LookupScopeSelectorProps = {
189189
scopeOpened: boolean;
190190
scopeFocusedIndex: number;
191191
disabled?: boolean;
192-
scopeId: string;
193192
scopeListboxId: string;
194193
getScopeOptionId: (index: number) => string;
195194
onScopeMenuClick: () => void;
@@ -207,7 +206,6 @@ const LookupScopeSelector: FC<LookupScopeSelectorProps> = ({
207206
scopeOpened,
208207
scopeFocusedIndex,
209208
disabled,
210-
scopeId,
211209
scopeListboxId,
212210
getScopeOptionId,
213211
onScopeMenuClick,
@@ -220,10 +218,7 @@ const LookupScopeSelector: FC<LookupScopeSelectorProps> = ({
220218
return (
221219
<div className='slds-combobox_object-switcher slds-combobox-addon_start'>
222220
<div className='slds-form-element'>
223-
<label
224-
className='slds-form-element__label slds-assistive-text'
225-
htmlFor={scopeId}
226-
>
221+
<label className='slds-form-element__label slds-assistive-text'>
227222
Filter Search by:
228223
</label>
229224
<div className='slds-form-element__control'>
@@ -739,8 +734,6 @@ export const Lookup = createFC<LookupProps, { isFormElement: boolean }>(
739734
const comboboxId = id_ && `${fallbackId}-combobox`;
740735
const listboxId = `${fallbackId}-listbox`;
741736

742-
const scopeId = `${comboboxId}-scope`;
743-
744737
const optionIdPrefix = `${comboboxId}-option`;
745738
const getOptionId = (value: string) => `${optionIdPrefix}-${value}`;
746739

@@ -1183,7 +1176,6 @@ export const Lookup = createFC<LookupProps, { isFormElement: boolean }>(
11831176
scopeOpened={scopeOpened}
11841177
scopeFocusedIndex={scopeFocusedIndex}
11851178
disabled={disabled}
1186-
scopeId={scopeId}
11871179
scopeListboxId={scopeListboxId}
11881180
getScopeOptionId={getScopeOptionId}
11891181
onScopeMenuClick={onScopeMenuClick}

0 commit comments

Comments
 (0)