Skip to content

Commit 7416d40

Browse files
(DropdownMenu): improve a11y
1 parent 3f270ed commit 7416d40

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

src/scripts/DropdownMenu.tsx

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export const DropdownMenuHeader: FC<DropdownMenuHeaderProps> = ({
4949
className
5050
);
5151
return (
52-
<li className={menuHeaderClass}>
52+
<li className={menuHeaderClass} role='presentation'>
5353
<span>{children}</span>
5454
</li>
5555
);
@@ -230,7 +230,7 @@ export const DropdownMenuItem: FC<DropdownMenuItemProps> = (props) => {
230230
{divider === 'top' ? (
231231
<li className={`slds-has-divider_${divider}-space`} role='separator' />
232232
) : null}
233-
<li className={menuItemClass}>
233+
<li className={menuItemClass} role='presentation'>
234234
<a
235235
role='menuitem'
236236
{...rprops}
@@ -244,7 +244,10 @@ export const DropdownMenuItem: FC<DropdownMenuItemProps> = (props) => {
244244
onFocus={disabled ? undefined : onMenuItemFocus}
245245
onKeyDown={disabled ? undefined : onKeyDown}
246246
>
247-
<span className='slds-truncate'>
247+
<span
248+
className='slds-truncate'
249+
title={typeof label === 'string' ? label : undefined}
250+
>
248251
{icon ? <Icon icon={icon} size='x-small' align='left' /> : null}
249252
{label || children}
250253
</span>
@@ -397,7 +400,7 @@ const DropdownMenuInner: FC<DropdownMenuProps & AutoAlignInjectedProps> = (
397400
onBlur={onBlur}
398401
{...rprops}
399402
>
400-
<ul className='slds-dropdown__list' role='menu'>
403+
<ul className='slds-dropdown__list' role='menu' aria-label={header}>
401404
{header ? <MenuHeader>{header}</MenuHeader> : null}
402405
<DropdownMenuHandlerContext.Provider value={handlers}>
403406
<OpenSubmenuContext.Provider

0 commit comments

Comments
 (0)