Skip to content

Commit 5edc2d8

Browse files
(Lookup): remove aria-labelledby for consistency
1 parent 6eadf5e commit 5edc2d8

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

src/scripts/Lookup.tsx

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,6 @@ const createKeyHandler = (config: KeyHandlerConfig) => {
122122
type LookupSelectedStateProps = {
123123
selected: LookupEntry;
124124
disabled?: boolean;
125-
labelId?: string;
126125
listboxId: string;
127126
onRemoveSelection: () => void;
128127
};
@@ -133,7 +132,6 @@ type LookupSelectedStateProps = {
133132
const LookupSelectedState: FC<LookupSelectedStateProps> = ({
134133
selected,
135134
disabled,
136-
labelId,
137135
listboxId,
138136
onRemoveSelection,
139137
}) => {
@@ -162,7 +160,6 @@ const LookupSelectedState: FC<LookupSelectedStateProps> = ({
162160
role='combobox'
163161
tabIndex={disabled ? -1 : 0}
164162
className='slds-input_faux slds-combobox__input slds-combobox__input-value'
165-
aria-labelledby={labelId}
166163
aria-controls={listboxId}
167164
aria-haspopup='listbox'
168165
aria-expanded='false'
@@ -742,7 +739,6 @@ export const Lookup = createFC<LookupProps, { isFormElement: boolean }>(
742739
const comboboxId = id_ && `${fallbackId}-combobox`;
743740
const listboxId = `${fallbackId}-listbox`;
744741

745-
const labelId = label ? `${comboboxId}-label` : undefined;
746742
const scopeId = `${comboboxId}-scope`;
747743

748744
const optionIdPrefix = `${comboboxId}-option`;
@@ -1144,7 +1140,6 @@ export const Lookup = createFC<LookupProps, { isFormElement: boolean }>(
11441140
);
11451141

11461142
const formElemProps = {
1147-
id: labelId,
11481143
htmlFor: comboboxId,
11491144
label,
11501145
required,
@@ -1167,7 +1162,6 @@ export const Lookup = createFC<LookupProps, { isFormElement: boolean }>(
11671162
<LookupSelectedState
11681163
selected={selected}
11691164
disabled={disabled}
1170-
labelId={labelId}
11711165
listboxId={listboxId}
11721166
onRemoveSelection={onRemoveSelection}
11731167
/>

0 commit comments

Comments
 (0)