Skip to content

Commit 3d8db7c

Browse files
committed
fix lookup story height to render without wrapping
1 parent fc4e43d commit 3d8db7c

File tree

2 files changed

+40
-36
lines changed

2 files changed

+40
-36
lines changed

stories/LookupStories.js

Lines changed: 30 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -212,34 +212,38 @@ storiesOf('Lookup', module)
212212
/>
213213
))
214214
.addWithInfo('Active', 'Lookup component with candidates in dropdown', () => (
215-
<Lookup
216-
label='Lookup Label'
217-
searchText='A'
218-
opened
219-
data={ COMPANY_DATA }
220-
selected={ null }
221-
onSearchTextChange={ action('searchTextChange') }
222-
onLookupRequest={ action('lookupRequest') }
223-
onSelect={ action('select') }
224-
onBlur={ action('blur') }
225-
onComplete={ action('complete') }
226-
/>
215+
<div style={ { height: 350 } }>
216+
<Lookup
217+
label='Lookup Label'
218+
searchText='A'
219+
opened
220+
data={ COMPANY_DATA }
221+
selected={ null }
222+
onSearchTextChange={ action('searchTextChange') }
223+
onLookupRequest={ action('lookupRequest') }
224+
onSelect={ action('select') }
225+
onBlur={ action('blur') }
226+
onComplete={ action('complete') }
227+
/>
228+
</div>
227229
))
228230
.addWithInfo('With list header/footer', 'Lookup component with header/footer component in the candidate list', () => (
229-
<Lookup
230-
label='Lookup Label'
231-
searchText='A'
232-
opened
233-
data={ COMPANY_DATA }
234-
selected={ null }
235-
listHeader={ <Button icon='search' iconAlign='left'>&quot;A&quot; in Account</Button> }
236-
listFooter={ <Button icon='add' iconAlign='left'>Add new Account</Button> }
237-
onSearchTextChange={ action('searchTextChange') }
238-
onLookupRequest={ action('lookupRequest') }
239-
onSelect={ action('select') }
240-
onBlur={ action('blur') }
241-
onComplete={ action('complete') }
242-
/>
231+
<div style={ { height: 420 } }>
232+
<Lookup
233+
label='Lookup Label'
234+
searchText='A'
235+
opened
236+
data={ COMPANY_DATA }
237+
selected={ null }
238+
listHeader={ <Button icon='search' iconAlign='left'>&quot;A&quot; in Account</Button> }
239+
listFooter={ <Button icon='add' iconAlign='left'>Add new Account</Button> }
240+
onSearchTextChange={ action('searchTextChange') }
241+
onLookupRequest={ action('lookupRequest') }
242+
onSelect={ action('select') }
243+
onBlur={ action('blur') }
244+
onComplete={ action('complete') }
245+
/>
246+
</div>
243247
))
244248
.addWithInfo('Multi Scope', 'Lookup component which allows multiples scopes to select as lookup datasource', () => (
245249
<Lookup

yarn.lock

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
version "1.4.7"
55
resolved "https://registry.yarnpkg.com/@kadira/react-split-pane/-/react-split-pane-1.4.7.tgz#6d753d4a9fe62fe82056e323a6bcef7f026972b5"
66

7-
"@kadira/react-storybook-addon-info@^3.3.0":
8-
version "3.3.0"
9-
resolved "https://registry.yarnpkg.com/@kadira/react-storybook-addon-info/-/react-storybook-addon-info-3.3.0.tgz#dad3987c1603eed9b3e7718c5b26966098693b35"
7+
"@kadira/react-storybook-addon-info@^3.4.0":
8+
version "3.4.0"
9+
resolved "https://registry.yarnpkg.com/@kadira/react-storybook-addon-info/-/react-storybook-addon-info-3.4.0.tgz#f603dba8750f93318c33aa96f1e7bdfeeb61b7b0"
1010
dependencies:
1111
babel-runtime "^6.5.0"
1212
markdown-to-react-components "^0.2.1"
@@ -72,9 +72,9 @@
7272
react-modal "^1.2.1"
7373
redux "^3.5.2"
7474

75-
"@kadira/storybook@^2.35.1":
76-
version "2.35.1"
77-
resolved "https://registry.yarnpkg.com/@kadira/storybook/-/storybook-2.35.1.tgz#dd3dc045ebbfdd3130e0b0e66a35686f00aa5a86"
75+
"@kadira/storybook@^2.35.3":
76+
version "2.35.3"
77+
resolved "https://registry.yarnpkg.com/@kadira/storybook/-/storybook-2.35.3.tgz#8106195e1733623baf60db6adaa678dc29285d12"
7878
dependencies:
7979
"@kadira/react-split-pane" "^1.4.0"
8080
"@kadira/storybook-addon-actions" "^1.0.2"
@@ -86,7 +86,7 @@
8686
autoprefixer "^6.3.7"
8787
babel-core "^6.11.4"
8888
babel-loader "^6.2.4"
89-
babel-plugin-react-docgen "^1.4.1"
89+
babel-plugin-react-docgen "^1.4.2"
9090
babel-preset-react-app "^1.0.0"
9191
babel-runtime "^6.9.2"
9292
case-sensitive-paths-webpack-plugin "^1.1.2"
@@ -732,9 +732,9 @@ babel-plugin-jest-hoist@^16.0.0:
732732
version "16.0.0"
733733
resolved "https://registry.yarnpkg.com/babel-plugin-jest-hoist/-/babel-plugin-jest-hoist-16.0.0.tgz#b58ca3f770982a7e7c25b5614b2e57e9dafc6e76"
734734

735-
babel-plugin-react-docgen@^1.4.1:
736-
version "1.4.1"
737-
resolved "https://registry.yarnpkg.com/babel-plugin-react-docgen/-/babel-plugin-react-docgen-1.4.1.tgz#dc0d1e3e453ea592bd3b78f378638b30380328c9"
735+
babel-plugin-react-docgen@^1.4.2:
736+
version "1.4.2"
737+
resolved "https://registry.yarnpkg.com/babel-plugin-react-docgen/-/babel-plugin-react-docgen-1.4.2.tgz#04c02133b84b6cc182d35de2162f15764da03e7c"
738738
dependencies:
739739
babel-types "^6.16.0"
740740
lodash "4.x.x"

0 commit comments

Comments
 (0)