Skip to content

Commit a3fb117

Browse files
Ajit GeorgeAjit George
authored andcommitted
Fixes for Git issue 137
1 parent 6fb98a8 commit a3fb117

File tree

1 file changed

+6
-27
lines changed

1 file changed

+6
-27
lines changed

test-complete/src/test/java/com/marklogic/javaclient/TestPOJOMissingIdGetSetMethod.java

Lines changed: 6 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,6 @@ public void setInventory(int inventory) {
154154

155155
@BeforeClass
156156
public static void setUpBeforeClass() throws Exception {
157-
// System.setProperty("org.apache.commons.logging.simplelog.log.org.apache.http.wire",
158-
// "debug");
159157
System.out.println("In setup");
160158
setupJavaRESTServer(dbName, fNames[0], restServerName, restPort);
161159
}
@@ -239,9 +237,6 @@ public void validateMissingArtifactGetSet(SmallArtifactMissGetSet artifact) {
239237
* Purpose : This test is to validate read documents stored with JacksonHandle with valid POJO
240238
* specific URI. Uses SmallArtifactMissingSetter class
241239
* which has @Id only on the setter method.
242-
*
243-
* Current results (10/13/2014) are: read returns a null
244-
*
245240
*/
246241

247242
@Test
@@ -284,12 +279,7 @@ public void testPOJOReadMissingSetter() throws Exception {
284279
/*
285280
* Purpose : This test is to validate read documents stored with JacksonHandle with valid POJO
286281
* specific URI. Uses SmallArtifactMissingGetter class
287-
* which has @Id only on the setter method.
288-
*
289-
* Current results (10/13/2014) are:
290-
* java.lang.IllegalArgumentException: Your getter method, setName, annotated with
291-
* com.marklogic.client.pojo.annotation.Id must not require any arguments.
292-
* Issue 136 might solve this also.
282+
* which has @Id only on the setter method.
293283
*/
294284

295285
@Test
@@ -332,12 +322,7 @@ public void testPOJOReadMissingGetter() throws Exception {
332322
/*
333323
* Purpose : This test is to validate read documents with valid POJO
334324
* specific URI. Uses SmallArtifactMissingGetter class
335-
* which has @Id only on the setter method.
336-
*
337-
* Current results (10/13/2014) are:
338-
* java.lang.IllegalArgumentException: Your getter method, setName, annotated with
339-
* com.marklogic.client.pojo.annotation.Id must not require any arguments.
340-
* Issue 136 might solve this also.
325+
* which has @Id only on the setter method.
341326
*/
342327
@Test
343328
public void testPOJOWriteReadMissingGetter() throws Exception {
@@ -347,7 +332,7 @@ public void testPOJOWriteReadMissingGetter() throws Exception {
347332
String artifactName = new String("SmallArtifact");
348333

349334
SmallArtifactMissingGetter art = new SmallArtifactMissingGetter();
350-
art.setId(0);
335+
art.setId(-99L);
351336
art.setInventory(1000);
352337
art.setName(artifactName);
353338

@@ -361,10 +346,7 @@ public void testPOJOWriteReadMissingGetter() throws Exception {
361346
/*
362347
* Purpose : This test is to validate read documents stored with valid POJO
363348
* specific URI. Uses SmallArtifactMissingSetter class
364-
* which has @Id only on the setter method.
365-
*
366-
* Current results (10/13/2014) are: Works fine
367-
*
349+
* which has @Id only on the setter method.
368350
*/
369351

370352
@Test
@@ -375,7 +357,7 @@ public void testPOJOWriteReadMissingSetter() throws Exception {
375357
String artifactName = new String("SmallArtifactMissingSetter");
376358

377359
SmallArtifactMissingSetter art = new SmallArtifactMissingSetter();
378-
art.setId(-99);
360+
art.setId(-99L);
379361
art.setInventory(1000);
380362
art.setName(artifactName);
381363

@@ -389,10 +371,7 @@ public void testPOJOWriteReadMissingSetter() throws Exception {
389371
/*
390372
* Purpose : This test is to validate read documents stored with JacksonHandle with valid POJO
391373
* specific URI. Uses SmallArtifactMissGetSet class
392-
* which has no @Id on any of its class members.
393-
*
394-
* Current results (10/13/2014) are: IllegalArgumentException
395-
*
374+
* which has no @Id on any of its class members.
396375
*/
397376

398377
@Test(expected=IllegalArgumentException.class)

0 commit comments

Comments
 (0)