Changing the implementation as per the morning discussion.

Author: anu3990

marklogic-client-api/src/main/java/com/marklogic/client/impl/OkHttpServices.java

@@ -124,6 +124,7 @@
 import java.io.File;
 import java.io.IOException;
 import java.io.InputStream;
+import java.io.OutputStream;
 import java.io.PrintStream;
 import java.io.Reader;
 import java.io.UnsupportedEncodingException;
@@ -5388,7 +5389,7 @@ private <T> T getEntity(ResponseBody body, Class<T> as) {
         }
         Path path = Files.createTempFile("tmp", suffix);
         if ( isBinary == true ) {
-            Utilities.write(body.byteStream(), path);
+            Utilities.write(body.byteStream(), (OutputStream) path);
         } else {
           Writer out = Files.newBufferedWriter(path, Charset.forName("UTF-8"));
           try {

marklogic-client-api/src/main/java/com/marklogic/client/impl/Utilities.java

@@ -25,13 +25,10 @@
 import java.io.InputStream;
 import java.io.OutputStream;
 import java.io.OutputStreamWriter;
-import java.io.RandomAccessFile;
 import java.io.Reader;
 import java.io.StringReader;
-import java.nio.ByteBuffer;
-import java.nio.channels.FileChannel;
 import java.nio.charset.Charset;
-import java.nio.file.Path;
+import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 import java.util.List;
 
@@ -676,25 +673,38 @@ static public DatatypeFactory getDatatypeFactory() {
     return datatypeFactory;
   }
 
-  static public void write(InputStream in, Path path) { 
+  static public void write(InputStream in, OutputStream outStream) throws IOException { 
       try {
-      RandomAccessFile outFile = new RandomAccessFile(path.toString(), "rw");
-      FileChannel  inChannel = outFile.getChannel();
-      byte[] buf = new byte[BUFFER_SIZE * 2];
-      ByteBuffer byteBuf;
+          byte[] byteArray = new byte[BUFFER_SIZE * 2];
 
-      while (in.read(buf) != -1) {
-        byteBuf = ByteBuffer.wrap(buf);
-        byteBuf.flip();
-        inChannel.write(byteBuf);
-        byteBuf.clear();
+          while (in.read(byteArray) != -1) {
+            outStream.write(byteArray);
+          }
+      } finally {
+          in.close();
+      }
+  }
+  static public void write(Reader in, OutputStreamWriter out) throws IOException {
+      try {
+          char[] charArray = new char[BUFFER_SIZE * 2];
+          while (in.read(charArray) != -1) {
+              out.write(charArray);
+            }
+      } finally {
+          in.close();
+      }
+  }
+  static public void write(Reader in, OutputStream out) throws IOException {
+      try {
+          char[] charArray = new char[BUFFER_SIZE * 2];
+          byte[] byteArray;
+
+          while (in.read(charArray) != -1) {
+              byteArray = new String(charArray).getBytes(StandardCharsets.UTF_8);
+              out.write(byteArray);
+            }
+      } finally {
+          in.close();
       }
-      outFile.close();
-      } catch (IOException e) {
-          throw new MarkLogicIOException("Internal Exception occured.");
-      } 
   }
-  
-  static public void write(Reader in, OutputStreamWriter out) { }
-  static public void write(Reader in, OutputStream out) {}
 }

marklogic-client-api/src/main/java/com/marklogic/client/io/ReaderHandle.java

@@ -34,6 +34,7 @@
 import org.slf4j.LoggerFactory;
 
 import com.marklogic.client.MarkLogicIOException;
+import com.marklogic.client.impl.Utilities;
 import com.marklogic.client.io.marker.BufferableHandle;
 import com.marklogic.client.io.marker.ContentHandle;
 import com.marklogic.client.io.marker.ContentHandleFactory;
@@ -70,8 +71,6 @@ public class ReaderHandle
 {
   static final private Logger logger = LoggerFactory.getLogger(InputStreamHandle.class);
 
-  final static private int BUFFER_SIZE = 8192;
-
   private Reader content;
 
   /**
@@ -227,27 +226,7 @@ protected ReaderHandle sendContent() {
 
   @Override
   public void write(OutputStream out) throws IOException {
-    Charset charset = Charset.forName("UTF-8");
-    CharsetEncoder encoder = charset.newEncoder();
-
-    CharBuffer charBuf = CharBuffer.allocate(BUFFER_SIZE);
-    byte[] buf = new byte[BUFFER_SIZE * 2];
-    ByteBuffer byteBuf = ByteBuffer.wrap(buf);
-
-    while (content.read(charBuf) != -1) {
-      encoder.reset();
-      charBuf.flip();
-      byteBuf.clear();
-      CoderResult result = encoder.encode(charBuf, byteBuf, false);
-      if (result.isError()) {
-        throw new IOException("Failed during UTF-8 encoding - " + result.toString());
-      }
-      byteBuf.flip();
-      out.write(buf, 0, byteBuf.limit());
-      charBuf.clear();
-    }
-
-    out.flush();
+    Utilities.write(content, out);
   }
 
   /** Either call close() or get().close() when finished with this handle to close the underlying Reader.