exception throws and toString() nulls from static analysis #1159

Author: ehennum

marklogic-client-api/src/main/java/com/marklogic/client/extra/dom4j/DOM4JHandle.java

@@ -213,7 +213,7 @@ public byte[] toBuffer() {
   public String toString() {
     try {
       byte[] buffer = toBuffer();
-      return (buffer == null) ? "" : new String(buffer,"UTF-8");
+      return (buffer == null) ? null : new String(buffer,"UTF-8");
     } catch (UnsupportedEncodingException e) {
       throw new MarkLogicIOException(e);
     }

marklogic-client-api/src/main/java/com/marklogic/client/extra/jdom/JDOMHandle.java

@@ -207,7 +207,7 @@ public byte[] toBuffer() {
   public String toString() {
     try {
       byte[] buffer = toBuffer();
-      return (buffer == null) ? "" : new String(buffer,"UTF-8");
+      return (buffer == null) ? null : new String(buffer,"UTF-8");
     } catch (UnsupportedEncodingException e) {
       throw new MarkLogicIOException(e);
     }

marklogic-client-api/src/main/java/com/marklogic/client/impl/BaseProxy.java

@@ -891,6 +891,7 @@ public SingleCallResponse responseSingle(boolean isNullable, Format returnFormat
                  (returnFormat == null) ? Format.TEXT : returnFormat
          );
          if (responsedef.isNull() && !isNullable) {
+            responsedef.close();
             throw new RequiredReturnException("null for required single return value");
          }
          return responsedef;

marklogic-client-api/src/main/java/com/marklogic/client/impl/BaseTypeImpl.java

@@ -316,10 +316,7 @@ public StringBuilder exportAst(StringBuilder strb) {
     }
     @Override
     public String toString() {
-      if (value == null) {
-        return null;
-      }
-      return value.toString();
+      return (value == null) ? null : value.toString();
     }
   }
 

marklogic-client-api/src/main/java/com/marklogic/client/impl/BasicPage.java

@@ -101,8 +101,7 @@ public long size() {
 
   @Override
   public long getTotalPages() {
-    if ( getPageSize() == 0 ) return 0;
-    return (long) Math.ceil((double) getTotalSize() / (double) getPageSize());
+    return ceilingDivision(getTotalSize(), getPageSize());
   }
 
   @Override
@@ -122,11 +121,13 @@ public boolean hasPreviousPage() {
 
   @Override
   public long getPageNumber() {
-    if ( getPageSize() == 0 ) return 0;
-    double _start = (double) start;
-    double _pageSize = (double) getPageSize();
-    if ( _start % _pageSize == 0 ) return new Double(_start / _pageSize).longValue();
-    else return (long) Math.floor(_start / _pageSize) + 1;
+    return ceilingDivision(getStart(), getPageSize());
+  }
+
+  private long ceilingDivision(long dividend, long divisor) {
+    if (divisor == 0) return 0;
+    long quotient = dividend / divisor;
+    return (dividend % divisor == 0) ? quotient : quotient + 1;
   }
 
   @Override

marklogic-client-api/src/main/java/com/marklogic/client/impl/DocumentManagerImpl.java

@@ -373,11 +373,10 @@ public <T extends R> T read(DocumentDescriptor desc,
       HandleImplementation metadataBase = HandleAccessor.checkHandle(
         metadataHandle, "metadata");
       Format metadataFormat = metadataBase.getFormat();
-      if (metadataFormat == null
-        || (metadataFormat != Format.JSON && metadataFormat != Format.XML)) {
+      if (metadataFormat != Format.JSON && metadataFormat != Format.XML) {
         if (logger.isWarnEnabled())
           logger.warn("Unsupported metadata format {}, using XML",
-            metadataFormat.name());
+                  (metadataFormat == null) ? "null" : metadataFormat.name());
         metadataBase.setFormat(Format.XML);
       }
     }
@@ -535,7 +534,6 @@ private DocumentPage search(QueryDefinition querydef, long start,
       }
     }
 
-    String tid = transaction == null ? null : transaction.getTransactionId();
     // the default for bulk is no metadata, which differs from the normal
     // default of ALL
     Set<Metadata> metadata = isProcessedMetadataModified ? processedMetadata
@@ -904,11 +902,10 @@ protected TemporalDescriptor write(DocumentDescriptor desc, String temporalDocum
       HandleImplementation metadataBase = HandleAccessor.checkHandle(
         metadataHandle, "metadata");
       Format metadataFormat = metadataBase.getFormat();
-      if (metadataFormat == null
-        || (metadataFormat != Format.JSON && metadataFormat != Format.XML)) {
+      if (metadataFormat != Format.JSON && metadataFormat != Format.XML) {
         if (logger.isWarnEnabled())
           logger.warn("Unsupported metadata format {}, using XML",
-            metadataFormat.name());
+                  (metadataFormat == null) ? "null" : metadataFormat.name());
         metadataBase.setFormat(Format.XML);
       }
     }
@@ -1228,11 +1225,10 @@ protected DocumentDescriptorImpl create(DocumentUriTemplate template,
       HandleImplementation metadataBase = HandleAccessor.checkHandle(
         metadataHandle, "metadata");
       Format metadataFormat = metadataBase.getFormat();
-      if (metadataFormat == null
-        || (metadataFormat != Format.JSON && metadataFormat != Format.XML)) {
+      if (metadataFormat != Format.JSON && metadataFormat != Format.XML) {
         if (logger.isWarnEnabled())
           logger.warn("Unsupported metadata format {}, using XML",
-            metadataFormat.name());
+                  (metadataFormat == null) ? "null" : metadataFormat.name());
         metadataBase.setFormat(Format.XML);
       }
     }

marklogic-client-api/src/main/java/com/marklogic/client/impl/HTTPKerberosAuthInterceptor.java

@@ -69,7 +69,7 @@ public HTTPKerberosAuthInterceptor(String host, Map<String,String> krbOptions) {
    * Login Module to be used for authentication.
    *
    */
-  private class KerberosLoginConfiguration extends Configuration {
+  static private class KerberosLoginConfiguration extends Configuration {
     Map<String,String> krbOptions = null;
 
     public KerberosLoginConfiguration() {}
@@ -117,13 +117,20 @@ private void buildSubjectCredentials() throws LoginException {
    *           principal is present
    */
   private String getClientPrincipalName() {
-    final Set<Principal> principalSet = loginContext.getSubject().getPrincipals();
+    final Set<Principal> principalSet = getContextSubject().getPrincipals();
     if (principalSet.size() != 1)
       throw new IllegalStateException(
           "Only one principal is expected. Found 0 or more than one principals :" + principalSet);
     return principalSet.iterator().next().getName();
   }
 
+  private Subject getContextSubject() {
+    Subject subject = loginContext.getSubject();
+    if (subject == null)
+      throw new IllegalStateException("Kerberos login context without subject");
+    return subject;
+  }
+
   /**
    * This method builds the Authorization header for Kerberos. It
    * generates a request token based on the service ticket, client principal name and
@@ -150,7 +157,7 @@ private String buildAuthorizationHeader(String serverPrincipalName) throws Login
      * we build the Subject's private credentials again from valid TGT in the
      * Kerberos client cache.
      */
-    Set<Object> privateCreds = loginContext.getSubject().getPrivateCredentials();
+    Set<Object> privateCreds = getContextSubject().getPrivateCredentials();
     for (Object privateCred : privateCreds) {
       if (privateCred instanceof KerberosTicket) {
         String serverPrincipalTicketName = ((KerberosTicket) privateCred).getServer().getName();
@@ -220,6 +227,9 @@ public Object run() {
             GSSContext.DEFAULT_LIFETIME);
         byte[] inToken = new byte[0];
         byte[] outToken = context.initSecContext(inToken, 0, inToken.length);
+        if (outToken == null) {
+          throw new FailedRequestException("could not initialize the security context");
+        }
         context.requestMutualAuth(true);
         outputToken.append(new String(Base64.getEncoder().encode(outToken)));
         context.dispose();

marklogic-client-api/src/main/java/com/marklogic/client/impl/JacksonBaseHandle.java

@@ -85,7 +85,8 @@ public byte[] toBuffer() {
   @Override
   public String toString() {
     try {
-      return new String(toBuffer(),"UTF-8");
+      byte[] buffer = toBuffer();
+      return (buffer == null) ? null : new String(buffer,"UTF-8");
     } catch (UnsupportedEncodingException e) {
       throw new MarkLogicIOException(e);
     }