fix: Minor build and configuration issues (#229)

chrispader · web-flow · commit 172ae69a90e6 · 2025-11-03T21:24:26.000Z
* fix: `typeorm` missing in `bun.lockb` * chore: add npm `prepare` script * Update bun.lockb * Update bun.lockb * chore: build package on `prepublishOnly` * chore: add `typeorm` dependency top-level * fix: eslint jest error in CI * chore: use prettier in VS Code * fix: typescript-eslint setup * fix: add back prettier/recommended eslint config * chore: add `eslint-plugin-eslint-comments` * chore: add `eslint-plugin-react` * chore: add `eslint-plugin-react-hooks` * chore: add `eslint-plugin-react-native` * chore: add `@react-native/eslint-plugin` * revert package changes * Update bun.lockb * revert: eslint changes * Update lint-typescript.yml * chore: remove lint-ci script * update ci deps * chore: update jest * chore: add `eslint-plugin-jest` * Revert "chore: add `eslint-plugin-jest`" This reverts commit ba3a04b. * Update lint-typescript.yml * Revert "Update lint-typescript.yml" This reverts commit aba9508. * chore: update deps * chore: fix bun dependencies * fix: eslint errors * chore: set strict typeorm version * chore: rename typecheck script * fix: typescript errors * Update lint-typescript.yml * chore: update TS setup * Update .gitattributes * Create bunfig.toml * chore: split up tsc workflow check * revert: TS changes * chore: fix typeorm version * Update package.json * Update package.json * Update bunfig.toml
diff --git a/.gitattributes b/.gitattributes
@@ -1,4 +1,3 @@
 *.pbxproj -text
 # specific for windows script files
 *.bat text eol=crlf
-.lockb binary diff=lockb
diff --git a/.github/workflows/lint-typescript.yml b/.github/workflows/lint-typescript.yml
@@ -36,38 +36,38 @@ jobs:
     name: Compile TypeScript (tsc)
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - uses: oven-sh/setup-bun@v2
       - uses: reviewdog/action-setup@v1
 
       - name: Install npm dependencies (bun)
         run: bun install
 
-      - name: Run TypeScript (tsc)
+      - name: Run TypeScript (tsc) in example
+        working-directory: example
+        run: |
+          bun typecheck | reviewdog -name="tsc" -efm="%f(%l,%c): error TS%n: %m" -reporter="github-pr-review" -filter-mode="nofilter" -fail-level=any -tee
+        env:
+          REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Run TypeScript (tsc) in react-native-nitro-sqlite
+        working-directory: package
         run: |
-          bun typescript | reviewdog -name="tsc" -efm="%f(%l,%c): error TS%n: %m" -reporter="github-pr-review" -filter-mode="nofilter" -fail-on-error -tee
+          bun typecheck | reviewdog -name="tsc" -efm="%f(%l,%c): error TS%n: %m" -reporter="github-pr-review" -filter-mode="nofilter" -fail-level=any -tee
         env:
           REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
   lint:
     name: Lint TypeScript (eslint, prettier)
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - uses: oven-sh/setup-bun@v2
-      - uses: reviewdog/action-setup@v1
 
       - name: Install npm dependencies (bun)
         run: bun install
 
-      - name: Run ESLint CI in example/
-        working-directory: example
-        run: bun lint-ci
-      - name: Run ESLint CI in react-native-nitro-sqlite
-        working-directory: package
-        run: bun lint-ci
-
-      - name: Run ESLint with auto-fix in example/
+      - name: Run ESLint with auto-fix in example
         working-directory: example
         run: bun lint
       - name: Run ESLint with auto-fix in react-native-nitro-sqlite
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -1,14 +1,14 @@
 {
   "[javascript]": {
-    "editor.defaultFormatter": "dbaeumer.vscode-eslint"
+    "editor.defaultFormatter": "esbenp.prettier-vscode"
   },
   "[javascriptreact]": {
-    "editor.defaultFormatter": "dbaeumer.vscode-eslint"
+    "editor.defaultFormatter": "esbenp.prettier-vscode"
   },
   "[typescript]": {
-    "editor.defaultFormatter": "dbaeumer.vscode-eslint"
+    "editor.defaultFormatter": "esbenp.prettier-vscode"
   },
   "[typescriptreact]": {
-    "editor.defaultFormatter": "dbaeumer.vscode-eslint"
+    "editor.defaultFormatter": "esbenp.prettier-vscode"
   }
 }
diff --git a/bun.lock b/bun.lock
diff --git a/bun.lockb b/bun.lockb
diff --git a/bunfig.toml b/bunfig.toml
@@ -0,0 +1,4 @@
+[install]
+# Opt out from isolated installs
+linker = "hoisted"
+linkWorkspacePackages = true
diff --git a/example/package.json b/example/package.json
@@ -8,9 +8,8 @@
     "ios": "react-native run-ios",
     "bundle-install": "bundle install",
     "pods": "cd ios && bundle exec pod install",
-    "typescript": "tsc --noEmit",
+    "typecheck": "tsc --noEmit",
     "lint": "eslint \"**/*.{js,ts,tsx}\" --fix",
-    "lint-ci": "eslint \"**/*.{js,ts,tsx}\" -f @jamesacarr/github-actions",
     "codegen": "bun react-native codegen"
   },
   "dependencies": {
@@ -24,24 +23,24 @@
     "react": "19.0.0",
     "react-native": "0.78.0",
     "react-native-nitro-modules": "0.27.2",
-    "react-native-nitro-sqlite": "9.1.11",
+    "react-native-nitro-sqlite": "workspace:*",
     "react-native-safe-area-context": "^5.2.0",
     "react-native-screens": "^4.9.1",
     "reflect-metadata": "^0.1.13",
     "stream-browserify": "^3.0.0",
-    "typeorm": "^0.3.20",
+    "typeorm": "0.3.20",
     "util": "^0.12.5"
   },
   "devDependencies": {
-    "@babel/core": "^7.25.2",
+    "@babel/core": "^7.28.5",
     "@babel/plugin-proposal-decorators": "^7.20.5",
     "@babel/preset-env": "^7.25.4",
     "@babel/runtime": "^7.25.4",
     "@react-native-community/cli": "15.0.1",
     "@react-native-community/cli-platform-android": "15.0.1",
     "@react-native-community/cli-platform-ios": "15.0.1",
     "@react-native/babel-preset": "0.78.0",
-    "@react-native/eslint-config": "0.78.0",
+    "@react-native/eslint-config": "0.82.1",
     "@react-native/metro-config": "0.78.0",
     "@react-native/typescript-config": "0.78.0",
     "@types/chai": "^4.3.4",
diff --git a/example/src/Database.ts b/example/src/Database.ts
@@ -58,7 +58,7 @@ export async function executeFailingTypeORMQuery(): Promise<QueryResult | void>
           SELECT * From UnexistingTable
         `)) as QueryResult
     return manualQuery
-  } catch (e) {
+  } catch {
     console.warn('should have cached')
   }
 }
diff --git a/example/src/initGlobals.ts b/example/src/initGlobals.ts
@@ -2,11 +2,11 @@ import { Buffer as CraftzdogBuffer } from '@craftzdog/react-native-buffer'
 
 declare global {
   var Buffer: typeof CraftzdogBuffer
+}
 
-  var process: {
-    cwd: () => string
-    env: { NODE_ENV: string }
-  }
+if (!globalThis.process) {
+  // @ts-expect-error
+  globalThis.process = {}
 }
 
 globalThis.Buffer = CraftzdogBuffer
diff --git a/example/src/tests/unitTests.spec.ts b/example/src/tests/unitTests.spec.ts
@@ -350,7 +350,7 @@ export function registerUnitTests() {
             'INSERT INTO "User" (id, name, age, networth) VALUES(?, ?, ?, ?)',
             [id, name, age, networth]
           )
-        } catch (e) {
+        } catch {
           tx.rollback()
         }
       })
diff --git a/package.json b/package.json
@@ -19,7 +19,7 @@
   "homepage": "https://github.com/margelo/react-native-nitro-sqlite#readme",
   "scripts": {
     "postinstall": "patch-package",
-    "typescript": "bun --filter=\"**\" typescript",
+    "typecheck": "bun --filter=\"**\" typecheck",
     "lint": "bun package lint && bun example lint",
     "lint-cpp": "./scripts/clang-format.sh",
     "clean": "rm -rf **/tsconfig.tsbuildinfo node_modules package/node_module package/lib",
@@ -34,17 +34,16 @@
     "react-native-nitro-modules": "0.27.2"
   },
   "devDependencies": {
-    "@babel/core": "^7.25.2",
+    "@babel/core": "^7.28.5",
     "@babel/plugin-proposal-decorators": "^7.20.5",
     "@babel/preset-env": "^7.25.4",
     "@babel/runtime": "^7.25.4",
     "@eslint/js": "^9.10.0",
-    "@jamesacarr/eslint-formatter-github-actions": "^0.2.0",
     "@react-native-community/cli": "15.0.1",
     "@react-native-community/cli-platform-android": "15.0.1",
     "@react-native-community/cli-platform-ios": "15.0.1",
     "@react-native/babel-preset": "0.78.0",
-    "@react-native/eslint-config": "0.78.0",
+    "@react-native/eslint-config": "0.82.1",
     "@react-native/metro-config": "0.78.0",
     "@react-native/typescript-config": "0.78.0",
     "@release-it/bumper": "^6.0.1",
@@ -58,10 +57,11 @@
     "eslint": "8.57.0",
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-prettier": "^5.2.1",
-    "jest": "^29.7.0",
+    "jest": "^30.2.0",
     "nitro-codegen": "0.27.2",
     "prettier": "^3.3.3",
     "release-it": "^17.10.0",
+    "typeorm": "0.3.20",
     "typescript": "~5.5.4",
     "typescript-eslint": "^8.13.0"
   },
diff --git a/package/package.json b/package/package.json
@@ -36,14 +36,13 @@
     "!**/__mocks__"
   ],
   "scripts": {
-    "postinstall": "bun build || exit 0;",
     "build": "bun typescript && bob build",
     "specs": "bun typescript && bun nitro-codegen --logLevel=\"debug\"",
-    "typescript": "tsc --noEmit",
+    "typecheck": "tsc --noEmit",
     "lint": "eslint \"**/*.{js,ts,tsx}\" --fix",
-    "lint-ci": "eslint \"**/*.{js,ts,tsx}\" -f @jamesacarr/github-actions",
     "test": "jest",
-    "release": "release-it"
+    "release": "release-it",
+    "prepublishOnly": "bun run build"
   },
   "keywords": [
     "react-native",
@@ -66,10 +65,10 @@
     "registry": "https://registry.npmjs.org/"
   },
   "dependencies": {
-    "typeorm": "^0.3.20"
+    "typeorm": "0.3.20"
   },
   "devDependencies": {
-    "jest": "^29.7.0",
+    "jest": "^30.2.0",
     "nitro-codegen": "0.27.2",
     "react": "19.0.0",
     "react-native": "0.78.0",

Original file line number	Diff line number	Diff line change
`@@ -1,14 +1,14 @@`
`1`	`1`	`{`
`2`	`2`	`"[javascript]": {`
`3`		`- "editor.defaultFormatter": "dbaeumer.vscode-eslint"`
	`3`	`+ "editor.defaultFormatter": "esbenp.prettier-vscode"`
`4`	`4`	`},`
`5`	`5`	`"[javascriptreact]": {`
`6`		`- "editor.defaultFormatter": "dbaeumer.vscode-eslint"`
	`6`	`+ "editor.defaultFormatter": "esbenp.prettier-vscode"`
`7`	`7`	`},`
`8`	`8`	`"[typescript]": {`
`9`		`- "editor.defaultFormatter": "dbaeumer.vscode-eslint"`
	`9`	`+ "editor.defaultFormatter": "esbenp.prettier-vscode"`
`10`	`10`	`},`
`11`	`11`	`"[typescriptreact]": {`
`12`		`- "editor.defaultFormatter": "dbaeumer.vscode-eslint"`
	`12`	`+ "editor.defaultFormatter": "esbenp.prettier-vscode"`
`13`	`13`	`}`
`14`	`14`	`}`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ export async function executeFailingTypeORMQuery(): Promise<QueryResult \| void>`
`58`	`58`	`SELECT * From UnexistingTable`
`59`	`59`	`)) as QueryResult
`60`	`60`	`return manualQuery`
`61`		`- } catch (e) {`
	`61`	`+ } catch {`
`62`	`62`	`console.warn('should have cached')`
`63`	`63`	`}`
`64`	`64`	`}`
Original file line number	Diff line number	Diff line change
`@@ -350,7 +350,7 @@ export function registerUnitTests() {`
`350`	`350`	`'INSERT INTO "User" (id, name, age, networth) VALUES(?, ?, ?, ?)',`
`351`	`351`	`[id, name, age, networth]`
`352`	`352`	`)`
`353`		`- } catch (e) {`
	`353`	`+ } catch {`
`354`	`354`	`tx.rollback()`
`355`	`355`	`}`
`356`	`356`	`})`