Bug 1994864 [wpt PR 55493] - [EventTiming] Rename targetIdentifier to targetSelector after feedback., a=testonly

marco-c · marco-c · commit 57d9f8c5ad34 · 2025-10-29T18:35:36.000Z
Automatic update from web-platform-tests [EventTiming] Rename targetIdentifier to targetSelector after feedback. Recently presented this new feature to the Web Performance WG at a biweekly meeting and got strong positive support, but feedback that the name is misleading (confusing with just element.id value), and also that the specific format of the query-selector for target might need to evolve in the future. Renaming based on that feedback, and will update spec wording PR. Spec Issue: w3c/event-timing#126 I2P: https://chromestatus.com/feature/5143499213242368 Spec: w3c/event-timing#160 Bug: 40887145 Change-Id: I154c6706578fa88485aa9a91eb6f8e8a700beb5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7044923 Reviewed-by: Scott Haseley <shaseleychromium.org> Commit-Queue: Michal Mocny <mmocnychromium.org> Cr-Commit-Position: refs/heads/main{#1530914} -- wpt-commits: 021f7cd491c9d71de9631d9bdc13c299e2e512a2 wpt-pr: 55493 UltraBlame original commit: 43c56e6d62d3146db7ad65945ae091e737c131d3
diff --git a/testing/web-platform/tests/event-timing/target-selector.tentative.html b/testing/web-platform/tests/event-timing/target-selector.tentative.html
@@ -2,7 +2,7 @@
 <html>
 <meta charset=utf-8 />
 <meta name="timeout" content="long">
-<title>Event Timing targetIdentifier.</title>
+<title>Event Timing targetSelector.</title>
 <script src=/resources/testharness.js></script>
 <script src=/resources/testharnessreport.js></script>
 <script src=/resources/testdriver.js></script>
@@ -14,16 +14,14 @@
 <img id='img-with-id-and-src' src='/images/blue.png'>
 <img src='/images/green.png'>
 <script>
-  function verifyTargetIdentifier(entry, target) {
-    if ('targetIdentifier' in entry) {
-      let expectedIdentifier = target.tagName;
-      if (target.id) {
-        expectedIdentifier += '#' + target.id;
-      } else if (target.hasAttribute('src')) {
-        expectedIdentifier += '[src="' + target.getAttribute('src') + '"]';
-      }
-      assert_equals(entry.targetIdentifier, expectedIdentifier);
+  function computeExpectedTargetSelector(target) {
+    let selector = target.tagName;
+    if (target.id) {
+      selector += '#' + target.id;
+    } else if (target.hasAttribute('src')) {
+      selector += '[src="' + target.getAttribute('src') + '"]';
     }
+    return selector;
   }
 
   function runTest(t, eventType, target) {
@@ -41,11 +39,9 @@
         assert_equals(entry.name, eventType);
         assert_equals(entry.entryType, 'event');
         assert_equals(entry.target, target);
-        verifyTargetIdentifier(entry, target);
-        if (entry.target) {
-          const matchingElements = document.querySelectorAll(entry.targetIdentifier);
-          assert_true(Array.from(matchingElements).includes(target));
-        }
+        assert_equals(entry.targetSelector, computeExpectedTargetSelector(entry.target));
+        const matchingElements = document.querySelectorAll(entry.targetSelector);
+        assert_true(Array.from(matchingElements).includes(target));
       });
   }
 
@@ -90,7 +86,7 @@
     // The garbage collector might need some time to collect |target|.
     await new Promise(r => t.step_timeout(r, 0));
     assert_equals(entry.target, null);
-    assert_equals(entry.targetIdentifier, expectedIdentifier);
+    assert_equals(entry.targetSelector, expectedIdentifier);
   }, "Test with disconnected target");
 </script>
-</html>
+</html>
