Merge pull request #1 from mapbox/pomo-proto

add 3 levels of prototypes to Feature.prototype

Author: ian29

index.js

@@ -46,7 +46,12 @@ function stubService(service) {
   var client = new Original();
 
   function FakeService(config) { Object.assign(this, new Original(config)); }
-  FakeService.prototype = Object.assign({}, client.__proto__);
+  FakeService.prototype = Object.assign(
+    {},
+    client.__proto__.__proto__.__proto__,
+    client.__proto__.__proto__,
+    client.__proto__
+  );
 
   var spy = sinon.spy(FakeService);
   spy.restore = function() { setService(service, Original); };

test/index.test.js

@@ -233,3 +233,23 @@ test('[multipleMethods] replacement function', function(assert) {
     assert.end();
   });
 });
+
+test('[upload] methods inherited multiple times', function(assert) {
+  var upload = AWS.stub('S3', 'upload', function(params, callback) {
+    callback(null, data);
+  });
+
+  app.upload(function(err, data) {
+    assert.ifError(err, 'success');
+    assert.equal(data, 'hello world');
+
+    assert.equal(AWS.S3.callCount, 1, 'one s3 client created');
+    assert.ok(AWS.S3.calledWithExactly({ region }), 's3 client created for the correct region');
+
+    assert.equal(upload.callCount, 1, 'called s3.upload once');
+    assert.ok(upload.calledWith(expected), 'called s3.upload with expected params');
+
+    AWS.S3.restore();
+    assert.end();
+  });
+});

test/test-app.js

@@ -1,6 +1,6 @@
 var AWS = require('aws-sdk');
 
-module.exports = { useCallback, usePromise, streaming, useEvents, multipleMethods };
+module.exports = { useCallback, usePromise, streaming, useEvents, multipleMethods, upload };
 
 function useCallback(callback) {
   var s3 = new AWS.S3({ region: 'eu-west-1' });
@@ -47,3 +47,11 @@ function multipleMethods(callback) {
     .then(function(data) { callback(null, data.Body.toString()); })
     .catch(callback);
 }
+
+function upload(callback) {
+  var s3 = new AWS.S3({ region: 'eu-west-1' });
+  s3.upload({ Bucket: 'bucket', Key: 'key' }, function(err, data) {
+    if (err) return callback(err);
+    callback(null, data.Body.toString());
+  });
+}