Skip to content

Commit bb81267

Browse files
committed
update response interface
1 parent d8e8d5e commit bb81267

File tree

4 files changed

+29
-22
lines changed

4 files changed

+29
-22
lines changed

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
44

55
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html)
66

7+
## [4.0.1]  (2020-08-11)
8+
9+
### Fixed
10+
11+
- Updated api response interfaces to indicate optional vs required params
12+
713
## [4.0.0]  (2020-08-11)
814

915
### Changed
@@ -259,6 +265,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/),
259265
- Update older libraries
260266
- Now publish from Git tags instead of master pushes
261267

268+
[4.0.1]: https://github.com/manwaring/lambda-wrapper/compare/v4.0.0...v4.0.1
262269
[4.0.0]: https://github.com/manwaring/lambda-wrapper/compare/v3.7.0...v4.0.0
263270
[3.7.0]: https://github.com/manwaring/lambda-wrapper/compare/v3.6.3...v3.7.0
264271
[3.6.3]: https://github.com/manwaring/lambda-wrapper/compare/v3.6.2...v3.6.3

README.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -123,12 +123,12 @@ export interface ApiSignature<T = any> {
123123
headers: { [name: string]: string }; // headers as key-value pairs
124124
testRequest: boolean; // indicates if this is a test request - looks for a header matching process.env.TEST_REQUEST_HEADER (dynamic from application) or 'Test-Request' (default)
125125
auth: any; // auth context from custom authorizer
126-
success(paramaters: ResponseParameters): ApiResponse;
127-
invalid(paramaters: ResponseParameters): ApiResponse;
128-
notFound(paramaters: ResponseParameters): ApiResponse;
129-
notAuthorized(paramaters: ResponseParameters): ApiResponse;
130-
redirect(parameters: RedirectParameters): ApiResponse;
131-
error(parameters: ErrorParameters): ApiResponse;
126+
success(params?: ResponseParameters): ApiResponse;
127+
invalid(params?: ResponseParameters): ApiResponse;
128+
notFound(params?: ResponseParameters): ApiResponse;
129+
notAuthorized(params?: ResponseParameters): ApiResponse;
130+
redirect(params: RedirectParameters): ApiResponse;
131+
error(params?: ErrorParameters): ApiResponse;
132132
}
133133
```
134134

@@ -615,12 +615,12 @@ export interface HttpApiSignature<T = any> {
615615
headers: { [name: string]: string }; // headers as key-value pairs
616616
testRequest: boolean; // indicates if this is a test request - looks for a header matching process.env.TEST_REQUEST_HEADER (dynamic from application) or 'Test-Request' (default)
617617
auth: any; // auth context from JWT authorizer
618-
success(paramaters: ResponseParameters): ApiResponse;
619-
invalid(paramaters: ResponseParameters): ApiResponse;
620-
notFound(paramaters: ResponseParameters): ApiResponse;
621-
notAuthorized(paramaters: ResponseParameters): ApiResponse;
622-
redirect(parameters: RedirectParameters): ApiResponse;
623-
error(parameters: ErrorParameters): ApiResponse;
618+
success(params?: ResponseParameters): ApiResponse;
619+
invalid(params?: ResponseParameters): ApiResponse;
620+
notFound(params?: ResponseParameters): ApiResponse;
621+
notAuthorized(params?: ResponseParameters): ApiResponse;
622+
redirect(params: RedirectParameters): ApiResponse;
623+
error(params?: ErrorParameters): ApiResponse;
624624
}
625625
```
626626

src/api/v1/wrapper.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,12 @@ export interface ApiSignature<T = any> {
4747
headers: { [name: string]: string };
4848
testRequest: boolean;
4949
auth: any;
50-
success(params: ResponseParameters): ApiResponse;
51-
invalid(params: ResponseParameters): ApiResponse;
52-
notFound(params: ResponseParameters): ApiResponse;
53-
notAuthorized(params: ResponseParameters): ApiResponse;
50+
success(params?: ResponseParameters): ApiResponse;
51+
invalid(params?: ResponseParameters): ApiResponse;
52+
notFound(params?: ResponseParameters): ApiResponse;
53+
notAuthorized(params?: ResponseParameters): ApiResponse;
5454
redirect(params: RedirectParameters): ApiResponse;
55-
error(params: ErrorParameters): ApiResponse;
55+
error(params?: ErrorParameters): ApiResponse;
5656
}
5757

5858
export interface WebsocketRequest {

src/api/v2-http/wrapper.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,10 @@ export interface HttpApiSignature<T = any> {
4646
headers: { [name: string]: string };
4747
testRequest: boolean;
4848
auth: any;
49-
success(params: ResponseParameters): ApiResponse;
50-
invalid(params: ResponseParameters): ApiResponse;
51-
notFound(params: ResponseParameters): ApiResponse;
52-
notAuthorized(params: ResponseParameters): ApiResponse;
49+
success(params?: ResponseParameters): ApiResponse;
50+
invalid(params?: ResponseParameters): ApiResponse;
51+
notFound(params?: ResponseParameters): ApiResponse;
52+
notAuthorized(params?: ResponseParameters): ApiResponse;
5353
redirect(params: RedirectParameters): ApiResponse;
54-
error(params: ErrorParameters): ApiResponse;
54+
error(params?: ErrorParameters): ApiResponse;
5555
}

0 commit comments

Comments
 (0)