update signature params to be undefined instead of null

Author: manwaring

.npmrc

@@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html)
 
+## [3.0.1]  (2020-01-20)
+
+### Changed
+
+- Missing signature params as undefined instead of null to allow for default values
+- Updated libraries
+
 ## [3.0.0]  (2020-01-05)
 
 ### Changed

CHANGELOG.md

@@ -1,7 +1,7 @@
 {
   "name": "@manwaring/lambda-wrapper",
   "description": "A lambda handler wrapper to abstract common functionality and provide useful defaults",
-  "version": "3.0.0",
+  "version": "3.0.1",
   "scripts": {
     "publish-please-dry-run": "publish-please --dry-run",
     "publish-please": "publish-please",
@@ -16,24 +16,24 @@
     "cfn-response": "^1.0.1"
   },
   "devDependencies": {
-    "@babel/core": "^7.7.7",
-    "@babel/plugin-proposal-class-properties": "^7.7.4",
-    "@babel/preset-env": "^7.7.7",
-    "@babel/preset-typescript": "^7.7.7",
+    "@babel/core": "^7.8.3",
+    "@babel/plugin-proposal-class-properties": "^7.8.3",
+    "@babel/preset-env": "^7.8.3",
+    "@babel/preset-typescript": "^7.8.3",
     "@serverless/event-mocks": "^1.1.1",
     "@types/aws-lambda": "^8.10.39",
     "@types/cfn-response": "^1.0.1",
-    "@types/jest": "^24.0.25",
-    "@types/node": "^13.1.4",
-    "aws-lambda": "^1.0.4",
-    "aws-sdk": "^2.597.0",
+    "@types/jest": "^24.9.0",
+    "@types/node": "^13.1.8",
+    "aws-lambda": "^1.0.5",
+    "aws-sdk": "^2.606.0",
     "babel-jest": "^24.9.0",
     "codecov": "^3.6.1",
     "husky": "^2.7.0",
     "jest": "^24.9.0",
     "publish-please": "^5.5.1",
     "rimraf": "^3.0.0",
-    "typescript": "^3.7.4"
+    "typescript": "^3.7.5"
   },
   "husky": {
     "hooks": {

package-lock.json

@@ -74,4 +74,20 @@ describe('Request parsing', () => {
     expect(headers).toBeFalsy();
     expect(testRequest).toBeFalsy();
   });
+
+  it('Supports default values in method signature', () => {
+    // @ts-ignore
+    const event = createEvent('aws:apiGateway', {});
+    delete event.body;
+    delete event.headers;
+    delete event.pathParameters;
+    delete event.queryStringParameters;
+    const { path = {}, query = {} } = new Request(event).getProperties();
+
+    const { notThere = 2 } = query;
+    expect(notThere).toEqual(2);
+
+    const { alsoNotThere = 3 } = path;
+    expect(alsoNotThere).toEqual(3);
+  });
 });

package.json

@@ -9,10 +9,10 @@ export class Request {
 
   getProperties(): any {
     const event = this.event;
-    const path = event.pathParameters ? event.pathParameters : null;
-    const query = event.queryStringParameters ? event.queryStringParameters : null;
-    const auth = event.requestContext && event.requestContext.authorizer ? event.requestContext.authorizer : null;
-    const headers = event.headers ? event.headers : null;
+    const path = event.pathParameters ? event.pathParameters : undefined;
+    const query = event.queryStringParameters ? event.queryStringParameters : undefined;
+    const auth = event.requestContext && event.requestContext.authorizer ? event.requestContext.authorizer : undefined;
+    const headers = event.headers ? event.headers : undefined;
     const body = new Body(event.body, headers).getParsedBody();
     const TEST_REQUEST_HEADER = process.env.TEST_REQUEST_HEADER || 'Test-Request';
     const testRequest = headers && headers[TEST_REQUEST_HEADER] ? JSON.parse(headers[TEST_REQUEST_HEADER]) : false;

src/api/parser.test.ts

@@ -117,14 +117,14 @@ describe('DynamoDB stream parsing', () => {
     });
     expect(versions).toContainEqual({
       newVersion: { Message: 'hasta la vista', Id: 456 },
-      oldVersion: null,
+      oldVersion: undefined,
       keys: { Id: 456 },
       tableName: 'table',
       tableArn: 'arn:aws:dynamodb:us-east-1:1234567890:table/table',
       eventName: 'INSERT'
     });
     expect(versions).toContainEqual({
-      newVersion: null,
+      newVersion: undefined,
       oldVersion: { Message: 'buongiorno', Id: 789 },
       keys: { Id: 789 },
       tableName: 'table',

src/api/parser.ts

@@ -26,8 +26,8 @@ export class DynamoDBStreamParser {
   private parseVersions(record: DynamoDBRecord) {
     const { eventName } = record;
     const { NewImage, OldImage, Keys } = record.dynamodb;
-    const newVersion = NewImage ? DynamoDB.Converter.unmarshall(NewImage) : null;
-    const oldVersion = OldImage ? DynamoDB.Converter.unmarshall(OldImage) : null;
+    const newVersion = NewImage ? DynamoDB.Converter.unmarshall(NewImage) : undefined;
+    const oldVersion = OldImage ? DynamoDB.Converter.unmarshall(OldImage) : undefined;
     const keys = DynamoDB.Converter.unmarshall(Keys);
     const { tableName, tableArn } = this.getTableInformation(record);
     const version: Version = { newVersion, oldVersion, keys, tableName, tableArn, eventName };

src/dynamodb-stream/parser.test.ts

@@ -28,7 +28,7 @@ describe('DynamoDB Stream wrapper', () => {
       expect(versions).toEqual([
         {
           newVersion: { Message: 'New item!', Id: 101 },
-          oldVersion: null,
+          oldVersion: undefined,
           keys: { Id: 101 },
           tableName: 'images',
           tableArn: 'arn:aws:dynamodb:us-east-1:123456789012:table/images',