Check if each view inherits from DRF's ApiView

Author: Emmanouil Konstantinidis

drfdocs/api_docs.py

@@ -1,6 +1,7 @@
 from django.conf import settings
 from django.core.urlresolvers import RegexURLResolver, RegexURLPattern
 from drfdocs.api_endpoint import ApiEndpoint
+from rest_framework.views import APIView
 
 
 class ApiDocumentation(object):
@@ -16,13 +17,15 @@ def get_all_view_names(self, urlpatterns, parent_pattern=None):
         for pattern in urlpatterns:
             if isinstance(pattern, RegexURLResolver) and (pattern.app_name not in self.excluded_apps):
                 self.get_all_view_names(urlpatterns=pattern.url_patterns, parent_pattern=pattern)
-            elif isinstance(pattern, RegexURLPattern) and (pattern.callback.__name__ not in self.excluded_endpoints):
+            elif isinstance(pattern, RegexURLPattern) and (pattern.callback.__name__ not in self.excluded_endpoints) and self._is_drf_view(pattern):
                 api_endpoint = ApiEndpoint(pattern, parent_pattern)
                 self.endpoints.append(api_endpoint)
 
-    def _filter_drf_views(self, endpoints):
-        # Should keep only the endpoints with views that inherit from DRF's APIView
-        pass
+    def _is_drf_view(self, pattern):
+        # Should check whether a pattern inherits from DRF's APIView
+        if (hasattr(pattern.callback, 'cls') and issubclass(pattern.callback.cls, APIView)):
+            return True
+        return False
 
     def get_endpoints(self):
         return self.endpoints

drfdocs/api_endpoint.py

@@ -1,5 +1,4 @@
 from django.contrib.admindocs.views import simplify_regex
-from rest_framework.views import APIView
 
 
 class ApiEndpoint(object):
@@ -11,11 +10,3 @@ def __init__(self, pattern, parent_pattern=None):
         self.url_name = pattern.name
         self.regex = simplify_regex(pattern._regex)
         self.view_name = pattern.callback.__name__
-        # self._get_api_callback(pattern)
-
-    def _get_api_callback(self, pattern):
-        """
-        Verifies that pattern callback is a subclass of APIView, and returns the class
-        """
-        if (hasattr(pattern.callback, 'cls') and issubclass(pattern.callback.cls, APIView)):
-            return pattern.callback.cls