Skip to content

Commit fcc4312

Browse files
committed
Fixed unit test
1 parent 5ed27e8 commit fcc4312

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

pytest-server-fixtures/tests/integration/test_httpd_proxy_server.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
def test_start_and_stop(httpd_server):
44
assert httpd_server.check_server_up()
5-
pid = int((httpd_server.workspace / 'run' / 'httpd.pid').read_text())
5+
pid = httpd_server.pid
66
httpd_server.kill()
77
assert not httpd_server.check_server_up()
88
still_running = [i for i in psutil.process_iter()

pytest-server-fixtures/tests/unit/test_server_unit.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,10 @@ def test_kill():
2727
hostname=sentinel.hostname,
2828
port=sentinel.port)
2929
self.run.side_effect = ['100\n', '', '']
30-
with patch('os.kill') as kill:
31-
with patch('socket.gethostbyname', return_value=sentinel.ip):
32-
_TestServer._find_and_kill_by_port(self, 2, sentinel.signal)
30+
with patch('socket.gethostbyname', return_value=sentinel.ip):
31+
_TestServer._find_and_kill_by_port(self, 2, sentinel.signal)
3332
assert self.run.call_args_list == [call("netstat -anp 2>/dev/null | grep sentinel.ip:sentinel.port "
3433
"| grep LISTEN | awk '{ print $7 }' | cut -d'/' -f1", capture=True, cd='/'),
3534
call("netstat -anp 2>/dev/null | grep sentinel.ip:sentinel.port "
3635
"| grep LISTEN | awk '{ print $7 }' | cut -d'/' -f1", capture=True, cd='/')]
37-
assert kill.call_args_list == [call(100, sentinel.signal)]
36+
assert self._signal.call_args_list == [call(100, sentinel.signal)]

0 commit comments

Comments
 (0)