Fix a few more tests

Author: jonbannister

pytest-devpi-server/tests/integration/test_devpi_server.py

@@ -1,4 +1,5 @@
 import json
+from pathlib import Path
 
 NEW_INDEX = {
     u"result": {
@@ -23,7 +24,7 @@ def test_server(devpi_server):
 
 
 def test_upload(devpi_server):
-    pkg_dir = devpi_server.workspace / "pkg"
+    pkg_dir: Path = devpi_server.workspace / "pkg"
     pkg_dir.mkdir(exist_ok=True)
     setup_py = pkg_dir / "setup.py"
     setup_py.write_text(
@@ -33,7 +34,6 @@ def test_upload(devpi_server):
       version='1.2.3')
 """
     )
-    pkg_dir.chdir()
     devpi_server.api("upload")
     res = devpi_server.api(
         "getjson", "/{}/{}".format(devpi_server.user, devpi_server.index)

pytest-profiling/tests/integration/test_profile_integration.py

@@ -44,7 +44,7 @@ def test_profile_generates_svg(pytestconfig, virtualenv):
     assert any(
         [
             "test_example:1:test_foo" in i
-            for i in (virtualenv.workspace / "prof/combined.svg").lines()
+            for i in (virtualenv.workspace / "prof/combined.svg").open().readlines()
         ]
     )
 
@@ -58,7 +58,7 @@ def test_profile_long_name(pytestconfig, virtualenv):
         pytestconfig,
         cd=virtualenv.workspace,
     )
-    assert (virtualenv.workspace / "prof/fbf7dc37.prof").isfile()
+    assert (virtualenv.workspace / "prof/fbf7dc37.prof").is_file()
 
 
 def test_profile_chdir(pytestconfig, virtualenv):

pytest-server-fixtures/tests/integration/test_httpd_proxy_server.py

@@ -11,7 +11,7 @@ def test_start_and_stop(httpd_server):
 
 
 def test_logs(httpd_server):
-    files = [i.basename() for i in httpd_server.log_dir.files()]
+    files = [i.name for i in httpd_server.log_dir.iterdir()]
     for log in ('access.log', 'error.log'):
         assert log in files