pytest-virtualenv: Add delete_workspace parameter (closes: #195)

Author: aflag

pytest-virtualenv/pytest_virtualenv.py

@@ -108,11 +108,16 @@ class VirtualEnv(Workspace):
         path to the virtualenv base dir
     env : 'list'
         environment variables used in creation of virtualenv
-
+    delete_workspace: `None or bool`
+        If True then the workspace will be deleted
+        If False then the workspace will be kept
+        If None (default) then the workspace will be deleted if workspace is also None, but it will be kept otherwise
     """
     # TODO: update to use pip, remove distribute
-    def __init__(self, env=None, workspace=None, name='.env', python=None, args=None):
-        Workspace.__init__(self, workspace)
+    def __init__(self, env=None, workspace=None, name='.env', python=None, args=None, delete_workspace=None):
+        if delete_workspace is None:
+            delete_workspace = workspace is None
+        Workspace.__init__(self, workspace, delete_workspace)
         self.virtualenv = self.workspace / name
         self.args = args or []
         if sys.platform == 'win32':

pytest-virtualenv/tests/integration/test_tmpvirtualenv.py

@@ -1,4 +1,5 @@
 import os
+import pathlib
 import subprocess
 import sys
 import textwrap
@@ -73,3 +74,45 @@ def test_install_latest():
     with venv.VirtualEnv() as v:
         v.install_package("flask")
         assert v.installed_packages()["Flask"].version != "1.1.1"
+
+
+def test_keep_named_workspace(tmp_path):
+    workspace = tmp_path / "new-workspace"
+    workspace.mkdir()
+    with venv.VirtualEnv(workspace=str(workspace)) as v:
+        pass
+    assert workspace.exists()
+
+
+def test_really_keep_named_workspace(tmp_path):
+    workspace = tmp_path / "new-workspace"
+    workspace.mkdir()
+    with venv.VirtualEnv(workspace=str(workspace), delete_workspace=False) as v:
+        pass
+    assert workspace.exists()
+
+
+def test_delete_named_workspace(tmp_path):
+    workspace = tmp_path / "new-workspace"
+    workspace.mkdir()
+    with venv.VirtualEnv(workspace=str(workspace), delete_workspace=True) as v:
+        pass
+    assert not workspace.exists()
+
+
+def test_delete_unamed_workspace():
+    with venv.VirtualEnv() as v:
+        workspace = pathlib.Path(v.workspace)
+    assert not workspace.exists()
+
+
+def test_really_delete_unamed_workspace():
+    with venv.VirtualEnv(delete_workspace=True) as v:
+        workspace = pathlib.Path(v.workspace)
+    assert not workspace.exists()
+
+
+def test_keep_unamed_workspace():
+    with venv.VirtualEnv(delete_workspace=False) as v:
+        workspace = pathlib.Path(v.workspace)
+    assert workspace.exists()