Skip to content

Commit e7b6045

Browse files
committed
Fixing Dockerfile and docker-compose.yaml
1 parent 45d07e4 commit e7b6045

File tree

2 files changed

+9
-14
lines changed

2 files changed

+9
-14
lines changed

docker/Dockerfile

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,8 @@ COPY . /workspace
77

88
WORKDIR /workspace/notebooker/web/static
99
RUN set -eux \
10-
; yarn install --frozen-lockfile \
11-
; yarn list --depth=0 \
12-
; yarn run lint \
10+
; npm install \
11+
; yarn bundle \
1312
; ls -lah node_modules
1413

1514

@@ -32,18 +31,19 @@ WORKDIR /workspace
3231
RUN set -eux \
3332
; pip install -e ".[prometheus, test, docs]" \
3433
; python -m ipykernel install --user --name=notebooker_kernel \
34+
; pip install nbformat jupyter-core jupyter-client --upgrade \
3535
; pip install -r ./notebooker/notebook_templates_example/notebook_requirements.txt \
3636
; python setup.py develop \
3737
; python setup.py build_sphinx \
3838
; py.test tests \
3939
; python setup.py bdist_wheel --universal
4040

4141

42-
FROM continuumio/anaconda3:2020.07-alpine
42+
FROM continuumio/anaconda3
4343
USER root
44-
# FIXME: more is needed to generate PDFs: latest error is `LaTeX Error: File `tcolorbox.sty' not found.`
45-
RUN apk add git texlive-xetex
46-
USER anaconda
44+
45+
# Needed for PDF generation
46+
RUN apt-get update && apt-get install -y git texlive-xetex
4747

4848
WORKDIR /app
4949

docker/docker-compose.yaml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
version: "3"
22

33
services:
4-
# note:
5-
# * the templates' required python modules must be baked into the image
64
notebooker:
75
build:
86
context: ..
@@ -11,20 +9,17 @@ services:
119
# config variables are defined in notebooker/web/config/setting.py
1210
PORT: 11828
1311
LOGGING_LEVEL: info
14-
1512
MONGO_USER: root
1613
MONGO_PASSWORD: toor
1714
MONGO_HOST: mongodb:27017
18-
# this should be something like "notebooker" but this simplifies the compose file
1915
DATABASE_NAME: admin
2016
RESULT_COLLECTION_NAME: NOTEBOOK_OUTPUT
21-
2217
PY_TEMPLATE_BASE_DIR: /var/run/template_repo
2318
volumes:
2419
- git-repo:/var/run/template_repo
25-
command: ["notebooker_webapp"]
20+
command: ["notebooker-cli", "--mongo-host", "${MONGO_HOST}", "--mongo-user", "${MONGO_USER}", "--mongo-password", "${MONGO_USER}", "start-webapp", "--port", "${PORT}"]
2621
ports:
27-
- 8080:11828
22+
- "8080:11828"
2823
depends_on:
2924
- mongodb
3025
restart: always

0 commit comments

Comments
 (0)