Skip to content

Commit 3cf6e63

Browse files
authored
fix(ingest): improve entity type -> graphql enum conversion (datahub-project#14269)
1 parent ea2ac36 commit 3cf6e63

File tree

1 file changed

+19
-3
lines changed
  • metadata-ingestion/src/datahub/ingestion/graph

1 file changed

+19
-3
lines changed

metadata-ingestion/src/datahub/ingestion/graph/client.py

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,15 @@
7676
SystemMetadataClass,
7777
TelemetryClientIdClass,
7878
)
79-
from datahub.metadata.urns import CorpUserUrn, Urn
79+
from datahub.metadata.urns import (
80+
CorpUserUrn,
81+
MlFeatureTableUrn,
82+
MlFeatureUrn,
83+
MlModelGroupUrn,
84+
MlModelUrn,
85+
MlPrimaryKeyUrn,
86+
Urn,
87+
)
8088
from datahub.telemetry.telemetry import telemetry_instance
8189
from datahub.utilities.perf_timer import PerfTimer
8290
from datahub.utilities.str_enum import StrEnum
@@ -118,8 +126,16 @@ def entity_type_to_graphql(entity_type: str) -> str:
118126
"""Convert the entity types into GraphQL "EntityType" enum values."""
119127

120128
# Hard-coded special cases.
121-
if entity_type == CorpUserUrn.ENTITY_TYPE:
122-
return "CORP_USER"
129+
special_cases = {
130+
CorpUserUrn.ENTITY_TYPE: "CORP_USER",
131+
MlModelUrn.ENTITY_TYPE: "MLMODEL",
132+
MlModelGroupUrn.ENTITY_TYPE: "MLMODEL_GROUP",
133+
MlFeatureTableUrn.ENTITY_TYPE: "MLFEATURE_TABLE",
134+
MlFeatureUrn.ENTITY_TYPE: "MLFEATURE",
135+
MlPrimaryKeyUrn.ENTITY_TYPE: "MLPRIMARY_KEY",
136+
}
137+
if entity_type in special_cases:
138+
return special_cases[entity_type]
123139

124140
# Convert camelCase to UPPER_UNDERSCORE.
125141
entity_type = (

0 commit comments

Comments
 (0)