fix: issue with layout group having an underscore in their id + mirrored section bug

Author: did

app/frontend/editor/store/getters.js

@@ -193,7 +193,8 @@ export default (services) => ({
   isMirroredSection: ({ section }) => {
     return !isBlank(section.mirrorOf)
   },
-  isMirroredSectionEditable: ({ theme, section, page }, {}) => {
+  isMirroredSectionEditable: ({ theme, section, page }, { isMirroredSection }) => {
+    if (!isMirroredSection) return false
     if (section.mirrorOf.enabled === false) return true
     return theme.mirrorSection === true || (theme.mirrorSection === 'protected' && section.mirrorOf?.pageId === page.id)
   }

app/frontend/editor/store/mutations.js

@@ -61,10 +61,10 @@ export default (services) => ({
     state.sectionBlocks = { ...state.sectionBlocks, ...entities.blocks }
   },
   SET_SECTIONS_CONTENT_LOCK_VERSIONS(state, lockVersions) {
-    for (const layoutGroupId in lockVersions) {
+    for (const { layoutGroupId, lockVersion } of lockVersions) {
       state.layoutGroups[layoutGroupId] = { 
         ...state.layoutGroups[layoutGroupId], 
-        lockVersion: lockVersions[layoutGroupId]
+        lockVersion
       }
     }
   },

app/services/maglev/get_page_sections.rb

@@ -62,7 +62,6 @@ def fetch_stored_sections(group)
     end
 
     def fetch_local_sections(layout_group)
-      # TODO: potential bug here, why not relying on group['store'] instead of group['id']? what about page related store?
       content_group = sections_content.find { |group| group['id'] == layout_group.id }
 
       return [[], 0] if content_group.blank?

app/views/maglev/api/sections_content/update.json.jbuilder

@@ -3,4 +3,6 @@
 json.key_format! camelize: :lower
 json.deep_format_keys!
 
-json.lock_versions(@stores.transform_values(&:lock_version))
+json.lock_versions(@stores.transform_values(&:lock_version).to_a.map do |(layout_group_id, lock_version)|
+  { layout_group_id: layout_group_id, lock_version: lock_version }
+end)

spec/requests/maglev/api/sections_content_spec.rb

@@ -67,7 +67,11 @@
           expect(response).to have_http_status(:ok)
           # rubocop:disable Style/StringHashKeys
           expect(json_response).to match({
-                                           'lockVersions' => { 'footer' => 0, 'header' => 1, 'main' => 1 }
+                                           'lockVersions' => [
+                                             { 'layoutGroupId' => 'header', 'lockVersion' => 1 },
+                                             { 'layoutGroupId' => 'main', 'lockVersion' => 1 },
+                                             { 'layoutGroupId' => 'footer', 'lockVersion' => 0 }
+                                           ]
                                          })
           # rubocop:enable Style/StringHashKeys
         end