Skip to content

Commit f297378

Browse files
committed
AC-3179: Fixing Mftf AdminLoginReCaptchaFunctionalityTest
1 parent f0ed5de commit f297378

File tree

4 files changed

+16
-12
lines changed

4 files changed

+16
-12
lines changed

ReCaptchaUser/Test/Mftf/ActionGroup/RecaptchaDisabledActionGroup.xml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,19 @@
1010
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
1111
<actionGroup name="RecaptchaDisabledActionGroup">
1212
<annotations>
13-
<description>Enable or disable admin login recaptcha</description>
13+
<description>Disable admin login recaptcha</description>
1414
</annotations>
1515
<arguments>
1616
<argument name="optionValue" type="string" defaultValue="{{recaptchaFormDisabled.value}}"/>
1717
</arguments>
1818

19-
<amOnPage url="{{AdminStoreConfigurationPage.url}}" stepKey="navigateToAdminStoreConfiguration"/>
20-
<scrollTo selector="{{RecaptchaFormSection.label}}" stepKey="scrollToDropdown" />
21-
<click selector="{{RecaptchaFormSection.optionvalue}}" stepKey="clickedEnableForLogin"/>
22-
<selectOption selector="{{RecaptchaFormSection.optionvalue}}" userInput="{{optionValue}}" stepKey="setValue"/>
23-
<click selector="{{RecaptchaFormSection.saveConfig}}" stepKey="clickSave"/>
19+
<amOnPage url="{{AdminStoreConfigurationPage.url}}" stepKey="navigateToAdminStoresConfiguration"/>
20+
<conditionalClick selector="{{RecaptchaFormSection.adminblock}}" dependentSelector="{{RecaptchaFormSection.label}}" visible="false" stepKey="expand_panel"/>
21+
<scrollTo selector="{{RecaptchaFormSection.label}}" stepKey="scroll_to_dropdown" />
22+
<wait time="2" stepKey="wait_for_Load"/>
23+
<checkOption selector="{{RecaptchaFormSection.useConfigSettings}}" stepKey="check_config_setting"/>
24+
<wait time="2" stepKey="wait_for_load1"/>
25+
<click selector="{{RecaptchaFormSection.saveConfig}}" stepKey="click_save"/>
2426

2527
</actionGroup>
2628
</actionGroups>

ReCaptchaUser/Test/Mftf/ActionGroup/RecaptchaEnabledActionGroup.xml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,18 @@
1010
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
1111
<actionGroup name="RecaptchaEnabledActionGroup">
1212
<annotations>
13-
<description>Enable or disable admin login recaptcha</description>
13+
<description>Enable admin login recaptcha</description>
1414
</annotations>
1515
<arguments>
1616
<argument name="optionValue" type="string" defaultValue="{{recaptchaForm.value}}"/>
1717
</arguments>
1818

1919
<amOnPage url="{{AdminStoreConfigurationPage.url}}" stepKey="navigateToAdminStoreConfiguration"/>
20+
<conditionalClick selector="{{RecaptchaFormSection.adminblock}}" dependentSelector="{{RecaptchaFormSection.label}}" visible="false" stepKey="expand_panel"/>
2021
<scrollTo selector="{{RecaptchaFormSection.label}}" stepKey="scrollToDropdownSelection" />
21-
<wait time="3" stepKey="waitForColumnUpdateToSave"/>
22+
<wait time="2" stepKey="waitForLoad"/>
2223
<uncheckOption selector="{{RecaptchaFormSection.useConfigSettings}}" stepKey="uncheckConfigSetting"/>
23-
<wait time="3" stepKey="waitForColumnUpdateToSave1"/>
24+
<wait time="2" stepKey="waitForLoad_1"/>
2425
<selectOption selector="{{RecaptchaFormSection.optionvalue}}" userInput="{{optionValue}}" stepKey="setAttributeValue"/>
2526
<click selector="{{RecaptchaFormSection.saveConfig}}" stepKey="clickSave"/>
2627

ReCaptchaUser/Test/Mftf/Section/RecaptchaFormSection.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,6 @@
1313
<element name="saveConfig" type="button" selector="#save" timeout="30"/>
1414
<element name="label" type="input" selector="#row_recaptcha_backend_type_for_user_login"/>
1515
<element name="useConfigSettings" type="checkbox" selector="//input[@name='groups[type_for][fields][user_login][inherit]']"/>
16+
<element name="adminblock" type="button" selector='a#recaptcha_backend_type_for-head'/>
1617
</section>
1718
</sections>

ReCaptchaUser/Test/Mftf/Test/AdminLoginReCaptchaFunctionalityTest.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@
2020
<before>
2121
<actionGroup ref="AdminLoginActionGroup" stepKey="login"/>
2222
<actionGroup ref="RecaptchaEnabledActionGroup" stepKey="recaptchaEnabled"/>
23-
<!-- <actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>-->
24-
<!-- <actionGroup ref="AdminLoginActionGroup" stepKey="loginAgain11"/>-->
25-
<!-- <actionGroup ref="RecaptchaDisabledActionGroup" stepKey="recaptchaDisabled"/>-->
23+
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
24+
<actionGroup ref="AdminLoginActionGroup" stepKey="loginAgain11"/>
25+
<actionGroup ref="RecaptchaDisabledActionGroup" stepKey="recaptchaDisabled"/>
2626
</before>
2727
<after>
2828
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>

0 commit comments

Comments
 (0)