From 7bb95b27452e774c2bc38ffcb605f36b7c777fe8 Mon Sep 17 00:00:00 2001 From: del15881 Date: Wed, 8 Oct 2025 16:21:44 +0530 Subject: [PATCH 1/2] Fixing the Issues with Targetables on Release blocker --- .../lib/WebpackTools/targetables/TargetableSet.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/packages/pwa-buildpack/lib/WebpackTools/targetables/TargetableSet.js b/packages/pwa-buildpack/lib/WebpackTools/targetables/TargetableSet.js index 403493ca88..1119c307cf 100644 --- a/packages/pwa-buildpack/lib/WebpackTools/targetables/TargetableSet.js +++ b/packages/pwa-buildpack/lib/WebpackTools/targetables/TargetableSet.js @@ -24,7 +24,14 @@ class TargetableSet { } /** @hideconstructor */ constructor(targetProvider) { - if (!(targetProvider instanceof TargetProvider)) { + const isValidTargetProvider = targetProvider instanceof TargetProvider || + (targetProvider && + typeof targetProvider === 'object' && + typeof targetProvider.of === 'function' && + typeof targetProvider.name === 'string' && + targetProvider.constructor.name === 'TargetProvider'); + + if (!isValidTargetProvider) { throw new Error( 'Must supply a TargetProvider to a new TargetableSet.' ); From fefb5d63ffbcefad9b99f4c75489f88d07bdd121 Mon Sep 17 00:00:00 2001 From: del15881 Date: Wed, 8 Oct 2025 18:58:41 +0530 Subject: [PATCH 2/2] Fixing Prettier Issues --- .../lib/WebpackTools/targetables/TargetableSet.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/packages/pwa-buildpack/lib/WebpackTools/targetables/TargetableSet.js b/packages/pwa-buildpack/lib/WebpackTools/targetables/TargetableSet.js index 1119c307cf..93bfa0460a 100644 --- a/packages/pwa-buildpack/lib/WebpackTools/targetables/TargetableSet.js +++ b/packages/pwa-buildpack/lib/WebpackTools/targetables/TargetableSet.js @@ -24,12 +24,13 @@ class TargetableSet { } /** @hideconstructor */ constructor(targetProvider) { - const isValidTargetProvider = targetProvider instanceof TargetProvider || + const isValidTargetProvider = + targetProvider instanceof TargetProvider || (targetProvider && - typeof targetProvider === 'object' && - typeof targetProvider.of === 'function' && - typeof targetProvider.name === 'string' && - targetProvider.constructor.name === 'TargetProvider'); + typeof targetProvider === 'object' && + typeof targetProvider.of === 'function' && + typeof targetProvider.name === 'string' && + targetProvider.constructor.name === 'TargetProvider'); if (!isValidTargetProvider) { throw new Error(