Skip to content

Conversation

@glo82145
Copy link
Collaborator

@glo82145 glo82145 commented Oct 7, 2025

Description

TODO: Describe your changes in detail here.

Related Issue

Closes #ISSUE_NUMBER.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Oct 7, 2025

Fails
🚫 Lighthouse assertions failed 😔. All assertions must pass before this PR can be merged
https://pr-4559.pwa-venia.com/

categories.pwa (auditRan)

  • Expected: 1
  • Actual: 0
  • Result: Failed

Max Potential First Input Delay (maxNumericValue)

  • Expected: 520
  • Actual: 597.9999999999995
  • Result: Failed
  • Docs link: https://developer.chrome.com/docs/lighthouse/performance/lighthouse-max-potential-fid/

Total Blocking Time (minScore)

  • Expected: 0.35
  • Actual: 0.29
  • Result: Failed
  • Docs link: https://developer.chrome.com/docs/lighthouse/performance/lighthouse-total-blocking-time/
https://pr-4559.pwa-venia.com/venia-tops.html?page=1

categories.pwa (auditRan)

  • Expected: 1
  • Actual: 0
  • Result: Failed

Max Potential First Input Delay (maxNumericValue)

  • Expected: 520
  • Actual: 603
  • Result: Failed
  • Docs link: https://developer.chrome.com/docs/lighthouse/performance/lighthouse-max-potential-fid/
https://pr-4559.pwa-venia.com/valeria-two-layer-tank.html

categories.pwa (auditRan)

  • Expected: 1
  • Actual: 0
  • Result: Failed
https://pr-4559.pwa-venia.com/search.html?query=tops&page=1

categories.pwa (auditRan)

  • Expected: 1
  • Actual: 0
  • Result: Failed

Max Potential First Input Delay (maxNumericValue)

  • Expected: 520
  • Actual: 604
  • Result: Failed
  • Docs link: https://developer.chrome.com/docs/lighthouse/performance/lighthouse-max-potential-fid/
🚫

node failed.

Log

ERROR ON TASK: lighthouseTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results-5a98b64a.json

Generated by 🚫 dangerJS against 35c2f42

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Oct 7, 2025

Fails
🚫

node failed.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 35c2f42

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Oct 7, 2025

Fails
🚫 A version label is required. A maintainer must add one.
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

🚫 Missing information in PR. Please fill out the "Description" section.
Warnings
⚠️ Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against 35c2f42

del22123
del22123 previously approved these changes Oct 7, 2025
@glo82145 glo82145 changed the base branch from develop to release/14.4.0 October 7, 2025 07:33
@glo82145 glo82145 dismissed del22123’s stale review October 7, 2025 07:33

The base branch was changed.

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • displays assigned products:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="CategoryContent-root"] [data-cy="GalleryItem-name"], [data-cy="SearchPage-root"] [data-cy="GalleryItem-name"]`, but never found it.
    ,shows products specific to the categories in the different store:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="CategoryContent-root"] [data-cy="GalleryItem-name"], [data-cy="SearchPage-root"] [data-cy="GalleryItem-name"]`, but never found it.
    ,lets users add products to cart regardless of store view:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="CategoryContent-root"] [data-cy="GalleryItem-root"]`, but never found it.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 35c2f42

@glo82145 glo82145 merged commit 1fc70cb into release/14.4.0 Oct 7, 2025
6 of 13 checks passed
glo82145 added a commit that referenced this pull request Oct 15, 2025
* Sync main 14.3.1 (#4533)

* v14.3.1-alpha1

* Merge pull request #4525 from magento/patch/npm-access-update-live-search

Adding Public Access to publish to NPM

* v14.3.1-alpha12

* v14.3.1-beta1

* PWA-14.3.1 release notes (#4530)

* PWA-14.3.1 release notes (#4531)

* Update magento-compatibility.js (#4532)

* v14.3.1

---------

Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com>
Co-authored-by: Ilesh Tiwari <del15881@adobe.com>

* PWA-3536: Removed package-lock.json (#4535)

* PWA-3463: Supressing noisy warnings on Select (#4505)

* PWA-4468: use the same version of `react-tabs` everywhere (#4469)

* Prevent Cart Creation for Guest User and Add Functionality To Create … (#4537)

* Prevent Cart Creation for Guest User and Add Functionality To Create Cart only when Guest User Adds Product to Cart

* Fixing Prettier and Snapshot test cases

* Removing unwanted and commented out code

* PWA-3576::Video component issue in dynamic CMS block (#4541)

* PWA-3576::Video component issue in dynamic CMS block

* PWA-3576::Video component issue in dynamic CMS block

* PWA-3537: Fixed out of saleable stock issue in PDP and cart edit pop up (#4540)

* PWA-3534:Fixed wishlist pagination issue (#4542)

* Remove useCustomerWishlistSkus hook from Carousel and Gallery components and add in useApp talon to avoid infinite loop (#4543)

Co-authored-by: Jose Amietta <joseamietta@gmail.com>

* PWA-3583: Fixed search page-clear filter customer issue (#4544)

* Fixing Wishlist Failing Test Cases originating from PR ID : 4543 (#4547)

* Enhancement/pwa 3550 (#4545)

* Prevent Cart Creation for Guest User and Add Functionality To Create Cart only when Guest User Adds Product to Cart

* Fixing Prettier and Snapshot test cases

* Removing unwanted and commented out code

* Handle Cart Creation and Merging for the Logged In users

* Adding Logic To create a Cart when Products added to cart from wishlist Page

* Fixing all the Failing Test cases related to Wishlist

* Fixing Failing Test Cases for ADD TO CART Dialog box

* Fixing Cart related test cases

* PWA-3538::nvalid auth middleware clearTimeout implementation (#4550)

* PWA-3542:Fixed upward path issue (#4549)

Co-authored-by: glo82145 <glo82145@adobe.com>

* PWA-3361:Multi store CSP fix (#4548)

Co-authored-by: glo82145 <glo82145@adobe.com>

* PWA-3610: Fixed targetables call (#4558)

* Fixing 404 Rendering Issue (#4556)

Co-authored-by: Bharathidasan Elangovan <del22123@adobe.com>

* v14.4.0-alpha2

* v14.4.0-alpha3

* Pwa 3610 v2 (#4559)

* PWA-3610: Fixed targetables call

* PWA-3610: Fixed targetables call

* v14.4.0-alpha5

* v14.4.0-alpha6

* Fixing the Issues with Targetables on Release blocker (#4561)

* Fixing the Issues with Targetables on Release blocker

* Fixing Prettier Issues

* v14.4.0-alpha10

* v14.4.0-alpha11

* PWA-3613: RI-Wishlist pagination fix (#4562)

* PWA-3613: RI-Wishlist pagination fix

* PWA-3613:Fixed lint and prettier issues

---------

Co-authored-by: Bharathidasan Elangovan <del22123@adobe.com>

* v14.4.0-alpha12

* v14.4.0-beta1

* Pwa 14.4.0 changelog (#4564)

* PWA-3610: Fixed targetables call

* PWA-14.4.0 - Change log

* PWA-14.4.0 - Change log

* PWA-14.4.0 - Change log

* PWA-14.4.0 - Change log

* Pwa 14.4.0 resolve conflicts (#4565)

* PWA-3610: Fixed targetables call

* PWA-14.4.0 - Change log

* Pwa 14.4.0 releaseconflicts v1 (#4566)

* PWA-3610: Fixed targetables call

* PWA-14.4.0 - Change log

* PWA-14.4.0 - Change log

* PWA-14.4.0 - Change log

* v14.4.0-beta2

* v14.4.0-beta3

---------

Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com>
Co-authored-by: Ilesh Tiwari <del15881@adobe.com>
Co-authored-by: Bharathidasan Elangovan <del22123@adobe.com>
Co-authored-by: Brendan Falkowski <brendan@gravitydept.com>
Co-authored-by: Jose Amietta <joseamietta@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants