File tree Expand file tree Collapse file tree 2 files changed +6
-13
lines changed
app/code/Magento/AsynchronousOperations
Controller/Adminhtml/Notification
Test/Unit/Controller/Adminhtml/Notification Expand file tree Collapse file tree 2 files changed +6
-13
lines changed Original file line number Diff line number Diff line change 88use Magento \AsynchronousOperations \Model \BulkNotificationManagement ;
99use Magento \Backend \App \Action \Context ;
1010use Magento \Backend \App \Action ;
11- use Magento \Framework \App \Action \HttpGetActionInterface ;
1211use Magento \Framework \Controller \ResultFactory ;
1312
1413/**
1514 * Class Bulk Notification Dismiss Controller
1615 */
17- class Dismiss extends Action implements HttpGetActionInterface
16+ class Dismiss extends Action
1817{
1918 /**
2019 * @var BulkNotificationManagement
@@ -44,7 +43,7 @@ protected function _isAllowed()
4443 }
4544
4645 /**
47- * @inheritdoc
46+ * { @inheritdoc}
4847 */
4948 public function execute ()
5049 {
@@ -56,7 +55,7 @@ public function execute()
5655 $ isAcknowledged = $ this ->notificationManagement ->acknowledgeBulks ($ bulkUuids );
5756
5857 /** @var \Magento\Framework\Controller\Result\Json $result */
59- $ result = $ this ->resultFactory ->create (ResultFactory::TYPE_RAW );
58+ $ result = $ this ->resultFactory ->create (ResultFactory::TYPE_JSON );
6059 if (!$ isAcknowledged ) {
6160 $ result ->setHttpResponseCode (400 );
6261 }
Original file line number Diff line number Diff line change 1111use Magento \AsynchronousOperations \Model \BulkNotificationManagement ;
1212use Magento \Framework \App \RequestInterface ;
1313use Magento \Framework \Controller \Result \Json ;
14- use Magento \Framework \Controller \Result \Raw ;
1514use Magento \Framework \Controller \ResultFactory ;
1615use Magento \Framework \TestFramework \Unit \Helper \ObjectManager ;
1716use PHPUnit \Framework \MockObject \MockObject ;
@@ -44,11 +43,6 @@ class DismissTest extends TestCase
4443 */
4544 private $ jsonResultMock ;
4645
47- /**
48- * @var MockObject
49- */
50- private $ rawResultMock ;
51-
5246 protected function setUp (): void
5347 {
5448 $ objectManager = new ObjectManager ($ this );
@@ -84,10 +78,10 @@ public function testExecute()
8478
8579 $ this ->resultFactoryMock ->expects ($ this ->once ())
8680 ->method ('create ' )
87- ->with (ResultFactory::TYPE_RAW , [])
88- ->willReturn ($ this ->rawResultMock );
81+ ->with (ResultFactory::TYPE_JSON , [])
82+ ->willReturn ($ this ->jsonResultMock );
8983
90- $ this ->assertEquals ($ this ->rawResultMock , $ this ->model ->execute ());
84+ $ this ->assertEquals ($ this ->jsonResultMock , $ this ->model ->execute ());
9185 }
9286
9387 public function testExecuteSetsBadRequestResponseStatusIfBulkWasNotAcknowledgedCorrectly ()
You can’t perform that action at this time.
0 commit comments