Fixes review comments

Author: engcom-Hotel

app/code/Magento/Captcha/Block/Checkout/LayoutProcessor.php renamed to app/code/Magento/Captcha/Block/Customer/AuthenticationPopup/LayoutProcessor.php

@@ -5,10 +5,10 @@
  */
 
 declare(strict_types=1);
-namespace Magento\Captcha\Block\Checkout;
+namespace Magento\Captcha\Block\Customer\AuthenticationPopup;
 
-use Magento\Checkout\Block\Checkout\LayoutProcessorInterface;
 use Magento\Captcha\Helper\Data as HelperCaptcha;
+use Magento\Checkout\Block\Checkout\LayoutProcessorInterface;
 
 class LayoutProcessor implements LayoutProcessorInterface
 {

app/code/Magento/Captcha/etc/frontend/di.xml

@@ -40,14 +40,14 @@
     <type name="Magento\Checkout\Block\Onepage">
         <arguments>
             <argument name="layoutProcessors" xsi:type="array">
-                <item name="checkout_processor" xsi:type="object">Magento\Captcha\Block\CheckoutLayoutProcessor</item>
+                <item name="captcha_processor" xsi:type="object">Magento\Captcha\Block\CheckoutLayoutProcessor</item>
             </argument>
         </arguments>
     </type>
     <type name="Magento\Customer\Block\Account\AuthenticationPopup">
         <arguments>
             <argument name="layoutProcessors" xsi:type="array">
-                <item name="captcha_processor" xsi:type="object">Magento\Captcha\Block\Checkout\LayoutProcessor</item>
+                <item name="authentication_popup_processor" xsi:type="object">Magento\Captcha\Block\Customer\AuthenticationPopup\LayoutProcessor</item>
             </argument>
         </arguments>
     </type>

app/code/Magento/Captcha/view/frontend/layout/checkout_index_index.xml

@@ -41,22 +41,19 @@ class AuthenticationPopup extends \Magento\Framework\View\Element\Template
      * @param \Magento\Framework\View\Element\Template\Context $context
      * @param array $data
      * @param \Magento\Framework\Serialize\Serializer\Json|null $serializer
-     * @param HttpContext $httpContext
      * @param array $layoutProcessors
      * @throws \RuntimeException
      */
     public function __construct(
         \Magento\Framework\View\Element\Template\Context $context,
         array $data = [],
         ?\Magento\Framework\Serialize\Serializer\Json $serializer = null,
-        ?HttpContext $httpContext = null,
         array $layoutProcessors = []
     ) {
         parent::__construct($context, $data);
         $this->jsLayout = isset($data['jsLayout']) && is_array($data['jsLayout']) ? $data['jsLayout'] : [];
         $this->serializer = $serializer ?: \Magento\Framework\App\ObjectManager::getInstance()
             ->get(\Magento\Framework\Serialize\Serializer\Json::class);
-        $this->httpContext = $httpContext ?: ObjectManager::getInstance()->get(HttpContext::class);
         $this->layoutProcessors = $layoutProcessors;
     }
 

app/code/Magento/Captcha/view/frontend/layout/default.xml

@@ -15,7 +15,7 @@ class Form extends \Magento\Eav\Model\Form
      * XML configuration paths for "Disable autocomplete on storefront" property
      */
     public const XML_PATH_ENABLE_AUTOCOMPLETE = 'customer/password/autocomplete_on_storefront';
-    
+
     /**
      * Current module pathname
      *