MC-37083: Create automated test for "[Timezone] Sales Exported Dates"

Author: mykhailomatiola

dev/tests/integration/testsuite/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/ExportTest.php

@@ -53,12 +53,7 @@ public function testExportCreditmemo(
             $url,
             ['namespace' => $namespace, 'filters' => ['order_increment_id' => '200000001']]
         );
-        $creditmemos = [];
-        if ($format === ExportBase::CSV_FORMAT) {
-            $creditmemos = $this->parseCsvResponse($response);
-        } elseif ($format === ExportBase::XML_FORMAT) {
-            $creditmemos = $this->parseXmlResponse($response);
-        }
+        $creditmemos = $this->parseResponse($format, $response);
         $creditmemo = $this->getCreditmemo('200000001');
         $exportedCreditmemo = reset($creditmemos);
         $this->assertNotFalse($exportedCreditmemo);

dev/tests/integration/testsuite/Magento/Sales/Controller/Adminhtml/Order/ExportBase.php

@@ -54,6 +54,25 @@ protected function dispatchExport(string $url, array $params): string
         return ob_get_clean();
     }
 
+    /**
+     * Parses string response depends of format.
+     *
+     * @param string $format
+     * @param string $response
+     * @return array
+     */
+    protected function parseResponse(string $format, string $response): array
+    {
+        $result = [];
+        if ($format === ExportBase::CSV_FORMAT) {
+            $result = $this->parseCsvResponse($response);
+        } elseif ($format === ExportBase::XML_FORMAT) {
+            $result = $this->parseXmlResponse($response);
+        }
+
+        return $result;
+    }
+
     /**
      * Converts string in scv format to assoc array.
      *

dev/tests/integration/testsuite/Magento/Sales/Controller/Adminhtml/Order/ExportTest.php

@@ -20,23 +20,17 @@ class ExportTest extends ExportBase
      * @magentoDataFixture Magento/Sales/_files/order_with_invoice_shipment_creditmemo_on_second_website.php
      * @dataProvider exportOrderDataProvider
      * @param string $format
-     * @param string $namespace
      * @return void
      */
-    public function testExportOrder(string $format, string $namespace): void
+    public function testExportOrder(string $format): void
     {
         $order = $this->getOrder('200000001');
         $url = $this->getExportUrl($format, null);
         $response = $this->dispatchExport(
             $url,
-            ['namespace' => $namespace, 'filters' => ['increment_id' => '200000001']]
+            ['namespace' => 'sales_order_grid', 'filters' => ['increment_id' => '200000001']]
         );
-        $orders = [];
-        if ($format === ExportBase::CSV_FORMAT) {
-            $orders = $this->parseCsvResponse($response);
-        } elseif ($format === ExportBase::XML_FORMAT) {
-            $orders = $this->parseXmlResponse($response);
-        }
+        $orders = $this->parseResponse($format, $response);
         $exportedOrder = reset($orders);
         $this->assertNotFalse($exportedOrder);
         $this->assertEquals(
@@ -51,14 +45,8 @@ public function testExportOrder(string $format, string $namespace): void
     public function exportOrderDataProvider(): array
     {
         return [
-            'order_grid_in_csv' => [
-                'format' => ExportBase::CSV_FORMAT,
-                'namespace' => 'sales_order_grid',
-            ],
-            'order_grid_in_xml' => [
-                'format' => ExportBase::XML_FORMAT,
-                'namespace' => 'sales_order_grid',
-            ],
+            'order_grid_in_csv' => ['format' => ExportBase::CSV_FORMAT],
+            'order_grid_in_xml' => ['format' => ExportBase::XML_FORMAT],
         ];
     }
 }

dev/tests/integration/testsuite/Magento/Sales/Controller/Adminhtml/Order/Invoice/ExportTest.php

@@ -53,12 +53,7 @@ public function testExportInvoice(
             $url,
             ['namespace' => $namespace, 'filters' => ['order_increment_id' => '200000001']]
         );
-        $invoices = [];
-        if ($format === ExportBase::CSV_FORMAT) {
-            $invoices = $this->parseCsvResponse($response);
-        } elseif ($format === ExportBase::XML_FORMAT) {
-            $invoices = $this->parseXmlResponse($response);
-        }
+        $invoices = $this->parseResponse($format, $response);
         $invoice = $this->getInvoice('200000001');
         $exportedInvoice = reset($invoices);
         $this->assertNotFalse($exportedInvoice);

dev/tests/integration/testsuite/Magento/Sales/Controller/Adminhtml/Order/Shipment/ExportTest.php

@@ -53,12 +53,7 @@ public function testExportShipment(
             $url,
             ['namespace' => $namespace, 'filters' => ['order_increment_id' => '200000001']]
         );
-        $shipments = [];
-        if ($format === ExportBase::CSV_FORMAT) {
-            $shipments = $this->parseCsvResponse($response);
-        } elseif ($format === ExportBase::XML_FORMAT) {
-            $shipments = $this->parseXmlResponse($response);
-        }
+        $shipments = $this->parseResponse($format, $response);
         $shipment = $this->getShipment('200000001');
         $exportedShipment = reset($shipments);
         $this->assertNotFalse($exportedShipment);

dev/tests/integration/testsuite/Magento/Sales/_files/order_with_invoice_shipment_creditmemo_on_second_website.php

@@ -10,16 +10,17 @@
 use Magento\Sales\Api\CreditmemoItemRepositoryInterface;
 use Magento\Sales\Api\CreditmemoRepositoryInterface;
 use Magento\Sales\Api\Data\CreditmemoItemInterfaceFactory;
+use Magento\Sales\Api\Data\OrderInterface;
 use Magento\Sales\Api\Data\OrderInterfaceFactory;
+use Magento\Sales\Api\Data\OrderItemInterface;
+use Magento\Sales\Api\Data\OrderPaymentInterface;
 use Magento\Sales\Api\InvoiceManagementInterface;
 use Magento\Sales\Api\Data\OrderItemInterfaceFactory;
 use Magento\Sales\Api\OrderRepositoryInterface;
 use Magento\Sales\Model\Order;
 use Magento\Sales\Model\Order\Address as OrderAddress;
-use Magento\Sales\Model\Order\Creditmemo\Item;
+use Magento\Sales\Model\Order\Creditmemo;
 use Magento\Sales\Model\Order\CreditmemoFactory;
-use Magento\Sales\Model\Order\Item as OrderItem;
-use Magento\Sales\Model\Order\Payment;
 use Magento\Sales\Model\Order\ShipmentFactory;
 use Magento\Store\Model\StoreManagerInterface;
 use Magento\TestFramework\Helper\Bootstrap;
@@ -54,12 +55,12 @@
 $billingAddress->setAddressType(OrderAddress::TYPE_BILLING);
 $shippingAddress = clone $billingAddress;
 $shippingAddress->setId(null)->setAddressType(OrderAddress::TYPE_SHIPPING);
-/** @var Payment $payment */
-$payment = $objectManager->create(Payment::class);
+/** @var OrderPaymentInterface $payment */
+$payment = $objectManager->create(OrderPaymentInterface::class);
 $payment->setMethod('checkmo')
     ->setAdditionalInformation('last_trans_id', '11122')
     ->setAdditionalInformation('metadata', ['type' => 'free', 'fraudulent' => false]);
-/** @var OrderItem $orderItem */
+/** @var OrderItemInterface $orderItem */
 $orderItem = $objectManager->get(OrderItemInterfaceFactory::class)->create();
 $orderItem->setProductId($product->getId())
     ->setQtyOrdered(2)
@@ -70,7 +71,7 @@
     ->setName($product->getName())
     ->setSku($product->getSku())
     ->setName('Test item');
-/** @var Order $order */
+/** @var  OrderInterface $order */
 $order = $objectManager->get(OrderInterfaceFactory::class)->create();
 $order->setIncrementId('200000001')
     ->setState(Order::STATE_PROCESSING)
@@ -112,15 +113,14 @@
 $creditmemoFactory = $objectManager->get(CreditmemoFactory::class);
 $creditmemo = $creditmemoFactory->createByOrder($order, $order->getData());
 $creditmemo->setOrder($order);
-$creditmemo->setState(Magento\Sales\Model\Order\Creditmemo::STATE_OPEN);
+$creditmemo->setState(Creditmemo::STATE_OPEN);
 $creditmemo->setIncrementId($order->getIncrementId());
 $creditmemoRepository->save($creditmemo);
 $orderItem->setName('Test item')
     ->setQtyRefunded(2)
     ->setQtyInvoiced(2)
     ->setOriginalPrice($product->getPrice());
-/** @var Item $creditItem */
-$creditItem = $objectManager->get(Item::class);
+$creditItem = $creditmemoItemFactory->create();
 $creditItem->setCreditmemo($creditmemo)
     ->setName('Creditmemo item')
     ->setOrderItemId($orderItem->getId())