MC-17592: End-to-end integration to test order with Payflow Link

Author: danielrenaud

dev/tests/integration/testsuite/Magento/PaypalGraphQl/Model/Resolver/Customer/PlaceOrderWithPayflowLinkTest.php

@@ -86,6 +86,14 @@ protected function setUp()
         $this->objectManager->addSharedInstance($this->gateway, Gateway::class);
     }
 
+    /**
+     * @inheritdoc
+     */
+    protected function tearDown()
+    {
+        $this->objectManager->removeSharedInstance(Gateway::class);
+    }
+
     /**
      * Test place order with payflow link
      *
@@ -154,8 +162,7 @@ public function testResolvePlaceOrderWithPayflowLinkForCustomer(): void
             ->method('postRequest')
             ->willReturn($payflowLinkResponse);
 
-        $this->payflowRequest->expects($this->any())
-            ->method('setData')
+        $this->payflowRequest->method('setData')
             ->willReturnMap(
                 [
                     [
@@ -198,12 +205,4 @@ public function testResolvePlaceOrderWithPayflowLinkForCustomer(): void
             $responseData['data']['placeOrder']['order']['order_id']
         );
     }
-
-    /**
-     * @inheritdoc
-     */
-    protected function tearDown()
-    {
-        $this->objectManager->removeSharedInstance(Gateway::class);
-    }
 }

dev/tests/integration/testsuite/Magento/PaypalGraphQl/Model/Resolver/Guest/PlaceOrderWithPayflowLinkTest.php

@@ -69,23 +69,28 @@ protected function setUp()
             ->disableOriginalConstructor()
             ->setMethods(['__call','setData'])
             ->getMock();
-        $this->payflowRequest->expects($this->any())
-            ->method('__call')
-            ->will(
-                $this->returnCallback(
-                    function ($method) {
-                        if (strpos($method, 'set') === 0) {
-                            return $this->payflowRequest;
-                        }
-                        return null;
+        $this->payflowRequest->method('__call')
+            ->willReturnCallback(
+                function ($method) {
+                    if (strpos($method, 'set') === 0) {
+                        return $this->payflowRequest;
                     }
-                )
+                    return null;
+                }
             );
 
-        $requestFactory->expects($this->any())->method('create')->will($this->returnValue($this->payflowRequest));
+        $requestFactory->expects($this->any())->method('create')->willReturn($this->payflowRequest);
         $this->objectManager->addSharedInstance($this->gateway, Gateway::class);
     }
 
+    /**
+     * @inheritdoc
+     */
+    protected function tearDown()
+    {
+        $this->objectManager->removeSharedInstance(Gateway::class);
+    }
+
     /**
      * Test successful place Order with Payflow link
      *
@@ -260,7 +265,8 @@ public function testResolveWithPayflowLinkDeclined(): void
 
                     ]
                 ]
-            )->willReturnSelf();
+            )
+            ->willReturnSelf();
 
         $this->gateway->method('postRequest')->willThrowException($exception);
 
@@ -274,12 +280,4 @@ public function testResolveWithPayflowLinkDeclined(): void
         );
         $this->assertEquals(GraphQlInputException::EXCEPTION_CATEGORY, $actualError['category']);
     }
-
-    /**
-     * @inheritdoc
-     */
-    protected function tearDown()
-    {
-        $this->objectManager->removeSharedInstance(Gateway::class);
-    }
 }