#29196: Avoids endless loop of indexers being marked as invalid.

Author: engcom-Foxtrot

app/code/Magento/Indexer/Console/Command/IndexerReindexCommand.php

@@ -64,7 +64,7 @@ public function __construct(
     ) {
         $this->indexerRegistry = $indexerRegistry;
         $this->dependencyInfoProvider = $dependencyInfoProvider;
-        $this->makeSharedValid = $makeSharedValid ?: ObjectManager::getInstance()->get(MakeSharedIndexValid::class);
+        $this->makeSharedValid = $makeSharedValid;
         parent::__construct($objectManagerFactory);
     }
 
@@ -99,7 +99,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
                 // Skip indexers having shared index that was already complete
                 if (!in_array($sharedIndex, $this->sharedIndexesComplete)) {
                     $indexer->reindexAll();
-                    if (!empty($sharedIndex) && $this->makeSharedValid->execute($sharedIndex)) {
+                    if (!empty($sharedIndex) && $this->getMakeSharedValid()->execute($sharedIndex)) {
                         $this->sharedIndexesComplete[] = $sharedIndex;
                     }
                 }
@@ -253,4 +253,18 @@ private function getDependencyInfoProvider()
         }
         return $this->dependencyInfoProvider;
     }
+
+    /**
+     * Get MakeSharedIndexValid processor.
+     *
+     * @return MakeSharedIndexValid
+     */
+    private function getMakeSharedValid(): MakeSharedIndexValid
+    {
+        if (!$this->makeSharedValid) {
+            $this->makeSharedValid = $this->getObjectManager()->get(MakeSharedIndexValid::class);
+        }
+
+        return $this->makeSharedValid;
+    }
 }