🔃 [GraphQL] Partners Acceleration Program Contributions - 2.4-develop

Accepted Community Pull Requests:
 - #30623: [GraphQL] Fixed exposing special price (by @rogyar)


Fixed GitHub Issues:
 - #29631: [2.3.5-p2] GraphQl Special Price Ignore's special price from to dates. (reported by @Hexmage) has been fixed in #30623 by @rogyar in 2.4-develop branch
   Related commits:
     1. bafb07d
     2. 0153d51
     3. 5b95b8b
     4. 2aca82d
     5. dbb47b3

 - #30210: Magento 2.4.0 graphql leak data on special price (reported by @thomasb0123) has been fixed in #30623 by @rogyar in 2.4-develop branch
   Related commits:
     1. bafb07d
     2. 0153d51
     3. 5b95b8b
     4. 2aca82d
     5. dbb47b3

Author: gabrieldagama

app/code/Magento/CatalogGraphQl/Model/Resolver/Product/SpecialPrice.php

@@ -7,6 +7,7 @@
 
 namespace Magento\CatalogGraphQl\Model\Resolver\Product;
 
+use Magento\Framework\Exception\LocalizedException;
 use Magento\Framework\GraphQl\Config\Element\Field;
 use Magento\Framework\GraphQl\Query\ResolverInterface;
 use Magento\Framework\GraphQl\Schema\Type\ResolveInfo;
@@ -23,8 +24,13 @@ class SpecialPrice implements ResolverInterface
      */
     public function resolve(Field $field, $context, ResolveInfo $info, array $value = null, array $args = null)
     {
+        if (!isset($value['model'])) {
+            throw new LocalizedException(__('"model" value should be specified'));
+        }
+
         /** @var ProductInterface $product */
         $product = $value['model'];
+
         /** @var PricingSpecialPrice $specialPrice */
         $specialPrice = $product->getPriceInfo()->getPrice(PricingSpecialPrice::PRICE_CODE);
 

app/code/Magento/CatalogGraphQl/Model/Resolver/Products/DataProvider/Product/CollectionProcessor/RequiredColumnsProcessor.php

@@ -36,8 +36,8 @@ public function process(
         ContextInterface $context = null
     ): Collection {
         $collection->addAttributeToSelect('special_price');
-        $collection->addAttributeToSelect('special_price_from');
-        $collection->addAttributeToSelect('special_price_to');
+        $collection->addAttributeToSelect('special_from_date');
+        $collection->addAttributeToSelect('special_to_date');
         $collection->addAttributeToSelect('tax_class_id');
 
         return $collection;

dev/tests/api-functional/testsuite/Magento/GraphQl/Catalog/ProductPriceTest.php

@@ -945,6 +945,72 @@ public function testProductWithCatalogDiscount()
         }
     }
 
+    /**
+     * Check if the special price visible if the current date is in the date range set
+     * for the special price
+     *
+     * @magentoApiDataFixture Magento/GraphQl/Catalog/_files/simple_product.php
+     * @magentoApiDataFixture Magento/GraphQl/Catalog/_files/set_simple_product_special_price.php
+     */
+    public function testSpecialPriceVisibleIfInDateRange()
+    {
+        $query = <<<QUERY
+{
+    products(filter: {sku: {eq: "simple_product"}}) {
+        items {
+            price_range {
+                minimum_price {
+                    regular_price {
+                        value
+                    }
+                }
+            }
+            special_price
+        }
+    }
+}
+QUERY;
+        $result = $this->graphQlQuery($query);
+        $productInformation = $result['products']['items'][0];
+        $productRegularPrice = $productInformation['price_range']['minimum_price']['regular_price']['value'];
+
+        self::assertEquals('10', $productRegularPrice);
+        self::assertEquals('5.99', $productInformation['special_price']);
+    }
+
+    /**
+     * Check if the special price is not visible if the current date is not in the date range set
+     * for the special price
+     *
+     * @magentoApiDataFixture Magento/GraphQl/Catalog/_files/simple_product.php
+     * @magentoApiDataFixture Magento/GraphQl/Catalog/_files/set_simple_product_special_price_future_date.php
+     */
+    public function testSpecialPriceNotVisibleIfNotInDateRange()
+    {
+        $query = <<<QUERY
+{
+    products(filter: {sku: {eq: "simple_product"}}) {
+        items {
+            price_range {
+                minimum_price {
+                    regular_price {
+                        value
+                    }
+                }
+            }
+            special_price
+        }
+    }
+}
+QUERY;
+        $result = $this->graphQlQuery($query);
+        $productInformation = $result['products']['items'][0];
+        $productRegularPrice = $productInformation['price_range']['minimum_price']['regular_price']['value'];
+
+        self::assertEquals('10', $productRegularPrice);
+        self::assertEquals(null, $productInformation['special_price']);
+    }
+
     /**
      * Get GraphQl query to fetch products by sku
      *

dev/tests/integration/testsuite/Magento/GraphQl/Catalog/_files/set_simple_product_special_price.php

@@ -0,0 +1,21 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+use Magento\Catalog\Api\ProductRepositoryInterface;
+use Magento\TestFramework\Helper\Bootstrap;
+
+$objectManager = Bootstrap::getObjectManager();
+/** @var ProductRepositoryInterface $productRepository */
+$productRepository = $objectManager->get(ProductRepositoryInterface::class);
+
+$product = $productRepository->get('simple_product');
+$product->setSpecialPrice('5.99');
+
+$product->setSpecialFromDate(date('Y-m-d', strtotime('-1 day')));
+$product->setSpecialToDate(date('Y-m-d', strtotime('+1 day')));
+
+$productRepository->save($product);

dev/tests/integration/testsuite/Magento/GraphQl/Catalog/_files/set_simple_product_special_price_future_date.php

@@ -0,0 +1,21 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+use Magento\Catalog\Api\ProductRepositoryInterface;
+use Magento\TestFramework\Helper\Bootstrap;
+
+$objectManager = Bootstrap::getObjectManager();
+/** @var ProductRepositoryInterface $productRepository */
+$productRepository = $objectManager->get(ProductRepositoryInterface::class);
+
+$product = $productRepository->get('simple_product');
+$product->setSpecialPrice('5.99');
+
+$product->setSpecialFromDate(date('Y-m-d', strtotime('+3 day')));
+$product->setSpecialToDate(date('Y-m-d', strtotime('+5 day')));
+
+$productRepository->save($product);