Fixed failed in the Unit Test

Author: anzin

app/code/Magento/Customer/Model/Metadata/Form/Text.php

@@ -124,7 +124,7 @@ private function validateLength($value, AttributeMetadataInterface $attribute, a
         // validate length
         $label = __($attribute->getStoreLabel());
 
-        $length = is_string($value) ? $this->_string->strlen(trim($value)) : 0;
+        $length = $value ? $this->_string->strlen(trim($value)) : 0;
 
         $validateRules = $attribute->getValidationRules();
 

lib/internal/Magento/Framework/App/Test/Unit/MaintenanceModeTest.php

@@ -37,16 +37,7 @@ class MaintenanceModeTest extends TestCase
      */
     protected function setup(): void
     {
-        $this->flagDir = $this->getMockForAbstractClass(
-            WriteInterface::class,
-            [],
-            '',
-            false,
-            true,
-            true,
-            ['readFile']
-        );
-        $this->flagDir->method('readFile')->willReturn('');
+        $this->flagDir = $this->getMockForAbstractClass(WriteInterface::class);
         $filesystem = $this->createMock(Filesystem::class);
         $filesystem->method('getDirectoryWrite')
             ->willReturn($this->flagDir);
@@ -104,6 +95,10 @@ public function testisOnWithIP()
         $this->flagDir->expects($this->exactly(2))
             ->method('isExist')
             ->willReturnMap($mapisExist);
+        $this->flagDir->expects($this->once())
+            ->method('readFile')
+            ->with(MaintenanceMode::IP_FILENAME)
+            ->willReturn('');
         $this->assertFalse($this->model->isOn());
     }
 

lib/internal/Magento/Framework/View/Test/Unit/Element/Html/Link/CurrentTest.php

@@ -79,10 +79,9 @@ public function testGetUrl(): void
     public function testIsCurrentIfIsset(): void
     {
         $pathStub = '';
-        $this->_urlBuilderMock
-            ->method('getUrl')
+        $this->_urlBuilderMock->method('getUrl')
             ->with($pathStub)
-            ->will($this->returnValue('http://example.com/'));
+            ->willReturn('http://example.com/');
         $this->currentLink->setPath($pathStub);
         $this->currentLink->setCurrent(true);
         $this->assertTrue($this->currentLink->isCurrent());
@@ -120,10 +119,12 @@ public function testIsCurrent($pathStub, $urlStub, $request, $expected): void
         $willReturnArgs[] = $this->returnValue($urlStub);
         $withArgs[] = [$request['mcaStub']];
         $willReturnArgs[] = $this->returnValue($request['getUrl']);
+        $withArgs[] = ['*/*/*', ['_current' => false, '_use_rewrite' => true]];
 
         if ($request['mcaStub'] == '') {
-            $withArgs[] = ['*/*/*', ['_current' => false, '_use_rewrite' => true]];
             $willReturnArgs[] = $this->returnValue($urlStub);
+        } else {
+            $willReturnArgs[] = $this->returnValue('');
         }
         $this->_urlBuilderMock
             ->method('getUrl')