Merge pull request #7067 from magento-trigger/AC-390

[Trigger]AC-390: Fix removeProp() usage

Author: xmav

app/code/Magento/Ui/view/base/web/js/form/element/wysiwyg.js

@@ -137,7 +137,7 @@ define([
             if (this.$wysiwygEditorButton && disabled) {
                 this.$wysiwygEditorButton.prop('disabled', 'disabled');
             } else if (this.$wysiwygEditorButton) {
-                this.$wysiwygEditorButton.removeProp('disabled');
+                this.$wysiwygEditorButton.prop('disabled', false);
             }
 
             /* eslint-disable no-undef */

dev/tests/static/testsuite/Magento/Test/Js/_files/eslint/.eslintrc

@@ -3,6 +3,6 @@
     	"./.eslintrc-reset",
     	"./.eslintrc-magento",
     	"./.eslintrc-jquery",
-    	"./.eslintrc-tinymce"
+    	"./.eslintrc-misc"
     ]
 }

dev/tests/static/testsuite/Magento/Test/Js/_files/eslint/.eslintrc-tinymce renamed to dev/tests/static/testsuite/Magento/Test/Js/_files/eslint/.eslintrc-misc

@@ -78,6 +78,10 @@
                 message: "'mobile' theme is removed. Update code to be compatible with tinymce5",
                 selector: "ObjectExpression > Property[key.name='theme'][value.value='mobile']"
             },
+            {
+                message: "This method should not be used to remove built-in (native) properties",
+                selector: "CallExpression[callee.property.name='removeProp'] > :matches([arguments] Literal[value='disabled'], Literal[value='checked'], Literal[value='selected'], Literal[value='required'], Literal[value='value'], Literal[value='readOnly'])"
+            }
         ]
     }
 }

lib/web/mage/adminhtml/wysiwyg/tiny_mce/tinymce5Adapter.js

@@ -644,7 +644,7 @@ define([
             }
 
             if (enabled) {
-                this.getTextArea().removeProp('disabled');
+                this.getTextArea().prop('disabled', false);
             } else {
                 this.getTextArea().prop('disabled', 'disabled');
             }