MC-42506: [CLOUD] duplicated product does not retain some store view specific data

- fixed
- removed redundant unit test
- added integration test

Author: o-dubovyk

app/code/Magento/Catalog/Model/Product/Copier.php

@@ -6,12 +6,13 @@
 namespace Magento\Catalog\Model\Product;
 
 use Magento\Catalog\Api\Data\ProductInterface;
+use Magento\Catalog\Api\ProductRepositoryInterface;
 use Magento\Catalog\Model\Attribute\ScopeOverriddenValue;
 use Magento\Catalog\Model\Product;
 use Magento\Catalog\Model\Product\Attribute\Source\Status;
 use Magento\Catalog\Model\Product\Option\Repository as OptionRepository;
 use Magento\Catalog\Model\ProductFactory;
-use Magento\Framework\App\ObjectManager;
+use Magento\Catalog\Model\ResourceModel\DuplicatedProductAttributesCopier;
 use Magento\Framework\EntityManager\MetadataPool;
 use Magento\Store\Model\Store;
 use Magento\UrlRewrite\Model\Exception\UrlAlreadyExistsException;
@@ -50,25 +51,41 @@ class Copier
      */
     private $scopeOverriddenValue;
 
+    /**
+     * @var ProductRepositoryInterface
+     */
+    private $productRepository;
+
+    /**
+     * @var DuplicatedProductAttributesCopier
+     */
+    private $attributeCopier;
+
     /**
      * @param CopyConstructorInterface $copyConstructor
      * @param ProductFactory $productFactory
      * @param ScopeOverriddenValue $scopeOverriddenValue
      * @param OptionRepository|null $optionRepository
      * @param MetadataPool|null $metadataPool
+     * @param ProductRepositoryInterface $productRepository
+     * @param DuplicatedProductAttributesCopier $attributeCopier
      */
     public function __construct(
         CopyConstructorInterface $copyConstructor,
         ProductFactory $productFactory,
         ScopeOverriddenValue $scopeOverriddenValue,
         OptionRepository $optionRepository,
-        MetadataPool $metadataPool
+        MetadataPool $metadataPool,
+        ProductRepositoryInterface $productRepository,
+        DuplicatedProductAttributesCopier $attributeCopier
     ) {
         $this->productFactory = $productFactory;
         $this->copyConstructor = $copyConstructor;
         $this->scopeOverriddenValue = $scopeOverriddenValue;
         $this->optionRepository = $optionRepository;
         $this->metadataPool = $metadataPool;
+        $this->productRepository = $productRepository;
+        $this->attributeCopier = $attributeCopier;
     }
 
     /**
@@ -79,11 +96,13 @@ public function __construct(
      */
     public function copy(Product $product): Product
     {
-        $product->getWebsiteIds();
-        $product->getCategoryIds();
-
         $metadata = $this->metadataPool->getMetadata(ProductInterface::class);
 
+        /*  Regardless in what scope the product was provided,
+            for duplicating we want to clone product in Global scope first */
+        if ((int)$product->getStoreId() !== Store::DEFAULT_STORE_ID) {
+            $product = $this->productRepository->getById($product->getId(), true, Store::DEFAULT_STORE_ID);
+        }
         /** @var Product $duplicate */
         $duplicate = $this->productFactory->create();
         $productData = $product->getData();
@@ -102,6 +121,7 @@ public function copy(Product $product): Product
         $duplicate->setStoreId(Store::DEFAULT_STORE_ID);
         $this->copyConstructor->build($product, $duplicate);
         $this->setDefaultUrl($product, $duplicate);
+        $this->attributeCopier->copyProductAttributes($product, $duplicate);
         $this->setStoresUrl($product, $duplicate);
         $this->optionRepository->duplicate($product, $duplicate);
 

app/code/Magento/Catalog/Model/ResourceModel/DuplicatedProductAttributesCopier.php

@@ -0,0 +1,101 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace Magento\Catalog\Model\ResourceModel;
+
+/**
+ * DuplicatedProductAttributesCopier
+ *
+ * Is used to copy product attributes related to non-global scope
+ * from source to target product during product duplication
+ */
+
+use Magento\Catalog\Api\Data\ProductInterface;
+use Magento\Catalog\Model\Product;
+use Magento\Catalog\Model\ResourceModel\Product\Attribute\CollectionFactory;
+use Magento\Framework\App\ResourceConnection;
+use Magento\Framework\EntityManager\MetadataPool;
+use Magento\Store\Model\Store;
+
+/**
+ *
+ */
+class DuplicatedProductAttributesCopier
+{
+    /**
+     * @var MetadataPool
+     */
+    private $metadataPool;
+
+    /**
+     * @var CollectionFactory
+     */
+    private $collectionFactory;
+
+    /**
+     * @var ResourceConnection
+     */
+    private $resource;
+
+    /**
+     * @param MetadataPool $metadataPool
+     * @param CollectionFactory $collectionFactory
+     * @param ResourceConnection $resource
+     */
+    public function __construct(
+        MetadataPool $metadataPool,
+        CollectionFactory $collectionFactory,
+        ResourceConnection $resource
+    ) {
+        $this->metadataPool = $metadataPool;
+        $this->collectionFactory = $collectionFactory;
+        $this->resource = $resource;
+    }
+
+    /**
+     * Copy non-global Product Attributes form source to target
+     *
+     * @param $source Product
+     * @param $target Product
+     * @return void
+     */
+    public function copyProductAttributes(Product $source, Product $target): void
+    {
+        $metadata = $this->metadataPool->getMetadata(ProductInterface::class);
+        $linkField = $metadata->getLinkField();
+        $attributeCollection = $this->collectionFactory->create()
+            ->setAttributeSetFilter($source->getAttributeSetId())
+            ->addFieldToFilter('backend_type', ['neq' => 'static'])
+            ->addFieldToFilter('is_global', 0);
+
+        $eavTableNames = [];
+        foreach ($attributeCollection->getItems() as $item) {
+            /** @var \Magento\Catalog\Model\ResourceModel\Eav\Attribute $item */
+            $eavTableNames[] = $item->getBackendTable();
+        }
+
+        $connection = $this->resource->getConnection();
+        foreach (array_unique($eavTableNames) as $eavTable) {
+            $select = $connection->select()
+                ->from(
+                    ['main_table' => $this->resource->getTableName($eavTable)],
+                    ['attribute_id', 'store_id', 'value']
+                )->where($linkField . ' = ?', $source->getData($linkField))
+                ->where('store_id <> ?', Store::DEFAULT_STORE_ID);
+            $records = $connection->fetchAll($select);
+
+            if (!count($records)) {
+                continue;
+            }
+
+            foreach ($records as $index => $bind) {
+                $bind[$linkField] = $target->getData($linkField);
+                $records[$index] = $bind;
+            }
+
+            $connection->insertMultiple($this->resource->getTableName($eavTable), $records);
+        }
+    }
+}