AC-2457: Checkout Improvements

Author: nvshivakumar

app/code/Magento/Checkout/Controller/Sidebar/UpdateItemQty.php

@@ -7,15 +7,17 @@
 
 use Magento\Checkout\Model\Cart\RequestQuantityProcessor;
 use Magento\Checkout\Model\Sidebar;
-use Magento\Framework\App\Action\Action;
-use Magento\Framework\App\Action\Context;
+use Magento\Framework\App\Action\HttpPostActionInterface;
 use Magento\Framework\App\ObjectManager;
+use Magento\Framework\App\RequestInterface;
 use Magento\Framework\App\Response\Http;
+use Magento\Framework\App\ResponseInterface;
+use Magento\Framework\Exception\InputException;
 use Magento\Framework\Exception\LocalizedException;
 use Magento\Framework\Json\Helper\Data;
 use Psr\Log\LoggerInterface;
 
-class UpdateItemQty extends Action
+class UpdateItemQty implements HttpPostActionInterface
 {
     /**
      * @var Sidebar
@@ -38,38 +40,57 @@ class UpdateItemQty extends Action
     private $quantityProcessor;
 
     /**
-     * @param Context $context
+     * @var RequestInterface
+     */
+    private $request;
+
+    /**
+     * @var ResponseInterface
+     */
+    private $response;
+
+    /**
      * @param Sidebar $sidebar
      * @param LoggerInterface $logger
      * @param Data $jsonHelper
+     * @param RequestInterface $request
+     * @param ResponseInterface $response
      * @param RequestQuantityProcessor|null $quantityProcessor
      * @codeCoverageIgnore
      */
     public function __construct(
-        Context $context,
         Sidebar $sidebar,
         LoggerInterface $logger,
         Data $jsonHelper,
+        RequestInterface  $request,
+        ResponseInterface $response,
         ?RequestQuantityProcessor $quantityProcessor = null
     ) {
         $this->sidebar = $sidebar;
         $this->logger = $logger;
         $this->jsonHelper = $jsonHelper;
-        parent::__construct($context);
+        $this->request = $request;
+        $this->response = $response;
         $this->quantityProcessor = $quantityProcessor
             ?? ObjectManager::getInstance()->get(RequestQuantityProcessor::class);
     }
 
     /**
+     * Action for Quantity update
+     *
      * @return $this
      */
     public function execute()
     {
-        $itemId = (int)$this->getRequest()->getParam('item_id');
-        $itemQty = $this->getRequest()->getParam('item_qty') * 1;
-        $itemQty = $this->quantityProcessor->prepareQuantity($itemQty);
+        $itemId = (int)$this->request->getParam('item_id');
+        $itemQty = $this->request->getParam('item_qty');
 
+        if (!is_numeric($itemQty) || ($itemQty <=0)) {
+            $e = new InputException(__('A non-numeric value found')) ;
+            return  $this->jsonResponse($e->getMessage());
+        }
         try {
+            $itemQty = $this->quantityProcessor->prepareQuantity($itemQty*1);
             $this->sidebar->checkQuoteItem($itemId);
             $this->sidebar->updateQuoteItem($itemId, $itemQty);
             return $this->jsonResponse();
@@ -89,7 +110,7 @@ public function execute()
      */
     protected function jsonResponse($error = '')
     {
-        return $this->getResponse()->representJson(
+        return $this->response->representJson(
             $this->jsonHelper->jsonEncode($this->sidebar->getResponseData($error))
         );
     }

app/code/Magento/Checkout/Test/Unit/Controller/Sidebar/UpdateItemQtyTest.php

@@ -244,4 +244,42 @@ public function testExecuteWithException(): void
 
         $this->assertEquals('json represented', $this->updateItemQty->execute());
     }
+
+    /**
+     * @return void
+     */
+    public function testExecuteWithInputException(): void
+    {
+        $this->requestMock
+            ->method('getParam')
+            ->withConsecutive(['item_id', null], ['item_qty', null])
+            ->willReturnOnConsecutiveCalls('1', '{{7+2}}');
+
+        $this->sidebarMock->expects($this->once())
+            ->method('getResponseData')
+            ->with('A non-numeric value found')
+            ->willReturn(
+                [
+                    'success' => false,
+                    'error_message' => 'A non-numeric value found'
+                ]
+            );
+
+        $this->jsonHelperMock->expects($this->once())
+            ->method('jsonEncode')
+            ->with(
+                [
+                    'success' => false,
+                    'error_message' => 'A non-numeric value found'
+                ]
+            )
+            ->willReturn('json encoded');
+
+        $this->responseMock->expects($this->once())
+            ->method('representJson')
+            ->with('json encoded')
+            ->willReturn('json represented');
+
+        $this->assertEquals('json represented', $this->updateItemQty->execute());
+    }
 }