ENGCOM-5468: Resolve Rule coupon code generate form validation issue23778 #23781

Author: VladimirZaets

app/code/Magento/SalesRule/Block/Adminhtml/Promo/Quote/Edit/Tab/Coupons/Form.php

@@ -3,12 +3,16 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\SalesRule\Block\Adminhtml\Promo\Quote\Edit\Tab\Coupons;
 
 /**
  * Coupons generation parameters form
  *
  * @author      Magento Core Team <core@magentocommerce.com>
+ *
+ * Class \Magento\SalesRule\Block\Adminhtml\Promo\Quote\Edit\Tab\Coupons\Form
  */
 class Form extends \Magento\Backend\Block\Widget\Form\Generic
 {
@@ -77,7 +81,8 @@ protected function _prepareForm()
                 'label' => __('Coupon Qty'),
                 'title' => __('Coupon Qty'),
                 'required' => true,
-                'class' => 'validate-digits validate-greater-than-zero'
+                'class' => 'validate-digits validate-greater-than-zero',
+                'onchange' => 'window.validateCouponGenerate(this)'
             ]
         );
 
@@ -91,7 +96,8 @@ protected function _prepareForm()
                 'required' => true,
                 'note' => __('Excluding prefix, suffix and separators.'),
                 'value' => $couponHelper->getDefaultLength(),
-                'class' => 'validate-digits validate-greater-than-zero'
+                'class' => 'validate-digits validate-greater-than-zero',
+                'onchange' => 'window.validateCouponGenerate(this)'
             ]
         );
 
@@ -103,7 +109,8 @@ protected function _prepareForm()
                 'name' => 'format',
                 'options' => $couponHelper->getFormatsList(),
                 'required' => true,
-                'value' => $couponHelper->getDefaultFormat()
+                'value' => $couponHelper->getDefaultFormat(),
+                'onchange' => 'window.validateCouponGenerate(this)'
             ]
         );
 
@@ -138,7 +145,8 @@ protected function _prepareForm()
                 'title' => __('Dash Every X Characters'),
                 'note' => __('If empty no separation.'),
                 'value' => $couponHelper->getDefaultDashInterval(),
-                'class' => 'validate-digits'
+                'class' => 'validate-digits',
+                'onchange' => 'window.validateCouponGenerate(this)'
             ]
         );
 

app/code/Magento/SalesRule/view/adminhtml/templates/promo/salesrulejs.phtml

@@ -20,10 +20,19 @@ function refreshCouponCodesGrid(grid, gridMassAction, transport) {
 
 function generateCouponCodes(idPrefix, generateUrl, grid) {
     $(idPrefix + 'information_fieldset').removeClassName('ignore-validate');
+    var listInvalidElement = [];
     var validationResult = $(idPrefix + 'information_fieldset').select('input',
             'select', 'textarea').collect( function(elm) {
-        return jQuery.validator.validateElement(elm);
+        var validateOneElementResult = jQuery.validator.validateSingleElement(elm);
+        if (!validateOneElementResult) {
+            listInvalidElement.push(elm);
+        }
+        return validateOneElementResult;
     }).all();
+    if (listInvalidElement.length) {
+        listInvalidElement[0].focus();
+    }
+
     $(idPrefix + 'information_fieldset').addClassName('ignore-validate');
 
     if (!validationResult) {
@@ -77,6 +86,11 @@ function generateCouponCodes(idPrefix, generateUrl, grid) {
     });
 }
 
+function validateCouponGenerate(elm) {
+    jQuery.validator.validateSingleElement(elm);
+}
+
+window.validateCouponGenerate = validateCouponGenerate;
 window.generateCouponCodes = generateCouponCodes;
 window.refreshCouponCodesGrid = refreshCouponCodesGrid;
 });