🔃 [Magento Community Engineering] Community Contributions

Accepted Community Pull Requests:
 - #27118: FIX #27117 Invalid functional Test names (by @lbajsarowicz)


Fixed GitHub Issues:
 - #27117: MFTF: Test names are not following Best Practices (`Test` suffix) (reported by @lbajsarowicz) has been fixed in #27118 by @lbajsarowicz in 2.4-develop branch
   Related commits:
     1. b6b69a6
     2. da8dfc2
     3. 4f2da6f
     4. 1045eb8
     5. db38991

Author: magento-engcom-team

app/code/Magento/Braintree/Test/Mftf/Test/CreateAnAdminOrderUsingBraintreePaymentTest1.xml renamed to app/code/Magento/Braintree/Test/Mftf/Test/CreateAnAdminOrderUsingBraintreePaymentTest.xml

@@ -8,7 +8,7 @@
 
 <tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
        xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
-    <test name="CreateAnAdminOrderUsingBraintreePaymentTest1">
+    <test name="CreateAnAdminOrderUsingBraintreePaymentTest1Test">
         <annotations>
             <features value="Backend"/>
             <stories value="Creation an admin order using Braintree payment"/>

app/code/Magento/Braintree/Test/Mftf/Test/CretateAdminOrderWithOnlinePaymentIncludingTaxAndDiscount.xml renamed to app/code/Magento/Braintree/Test/Mftf/Test/CretateAdminOrderWithOnlinePaymentIncludingTaxAndDiscountTest.xml

@@ -8,7 +8,7 @@
 
 <tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
        xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
-    <test name="CreateAdminOrderPayedWithOnlinePaymentIncludingTaxAndDiscount">
+    <test name="CreateAdminOrderPayedWithOnlinePaymentIncludingTaxAndDiscountTest">
         <annotations>
             <features value="Braintree"/>
             <stories value="Get access to a New Credit Memo Page from Invoice for Order payed with online payment via Admin"/>

app/code/Magento/Bundle/Test/Mftf/Test/AdminDeleteABundleProduct.xml renamed to app/code/Magento/Bundle/Test/Mftf/Test/AdminDeleteABundleProductTest.xml

@@ -8,7 +8,7 @@
 
 <tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
-    <test name="AdminDeleteABundleProduct">
+    <test name="AdminDeleteABundleProductTest">
         <annotations>
             <features value="Bundle"/>
             <stories value="Admin list bundle products"/>

app/code/Magento/Bundle/Test/Mftf/Test/AdminFilterProductListByBundleProduct.xml renamed to app/code/Magento/Bundle/Test/Mftf/Test/AdminFilterProductListByBundleProductTest.xml

@@ -8,7 +8,7 @@
 
 <tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
-    <test name="AdminFilterProductListByBundleProduct">
+    <test name="AdminFilterProductListByBundleProductTest">
         <annotations>
             <features value="Bundle"/>
             <stories value="Admin list bundle products"/>

app/code/Magento/Bundle/Test/Mftf/Test/StorefrontBundleProductShownInCategoryListAndGrid.xml renamed to app/code/Magento/Bundle/Test/Mftf/Test/StorefrontBundleProductShownInCategoryListAndGridTest.xml

@@ -8,7 +8,7 @@
 
 <tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
-    <test name="StorefrontBundleProductShownInCategoryListAndGrid">
+    <test name="StorefrontBundleProductShownInCategoryListAndGridTest">
         <annotations>
             <features value="Bundle"/>
             <stories value="Bundle products list on Storefront"/>

app/code/Magento/Bundle/Test/Mftf/Test/StorefrontCheckBundleProductOptionTierPrices.xml renamed to app/code/Magento/Bundle/Test/Mftf/Test/StorefrontCheckBundleProductOptionTierPricesTest.xml

@@ -8,7 +8,7 @@
 
 <tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
        xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
-    <test name="StorefrontCheckBundleProductOptionTierPrices">
+    <test name="StorefrontCheckBundleProductOptionTierPricesTest">
         <annotations>
             <features value="Bundle"/>
             <stories value="View bundle products"/>

app/code/Magento/Bundle/Test/Mftf/Test/StorefrontGoToDetailsPageWhenAddingToCartTest.xml

@@ -8,7 +8,7 @@
 
 <tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
-    <test name="StorefrontGoToDetailsPageWhenAddingToCart">
+    <test name="StorefrontGoToDetailsPageWhenAddingToCartTest">
         <annotations>
             <features value="Bundle"/>
             <stories value="Bundle products list on Storefront"/>

app/code/Magento/Captcha/Test/Mftf/Test/CaptchaFormsDisplayingTest.xml

@@ -65,7 +65,7 @@
         <scrollToTopOfPage stepKey="ScrollToTop"/>
         <click selector="{{CaptchaFormsDisplayingSection.captcha}}" stepKey="ClickToCloseCaptcha"/>
     </test>
-    <test name="CaptchaWithDisabledGuestCheckout">
+    <test name="CaptchaWithDisabledGuestCheckoutTest">
         <annotations>
             <features value="Captcha"/>
             <stories value="MC-5602 - CAPTCHA doesn't appear in login popup after refreshing page."/>

app/code/Magento/Catalog/Test/Mftf/Test/AdminChangeProductAttributeSet.xml renamed to app/code/Magento/Catalog/Test/Mftf/Test/AdminChangeProductAttributeSetTest.xml

@@ -7,7 +7,7 @@
 -->
 <tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
        xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
-    <test name="AdminChangeProductAttributeSet">
+    <test name="AdminChangeProductAttributeSetTest">
         <annotations>
             <features value="Checkout"/>
             <stories value="The required product attribute is not displayed when change attribute set"/>
@@ -49,7 +49,7 @@
             <actionGroup ref="ClearProductsFilterActionGroup" stepKey="clearProductsFilter"/>
 
             <!-- Reindex invalidated indices after product attribute has been created/deleted -->
-            <actionGroup ref="CliRunReindexUsingCronJobsActionGroup" stepKey="reindexInvalidatedIndices"/>
+            <magentoCron groups="index" stepKey="reindexInvalidatedIndices"/>
         </after>
 
         <actionGroup ref="SearchForProductOnBackendActionGroup" stepKey="searchForSimpleProduct">

app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateCategoryWithProductsGridFilter.xml renamed to app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateCategoryWithProductsGridFilterTest.xml

@@ -7,7 +7,7 @@
 -->
 <tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
        xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
-    <test name="AdminCreateCategoryWithProductsGridFilter">
+    <test name="AdminCreateCategoryWithProductsGridFilterTest">
         <annotations>
             <stories value="Create categories"/>
             <title value="Apply category products grid filter"/>