ENGCOM-5552: No alert when user 'Apply empty Coupon Code' in create new order form (issue 24015) #24016

 - Merge Pull Request #24016 from edenduong/magento2:2.3-bugfix/empty_coupon_alert_issue24015
 - Merged commits:
   1. 866a154
   2. 7c40321

Author: magento-engcom-team

app/code/Magento/Sales/i18n/en_US.csv

@@ -797,3 +797,5 @@ Created,Created
 Refunds,Refunds
 "Allow Zero GrandTotal for Creditmemo","Allow Zero GrandTotal for Creditmemo"
 "Allow Zero GrandTotal","Allow Zero GrandTotal"
+"Please enter a coupon code!","Please enter a coupon code!"
+

app/code/Magento/Sales/view/adminhtml/templates/order/create/coupons/form.phtml

@@ -12,7 +12,7 @@
     <div class="admin__field-control">
         <?php if (!$block->getCouponCode()) : ?>
         <input type="text" class="admin__control-text" id="coupons:code" value="" name="coupon_code" />
-            <?= $block->getButtonHtml(__('Apply'), 'order.applyCoupon($F(\'coupons:code\'))') ?>
+            <?= $block->getButtonHtml(__('Apply'), 'order.handleOnclickCoupon($F(\'coupons:code\'))') ?>
         <?php endif; ?>
         <?php if ($block->getCouponCode()) : ?>
         <p class="added-coupon-code">
@@ -22,9 +22,23 @@
         </p>
         <?php endif; ?>
         <script>
-            require(["Magento_Sales/order/create/form"], function() {
+            require([
+                "jquery",
+                'Magento_Ui/js/modal/alert',
+                'mage/translate',
+                "Magento_Sales/order/create/form"
+            ], function($, alert) {
                 order.overlay('shipping-method-overlay', <?php if ($block->getQuote()->isVirtual()) : ?>false<?php else : ?>true<?php endif; ?>);
                 order.overlay('address-shipping-overlay', <?php if ($block->getQuote()->isVirtual()) : ?>false<?php else : ?>true<?php endif; ?>);
+                order.handleOnclickCoupon = function (code) {
+                    if (!code) {
+                        alert({
+                            content: $.mage.__('Please enter a coupon code!')
+                        });
+                    } else {
+                        order.applyCoupon(code);
+                    }
+                };
             });
         </script>
     </div>

app/code/Magento/Sales/view/adminhtml/web/order/create/scripts.js

@@ -445,8 +445,8 @@ define([
          */
         loadShippingRates: function () {
             var addressContainer = this.shippingAsBilling ?
-                    'billingAddressContainer' :
-                    'shippingAddressContainer',
+                'billingAddressContainer' :
+                'shippingAddressContainer',
                 data = this.serializeData(this[addressContainer]).toObject();
 
             data['collect_shipping_rates'] = 1;