PR:37013 fix for static test failures

Author: engcom-Delta

app/code/Magento/Sales/Controller/Adminhtml/Order/Create.php

@@ -343,7 +343,7 @@ protected function _processActionData($action = null)
                     $this->messageManager->addSuccessMessage(__('The coupon code has been accepted.'));
                 }
             }
-        } elseif (isset($data['coupon']['code']) && empty($couponCode)) {
+        } elseif (isset($data['coupon']['code']) && $couponCode=='') {
             $this->messageManager->addSuccessMessage(__('The coupon code has been removed.'));
         }
 

app/code/Magento/Sales/Model/Config/Ordered.php

@@ -10,6 +10,7 @@
 
 /**
  * Configuration class for ordered items
+ * phpcs:disable Magento2.Classes.AbstractApi
  * @api
  *
  * @since 100.0.2
@@ -143,6 +144,7 @@ protected function _prepareConfigArray($code, $totalConfig)
 
     /**
      * Aggregate before/after information from all items and sort totals based on this data
+     *
      * Invoke simple sorting if the first element contains the "sort_order" key
      *
      * @param array $config
@@ -177,6 +179,7 @@ function ($a, $b) {
 
     /**
      * Initialize collectors array.
+     *
      * Collectors array is array of total models ordered based on configuration settings
      *
      * @return $this

app/code/Magento/Sales/Model/Order/Creditmemo/Total/AbstractTotal.php

@@ -7,6 +7,7 @@
 
 /**
  * Base class for credit memo total
+ * phpcs:disable Magento2.Classes.AbstractApi
  * @api
  *
  * @since 100.0.2

app/code/Magento/Sales/Model/Order/Invoice/Total/AbstractTotal.php

@@ -7,6 +7,7 @@
 
 /**
  * Base class for invoice total
+ * phpcs:disable Magento2.Classes.AbstractApi
  * @api
  * @since 100.0.2
  */

app/code/Magento/Sales/Model/Order/Payment/Transaction.php

@@ -25,7 +25,7 @@ class Transaction extends AbstractModel implements TransactionInterface
     /**
      * Raw details key in additional info
      */
-    const RAW_DETAILS = 'raw_details_info';
+    public const RAW_DETAILS = 'raw_details_info';
 
     /**
      * Order instance
@@ -94,8 +94,6 @@ class Transaction extends AbstractModel implements TransactionInterface
     protected $_eventObject = 'order_payment_transaction';
 
     /**
-     * Order website id
-     *
      * @var int
      */
     protected $_orderWebsiteId = null;
@@ -408,6 +406,7 @@ public function canVoidAuthorizationCompletely()
             return true;
         } catch (\Magento\Framework\Exception\LocalizedException $e) {
             // jam all logical exceptions, fallback to false
+            return false;
         }
         return false;
     }

app/code/Magento/Sales/Model/Order/Shipment/Track.php

@@ -20,7 +20,7 @@ class Track extends AbstractModel implements ShipmentTrackInterface
     /**
      * Code of custom carrier
      */
-    const CUSTOM_CARRIER_CODE = 'custom';
+    public const CUSTOM_CARRIER_CODE = 'custom';
 
     /**
      * @var \Magento\Sales\Model\Order\Shipment|null
@@ -244,7 +244,7 @@ public function getCreatedAt()
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function setCreatedAt($createdAt)
     {
@@ -322,79 +322,79 @@ public function getWeight()
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function setUpdatedAt($timestamp)
     {
         return $this->setData(ShipmentTrackInterface::UPDATED_AT, $timestamp);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function setParentId($id)
     {
         return $this->setData(ShipmentTrackInterface::PARENT_ID, $id);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function setWeight($weight)
     {
         return $this->setData(ShipmentTrackInterface::WEIGHT, $weight);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function setQty($qty)
     {
         return $this->setData(ShipmentTrackInterface::QTY, $qty);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function setOrderId($id)
     {
         return $this->setData(ShipmentTrackInterface::ORDER_ID, $id);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function setTrackNumber($trackNumber)
     {
         return $this->setData(ShipmentTrackInterface::TRACK_NUMBER, $trackNumber);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function setDescription($description)
     {
         return $this->setData(ShipmentTrackInterface::DESCRIPTION, $description);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function setTitle($title)
     {
         return $this->setData(ShipmentTrackInterface::TITLE, $title);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function setCarrierCode($code)
     {
         return $this->setData(ShipmentTrackInterface::CARRIER_CODE, $code);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      *
      * @return \Magento\Sales\Api\Data\ShipmentTrackExtensionInterface|null
      */
@@ -404,7 +404,7 @@ public function getExtensionAttributes()
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      *
      * @param \Magento\Sales\Api\Data\ShipmentTrackExtensionInterface $extensionAttributes
      * @return $this

app/code/Magento/Sales/Model/Order/Tax.php

@@ -30,6 +30,8 @@
 class Tax extends \Magento\Framework\Model\AbstractModel
 {
     /**
+     * Constructor
+     *
      * @return void
      */
     protected function _construct()

app/code/Magento/Sales/Model/Order/Total/AbstractTotal.php

@@ -7,6 +7,7 @@
 
 /**
  * Base class for configure totals order
+ * phpcs:disable Magento2.Classes.AbstractApi
  * @api
  *
  * @since 100.0.2
@@ -15,6 +16,7 @@ abstract class AbstractTotal extends \Magento\Framework\DataObject
 {
     /**
      * Process model configuration array.
+     *
      * This method can be used for changing models apply sort order
      *
      * @param   array $config

app/code/Magento/Sales/Model/ResourceModel/Order.php

@@ -22,15 +22,11 @@
 class Order extends SalesResource implements OrderResourceInterface
 {
     /**
-     * Event prefix
-     *
      * @var string
      */
     protected $_eventPrefix = 'sales_order_resource';
 
     /**
-     * Event object
-     *
      * @var string
      */
     protected $_eventObject = 'resource';

app/code/Magento/Sales/Model/ResourceModel/Order/Collection.php

@@ -22,15 +22,11 @@ class Collection extends AbstractCollection implements OrderSearchResultInterfac
     protected $_idFieldName = 'entity_id';
 
     /**
-     * Event prefix
-     *
      * @var string
      */
     protected $_eventPrefix = 'sales_order_collection';
 
     /**
-     * Event object
-     *
      * @var string
      */
     protected $_eventObject = 'order_collection';