AC-8753: Coupon quantity generation checks

   * Code refinements and translations

Author: faraz-gl

app/code/Magento/SalesRule/Controller/Adminhtml/Promo/Quote/Generate.php

@@ -166,21 +166,21 @@ public function execute(): void
                     self::XML_CONFIG_COUPON_QUANTITY_LIMIT,
                     ScopeInterface::SCOPE_STORE
                 );
-                if ($data['quantity'] > 0 && $data['quantity'] > $couponQuantityLimit) {
+                if ($data['quantity'] > 0 && $data['quantity'] <= $couponQuantityLimit) {
+                    $couponSpec = $this->generationSpecFactory->create(['data' => $data]);
+
+                    $this->messagePublisher->publish('sales_rule.codegenerator', $couponSpec);
+                    $this->messageManager->addSuccessMessage(
+                        __('Message is added to queue, wait to get your coupons soon')
+                    );
+                } else {
                     // @codingStandardsIgnoreStart
                     $this->messageManager->addErrorMessage(
                         __(
                             'Coupon quantity should be less than or equal to the coupon quantity in the store configuration.'
                         )
                     );
                     // @codingStandardsIgnoreEnd
-                } else {
-                    $couponSpec = $this->generationSpecFactory->create(['data' => $data]);
-
-                    $this->messagePublisher->publish('sales_rule.codegenerator', $couponSpec);
-                    $this->messageManager->addSuccessMessage(
-                        __('Message is added to queue, wait to get your coupons soon')
-                    );
                 }
                 $this->_view->getLayout()->initMessages();
                 $result['messages'] = $this->_view->getLayout()->getMessagesBlock()->getGroupedHtml();

app/code/Magento/SalesRule/etc/config.xml

@@ -10,7 +10,7 @@
         <promo>
             <auto_generated_coupon_codes>
                 <length>12</length>
-                <quantity>250000</quantity>
+                <quantity_limit>250000</quantity_limit>
                 <format>1</format>
             </auto_generated_coupon_codes>
         </promo>

app/code/Magento/SalesRule/i18n/en_US.csv

@@ -170,3 +170,5 @@ Apply,Apply
 "When coupon quantity exceeds %1, the coupon code length must be minimum %2", "When coupon quantity exceeds %1, the coupon code length must be minimum %2"
 "Discount amount is distributed among subtotal and shipping amount. Cases when multiple discounts applied to shipping amount are not supported. The option is going to be removed in future releases.ly","Discount amount is distributed among subtotal and shipping amount. Cases when multiple discounts applied to shipping amount are not supported. The option is going to be removed in future releases."
 "Coupon quantity should be less than or equal to the coupon quantity in the store configuration.","Coupon quantity should be less than or equal to the coupon quantity in the store configuration."
+"Code Quantity Limit","Code Quantity Limit"
+"For better performance max value allowed is 250,000.","For better performance max value allowed is 250,000."