product graphql query returns incorrect category data in aggregation

Author: glo82145

app/code/Magento/CatalogGraphQl/DataProvider/Product/LayeredNavigation/Builder/Category.php

@@ -17,6 +17,7 @@
 use Magento\Framework\Api\Search\AggregationValueInterface;
 use Magento\Framework\Api\Search\BucketInterface;
 use Magento\Framework\App\ResourceConnection;
+use Magento\Framework\GraphQl\Query\Uid;
 
 /**
  * Category layer builder
@@ -73,7 +74,10 @@ class Category implements LayerBuilderInterface
     /**
      * @var Aggregations\Category\IncludeDirectChildrenOnly
      */
-    private Aggregations\Category\IncludeDirectChildrenOnly $includeDirectChildrenOnly;
+     private Aggregations\Category\IncludeDirectChildrenOnly $includeDirectChildrenOnly;
+
+     /** @var Uid */
+     private Uid $uidEncoder;
 
     /**
      * @param CategoryAttributeQuery $categoryAttributeQuery
@@ -91,7 +95,8 @@ public function __construct(
         ResourceConnection $resourceConnection,
         LayerFormatter $layerFormatter,
         Aggregations\Category\IncludeDirectChildrenOnly $includeDirectChildrenOnly,
-        CollectionFactory $categoryCollectionFactory
+        CollectionFactory $categoryCollectionFactory,
+        Uid $uidEncoder
     ) {
         $this->categoryAttributeQuery = $categoryAttributeQuery;
         $this->attributesMapper = $attributesMapper;
@@ -100,6 +105,7 @@ public function __construct(
         $this->layerFormatter = $layerFormatter;
         $this->includeDirectChildrenOnly = $includeDirectChildrenOnly;
         $this->categoryCollectionFactory = $categoryCollectionFactory;
+        $this->uidEncoder = $uidEncoder;
     }
 
     /**
@@ -155,7 +161,7 @@ function (AggregationValueInterface $value) {
             }
             $result['options'][] = $this->layerFormatter->buildItem(
                 $categoryLabels[$categoryId] ?? $categoryId,
-                $categoryId,
+                $this->uidEncoder->encode((string) $categoryId),
                 $value->getMetrics()['count']
             );
         }

dev/tests/api-functional/testsuite/Magento/GraphQl/Catalog/ProductSearchCategoryAggregationsTest.php

@@ -7,13 +7,30 @@
 
 namespace Magento\GraphQl\Catalog;
 
+use Magento\Framework\GraphQl\Query\Uid;
+use Magento\TestFramework\Helper\Bootstrap;
+use Magento\TestFramework\ObjectManager;
 use Magento\TestFramework\TestCase\GraphQlAbstract;
 
 /**
  * Test of search by category ID aggregation.
  */
 class ProductSearchCategoryAggregationsTest extends GraphQlAbstract
 {
+    /** @var ObjectManager */
+    private $objectManager;
+
+    /** @var Uid */
+    private $uid;
+
+    /**
+     * @inheritdoc
+     */
+    protected function setUp(): void
+    {
+        $this->objectManager = Bootstrap::getObjectManager();
+        $this->uid = $this->objectManager->get(Uid::class);
+    }
     /**
      * Test category_id aggregation on filter by "eq" category ID condition.
      *
@@ -84,6 +101,7 @@ private function aggregationCategoryTesting(string $filterValue, string $include
     {
         $query = $this->getGraphQlQuery($filterValue, $includeDirectChildrenOnly);
         $result = $this->graphQlQuery($query);
+
         $this->assertArrayNotHasKey('errors', $result);
         $this->assertArrayHasKey('aggregations', $result['products']);
         $categoryAggregation = array_filter(
@@ -99,7 +117,7 @@ function ($a) {
         foreach ($categoryAggregation['options'] as $option) {
             $this->assertNotEmpty($option['value']);
             $this->assertNotEmpty($option['label']);
-            $categoryAggregationIdsLabel[(int)$option['value']] = $option['label'];
+            $categoryAggregationIdsLabel[$this->uid->decode($option['value'])] = $option['label'];
         }
         return $categoryAggregationIdsLabel;
     }

dev/tests/api-functional/testsuite/Magento/GraphQl/CatalogGraphQl/CategoryTest.php

@@ -24,7 +24,7 @@ public function testCheckCategoryUidAsAggregation(): void
         $query = $this->getSearchQueryWithSCategoryUID();
         $response = $this->graphQlQuery($query);
         $this->assertNotEmpty($response['products']);
-        $this->assertEquals(1, count($response['products']['aggregations']));
+        $this->assertEquals(2, count($response['products']['aggregations']));
         $this->assertNotEmpty($response['products']['aggregations']);
         $this->assertEquals('price', $response['products']['aggregations'][0]['attribute_code']);
     }