CE#34567: Fix deprecation issues

Author: karyna-t

app/code/Magento/Bundle/Pricing/Price/BundleRegularPrice.php

@@ -27,36 +27,22 @@ class BundleRegularPrice extends \Magento\Catalog\Pricing\Price\RegularPrice imp
      */
     protected $maximalPrice;
 
-    /**
-     * @param Product $saleableItem
-     * @param float $quantity
-     * @param BundleCalculatorInterface $calculator
-     * @param \Magento\Framework\Pricing\PriceCurrencyInterface $priceCurrency
-     */
-    public function __construct(
-        Product $saleableItem,
-        $quantity,
-        BundleCalculatorInterface $calculator,
-        \Magento\Framework\Pricing\PriceCurrencyInterface $priceCurrency
-    ) {
-        parent::__construct($saleableItem, $quantity, $calculator, $priceCurrency);
-    }
-
     /**
      * @inheritdoc
      */
     public function getAmount()
     {
-        if (!isset($this->amount[$this->getValue()])) {
-            $price = $this->getValue();
+        $price = $this->getValue();
+        $valueIndex = (string) $price;
+        if (!isset($this->amount[$valueIndex])) {
             if ($this->product->getPriceType() == Price::PRICE_TYPE_FIXED) {
                 /** @var \Magento\Catalog\Pricing\Price\CustomOptionPrice $customOptionPrice */
                 $customOptionPrice = $this->priceInfo->getPrice(CustomOptionPrice::PRICE_CODE);
                 $price += $customOptionPrice->getCustomOptionRange(true, $this->getPriceCode());
             }
-            $this->amount[$this->getValue()] = $this->calculator->getMinRegularAmount($price, $this->product);
+            $this->amount[$valueIndex] = $this->calculator->getMinRegularAmount($price, $this->product);
         }
-        return $this->amount[$this->getValue()];
+        return $this->amount[$valueIndex];
     }
 
     /**

app/code/Magento/Customer/Model/Address/AbstractAddress.php

@@ -40,9 +40,9 @@ class AbstractAddress extends AbstractExtensibleModel implements AddressModelInt
     /**
      * Possible customer address types
      */
-    const TYPE_BILLING = 'billing';
+    public const TYPE_BILLING = 'billing';
 
-    const TYPE_SHIPPING = 'shipping';
+    public const TYPE_SHIPPING = 'shipping';
 
     /**
      * Prefix of model events
@@ -73,8 +73,6 @@ class AbstractAddress extends AbstractExtensibleModel implements AddressModelInt
     protected static $_regionModels = [];
 
     /**
-     * Directory data
-     *
      * @var \Magento\Directory\Helper\Data
      */
     protected $_directoryData = null;
@@ -241,7 +239,7 @@ public function getStreetLine($number)
     public function getStreetFull()
     {
         $street = $this->getData('street');
-        return is_array($street) ? implode("\n", $street) : $street;
+        return is_array($street) ? implode("\n", $street) : ($street ?? '');
     }
 
     /**

dev/tests/integration/testsuite/Magento/Shipping/Block/Adminhtml/Order/AddToPackageTest.php

@@ -75,13 +75,13 @@ public function testGetCommentsHtml(): void
      *
      * @magentoDataFixture Magento/Shipping/_files/shipping_with_carrier_data_different_currency_code.php
      */
-    public function testGetCurrencyCodeCustomValue ()
+    public function testGetCurrencyCodeCustomValue()
     {
         $template = '/<span class="customs-value-currency">\s*?(?<currency>[A-Za-z]+)\s*?<\/span>/';
         $matches = [];
         preg_match($template, $this->getHtml(), $matches);
         $currency = $matches['currency'] ?? null;
-        $this->assertEquals('FR',$currency );
+        $this->assertEquals('FR', $currency);
     }
 
     /**
@@ -102,6 +102,7 @@ private function getHtml()
         $this->registry->register('current_shipment', $shipment);
 
         $block->setTemplate('Magento_Shipping::order/packaging/popup.phtml');
+        $block->setNameInLayout('test');
 
         return $block->toHtml();
     }

dev/tests/integration/testsuite/Magento/User/Block/User/Edit/Tab/MainTest.php

@@ -28,6 +28,7 @@ protected function setUp(): void
 
         $this->_block = $objectManager->create(\Magento\User\Block\User\Edit\Tab\Main::class);
         $this->_block->setArea('adminhtml');
+        $this->_block->setNameInLayout('test');
         $this->_user = $objectManager->create(\Magento\User\Model\User::class);
 
         $objectManager->get(\Magento\Framework\Registry::class)->register('permissions_user', $this->_user);

lib/internal/Magento/Framework/Url/Decoder.php

@@ -24,14 +24,14 @@ public function __construct(
     }
 
     /**
-     * base64_decode() for URLs decoding
+     * Base64 decode for URL
      *
      * @param    string $url
      * @return   string
      */
     public function decode($url)
     {
-        $url = base64_decode(strtr($url, '-_,', '+/='));
+        $url = $url !== null ? base64_decode(strtr($url, '-_,', '+/=')) : '';
         return $this->urlBuilder->sessionUrlVar($url);
     }
 }