ACP2E-1155: Refunding Issue Rest API

Author: Anna Bukatar

app/code/Magento/Sales/Model/Order/Creditmemo/Validation/QuantityValidator.php

@@ -88,7 +88,7 @@ public function validate($entity)
             }
         }
 
-        if ($entity->getGrandTotal() <= 0) {
+        if (!$entity->isValidGrandTotal()) {
             $messages[] = __('The credit memo\'s total must be positive.');
         } elseif ($totalQuantity < 0 && !$this->canRefundShipping($order)) {
             $messages[] = __('You can\'t create a creditmemo without products.');

app/code/Magento/Sales/Model/Order/Invoice/Validation/CanRefund.php

@@ -5,13 +5,15 @@
  */
 namespace Magento\Sales\Model\Order\Invoice\Validation;
 
+use Magento\Framework\App\Config\ScopeConfigInterface;
 use Magento\Payment\Model\InfoInterface;
 use Magento\Payment\Model\MethodInterface;
 use Magento\Sales\Api\Data\InvoiceInterface;
 use Magento\Sales\Api\OrderPaymentRepositoryInterface;
 use Magento\Sales\Api\OrderRepositoryInterface;
 use Magento\Sales\Model\Order\Invoice;
 use Magento\Sales\Model\ValidatorInterface;
+use Magento\Framework\App\ObjectManager;
 
 /**
  * Class CanRefund
@@ -28,18 +30,26 @@ class CanRefund implements ValidatorInterface
      */
     private $orderRepository;
 
+    /**
+     * @var ScopeConfigInterface;
+     */
+    private $scopeConfig;
+
     /**
      * CanRefund constructor.
      *
      * @param OrderPaymentRepositoryInterface $paymentRepository
      * @param OrderRepositoryInterface $orderRepository
+     * @param ScopeConfigInterface|null $scopeConfig
      */
     public function __construct(
         OrderPaymentRepositoryInterface $paymentRepository,
-        OrderRepositoryInterface $orderRepository
+        OrderRepositoryInterface $orderRepository,
+        ?ScopeConfigInterface $scopeConfig = null
     ) {
         $this->paymentRepository = $paymentRepository;
         $this->orderRepository = $orderRepository;
+        $this->scopeConfig = $scopeConfig ?? ObjectManager::getInstance()->get(ScopeConfigInterface::class);
     }
 
     /**
@@ -69,7 +79,10 @@ private function isPaymentAllowRefund(InvoiceInterface $invoice)
             return false;
         }
         $method = $payment->getMethodInstance();
-        return $this->canPartialRefund($method, $payment) || $this->canFullRefund($invoice, $method);
+        if (!$method instanceof \Magento\Payment\Model\Method\Free) {
+            return $this->canPartialRefund($method, $payment) || $this->canFullRefund($invoice, $method);
+        }
+        return true;
     }
 
     /**
@@ -78,7 +91,22 @@ private function isPaymentAllowRefund(InvoiceInterface $invoice)
      */
     private function isGrandTotalEnoughToRefund(InvoiceInterface $entity)
     {
-        return abs($entity->getBaseGrandTotal() - $entity->getBaseTotalRefunded()) >= .0001;
+        return abs($entity->getBaseGrandTotal() - $entity->getBaseTotalRefunded()) >= .0001 ||
+            $this->isAllowZeroGrandTotal();
+    }
+
+    /**
+     * Return Zero GrandTotal availability.
+     *
+     * @return bool
+     */
+    private function isAllowZeroGrandTotal()
+    {
+        $isAllowed = $this->scopeConfig->getValue(
+            'sales/zerograndtotal_creditmemo/allow_zero_grandtotal',
+            \Magento\Store\Model\ScopeInterface::SCOPE_STORE
+        );
+        return $isAllowed;
     }
 
     /**

app/code/Magento/Sales/Model/Order/Validation/CanRefund.php

@@ -5,10 +5,12 @@
  */
 namespace Magento\Sales\Model\Order\Validation;
 
+use Magento\Framework\App\Config\ScopeConfigInterface;
 use Magento\Framework\Pricing\PriceCurrencyInterface;
 use Magento\Sales\Api\Data\OrderInterface;
 use Magento\Sales\Model\Order;
 use Magento\Sales\Model\ValidatorInterface;
+use Magento\Framework\App\ObjectManager;
 
 /**
  * Class CanRefund
@@ -20,14 +22,23 @@ class CanRefund implements ValidatorInterface
      */
     private $priceCurrency;
 
+    /**
+     * @var ScopeConfigInterface;
+     */
+    private $scopeConfig;
+
     /**
      * CanRefund constructor.
      *
      * @param PriceCurrencyInterface $priceCurrency
+     * @param ScopeConfigInterface|null $scopeConfig
      */
-    public function __construct(PriceCurrencyInterface $priceCurrency)
-    {
+    public function __construct(
+        PriceCurrencyInterface $priceCurrency,
+        ?ScopeConfigInterface $scopeConfig = null
+    ) {
         $this->priceCurrency = $priceCurrency;
+        $this->scopeConfig = $scopeConfig ?? ObjectManager::getInstance()->get(ScopeConfigInterface::class);
     }
 
     /**
@@ -62,6 +73,22 @@ public function validate($entity)
      */
     private function isTotalPaidEnoughForRefund(OrderInterface $order)
     {
-        return !abs($this->priceCurrency->round($order->getTotalPaid()) - $order->getTotalRefunded()) < .0001;
+        return !abs($this->priceCurrency->round($order->getTotalPaid()) - $order->getTotalRefunded()) < .0001 ||
+            $order->getTotalPaid() == 0 &&
+            $this->isAllowZeroGrandTotal();
+    }
+
+    /**
+     * Return Zero GrandTotal availability.
+     *
+     * @return bool
+     */
+    private function isAllowZeroGrandTotal()
+    {
+        $isAllowed = $this->scopeConfig->getValue(
+            'sales/zerograndtotal_creditmemo/allow_zero_grandtotal',
+            \Magento\Store\Model\ScopeInterface::SCOPE_STORE
+        );
+        return $isAllowed;
     }
 }