MC-39584: Create automated test for: "Switching store views of category"

Author: Serhii Bohomaz

dev/tests/integration/testsuite/Magento/Catalog/Controller/Adminhtml/Category/EditTest.php

@@ -8,7 +8,6 @@
 namespace Magento\Catalog\Controller\Adminhtml\Category;
 
 use Magento\Catalog\Api\Data\CategoryInterface;
-use Magento\Catalog\Model\ResourceModel\Category\Collection;
 use Magento\Catalog\Model\ResourceModel\Category\CollectionFactory;
 use Magento\Framework\App\Request\Http as HttpRequest;
 use Magento\Store\Model\StoreManagerInterface;
@@ -23,7 +22,7 @@
  */
 class EditTest extends AbstractBackendController
 {
-    /** @var Collection */
+    /** @var CollectionFactory */
     private $categoryCollectionFactory;
 
     /** @var StoreManagerInterface */

dev/tests/integration/testsuite/Magento/Catalog/Controller/Adminhtml/Category/Save/SaveCategoryTest.php

@@ -15,6 +15,7 @@
 use Magento\Framework\Exception\NoSuchEntityException;
 use Magento\Framework\Message\MessageInterface;
 use Magento\Store\Model\StoreManagerInterface;
+use Magento\Catalog\Model\ResourceModel\Category\CollectionFactory;
 
 /**
  * Test cases for save category controller.
@@ -36,6 +37,9 @@ class SaveCategoryTest extends AbstractSaveCategoryTest
     /** @var StoreManagerInterface */
     private $storeManager;
 
+    /** @var CollectionFactory */
+    private $categoryCollectionFactory;
+
     /**
      * @inheritdoc
      */
@@ -46,6 +50,7 @@ protected function setUp(): void
         $this->categoryRepository = $this->_objectManager->get(CategoryRepositoryInterface::class);
         $this->getBlockByIdentifier = $this->_objectManager->get(GetBlockByIdentifierInterface::class);
         $this->storeManager = $this->_objectManager->get(StoreManagerInterface::class);
+        $this->categoryCollectionFactory = $this->_objectManager->get(CollectionFactory::class);
     }
 
     /**
@@ -109,4 +114,37 @@ public function testTryToCreateCategoryWithEmptyValues(): void
         );
         $this->assertSessionMessages($this->containsEqual($message), MessageInterface::TYPE_ERROR);
     }
+
+    /**
+     * @magentoDataFixture Magento/Catalog/_files/second_root_category.php
+     *
+     * @return void
+     */
+    public function testSwitchingStoreViewsCategory(): void
+    {
+        $this->getRequest()->setMethod(HttpRequest::METHOD_POST);
+        $id = (int)$this->getCategoryIdByName('Second Root Category');
+        $storeId = (int)$this->storeManager->getStore('default')->getId();
+        $this->getRequest()->setParams(['store' => $storeId, 'id' => $id]);
+        $this->dispatch('backend/catalog/category/save');
+        $this->assertRedirect($this->stringContains('backend/catalog/category/index'));
+        $this->assertStringNotContainsString('/id/', $this->getResponse()->getHeader('Location')->getFieldValue());
+    }
+
+    /**
+     * Get category id by name
+     *
+     * @param string $name
+     * @return string|null
+     */
+    private function getCategoryIdByName(string $name): ?string
+    {
+        $categoryCollection = $this->categoryCollectionFactory->create();
+        $category = $categoryCollection
+            ->addAttributeToFilter(CategoryInterface::KEY_NAME, $name)
+            ->setPageSize(1)
+            ->getFirstItem();
+
+        return $category->getId();
+    }
 }

dev/tests/integration/testsuite/Magento/Catalog/_files/second_root_category.php

@@ -13,9 +13,10 @@
 $objectManager = Bootstrap::getObjectManager();
 /** @var CategoryFactory $categoryFactory */
 $categoryFactory = $objectManager->get(CategoryFactory::class);
+/** @var CategoryRepositoryInterface $categoryRepository */
 $categoryRepository = $objectManager->get(CategoryRepositoryInterface::class);
 $rootCategory = $categoryFactory->create();
 $rootCategory->setName('Second Root Category')
     ->setParentId(Category::TREE_ROOT_ID)
     ->setIsActive(true);
-$rootCategory = $categoryRepository->save($rootCategory);
+$categoryRepository->save($rootCategory);

dev/tests/integration/testsuite/Magento/Catalog/_files/second_root_category_rollback.php

@@ -7,24 +7,21 @@
 
 use Magento\Catalog\Api\CategoryRepositoryInterface;
 use Magento\Catalog\Api\Data\CategoryInterface;
-use Magento\Catalog\Model\CategoryRepository;
-use Magento\Catalog\Model\ResourceModel\Category\Collection;
 use Magento\Catalog\Model\ResourceModel\Category\CollectionFactory;
 use Magento\Framework\Registry;
 use Magento\TestFramework\Helper\Bootstrap;
 
 $objectManager = Bootstrap::getObjectManager();
-/** @var CategoryRepository $categoryRepository */
-$categoryRepository = $objectManager->create(CategoryRepositoryInterface::class);
+/** @var CategoryRepositoryInterface $categoryRepository */
+$categoryRepository = $objectManager->get(CategoryRepositoryInterface::class);
 /** @var CollectionFactory $categoryCollectionFactory */
 $categoryCollectionFactory = $objectManager->get(CollectionFactory::class);
 
 /** @var Registry $registry */
 $registry = $objectManager->get(Registry::class);
 $registry->unregister('isSecureArea');
 $registry->register('isSecureArea', true);
-/** @var Collection $categoryCollection */
-$categoryCollection = $categoryCollectionFactory->get();
+$categoryCollection = $categoryCollectionFactory->create();
 $category = $categoryCollection
     ->addAttributeToFilter(CategoryInterface::KEY_NAME, 'Second Root Category')
     ->setPageSize(1)