ACP2E-1001: Customer Zip Code input validation rule not working

- Fixed input validation
- Fixed multiple same type of error messages not showing on the UI.

Author: Mohan Ahuja

app/code/Magento/Customer/Controller/Adminhtml/Address/Validate.php

@@ -116,7 +116,9 @@ private function validateCustomerAddress(DataObject $response): DataObject
         if ($errors !== true) {
             $messages = $response->hasMessages() ? $response->getMessages() : [];
             foreach ($errors as $error) {
-                $messages[] = $error;
+                foreach ($error as $message) {
+                    $messages[] = $message;
+                }
             }
             $response->setMessages($messages);
             $response->setError(true);

app/code/Magento/Customer/Model/Metadata/Form.php

@@ -367,7 +367,7 @@ public function validateData(array $data)
             foreach ($validator->getMessages() as $errorMessages) {
                 $messages[] = (array)$errorMessages;
             }
-            return array_merge([], ...$messages);
+            return $messages;
         }
         return true;
     }

app/code/Magento/Customer/Model/Metadata/Form/Postcode.php

@@ -8,6 +8,7 @@
 use Magento\Customer\Api\Data\AttributeMetadataInterface;
 use Magento\Customer\Model\Metadata\ElementFactory;
 use Magento\Directory\Helper\Data as DirectoryHelper;
+use Magento\Framework\Api\ArrayObjectSearch;
 use Magento\Framework\Locale\ResolverInterface;
 use Psr\Log\LoggerInterface as PsrLogger;
 use Magento\Framework\Stdlib\DateTime\TimezoneInterface as MagentoTimezone;
@@ -22,6 +23,11 @@ class Postcode extends AbstractData
      */
     protected $directoryHelper;
 
+    /**
+     * @var \Magento\Framework\Stdlib\StringUtils
+     */
+    protected $_string;
+
     /**
      * @param MagentoTimezone $localeDate
      * @param PsrLogger $logger
@@ -31,6 +37,7 @@ class Postcode extends AbstractData
      * @param string $entityTypeCode
      * @param bool $isAjax
      * @param DirectoryHelper $directoryHelper
+     * @param \Magento\Framework\Stdlib\StringUtils $stringHelper
      */
     public function __construct(
         MagentoTimezone $localeDate,
@@ -40,9 +47,11 @@ public function __construct(
         $value,
         $entityTypeCode,
         $isAjax,
-        DirectoryHelper $directoryHelper
+        DirectoryHelper $directoryHelper,
+        \Magento\Framework\Stdlib\StringUtils $stringHelper
     ) {
         $this->directoryHelper = $directoryHelper;
+        $this->_string = $stringHelper;
         parent::__construct(
             $localeDate,
             $logger,
@@ -75,6 +84,14 @@ public function validateValue($value)
         if (empty($value) && $value !== '0') {
             $errors[] = __('"%1" is a required value.', $label);
         }
+
+        $errors = $this->validateLength($value, $attribute, $errors);
+
+        $result = $this->_validateInputRule($value);
+        if ($result !== true) {
+            $errors = array_merge($errors, $result);
+        }
+
         if (count($errors) == 0) {
             return true;
         }
@@ -112,4 +129,42 @@ public function outputValue($format = ElementFactory::OUTPUT_FORMAT_TEXT)
     {
         return $this->_applyOutputFilter($this->_value);
     }
+
+    /**
+     * Length validation
+     *
+     * @param mixed $value
+     * @param AttributeMetadataInterface $attribute
+     * @param array $errors
+     * @return array
+     */
+    private function validateLength($value, AttributeMetadataInterface $attribute, array $errors): array
+    {
+        // validate length
+        $label = __($attribute->getStoreLabel());
+
+        $length = $value ? $this->_string->strlen(trim($value)) : 0;
+
+        $validateRules = $attribute->getValidationRules();
+
+        if (!empty(ArrayObjectSearch::getArrayElementByName($validateRules, 'input_validation'))) {
+            $minTextLength = ArrayObjectSearch::getArrayElementByName(
+                $validateRules,
+                'min_text_length'
+            );
+            if ($minTextLength !== null && $length < $minTextLength) {
+                $errors[] = __('"%1" length must be equal or greater than %2 characters.', $label, $minTextLength);
+            }
+
+            $maxTextLength = ArrayObjectSearch::getArrayElementByName(
+                $validateRules,
+                'max_text_length'
+            );
+            if ($maxTextLength !== null && $length > $maxTextLength) {
+                $errors[] = __('"%1" length must be equal or less than %2 characters.', $label, $maxTextLength);
+            }
+        }
+
+        return $errors;
+    }
 }