ACP2E-3286: Related products SelectAll/Unselect All Issue

Author: Adiglo70550

app/code/Magento/Catalog/view/frontend/web/js/related-products.js

@@ -47,15 +47,11 @@ define([
          * @return {Boolean} - Prevent default event action and event propagation.
          */
         _selectAllRelated: function (e) {
-            var self = this,
-                innerHTML = this.options.relatedProductsCheckFlag ?
-                    this.options.selectAllMessage : this.options.unselectAllMessage;
+            let isChecked = this.options.relatedProductsCheckFlag;
+            $(e.target).html(isChecked ? this.options.selectAllMessage : this.options.unselectAllMessage);
+            this.options.relatedProductsCheckFlag = !isChecked;
 
-            $(e.target).html(innerHTML);
-
-            this.options.relatedProductsCheckFlag = !this.options.relatedProductsCheckFlag;
-            $(this.options.relatedCheckbox + ':visible').each(function () {
-                $(this).prop('checked', self.options.relatedProductsCheckFlag); });
+            $(this.options.relatedCheckbox + ':visible').prop('checked', this.options.relatedProductsCheckFlag);
             this._addRelatedToProduct();
 
             return false;

dev/tests/js/jasmine/tests/app/code/Magento/Catalog/frontend/js/related-products.test.js

@@ -4,8 +4,7 @@
  */
 define([
     'jquery',
-    'Magento_Catalog/js/related-products',
-    'jquery-ui-modules/widget'
+    'Magento_Catalog/js/related-products'
 ], function ($) {
     'use strict';
 
@@ -46,7 +45,7 @@ define([
             expect($(relatedCheckboxSelector + ':checked').length).toBe(0);
         });
 
-        it('should select all except manually selected product when "Select All" is clicked after manual selection',
+        it('should select all products, including those manually selected, when "Select All" is clicked',
             function () {
                 $(relatedCheckboxSelector).first().prop('checked', true).trigger('click');
                 $(selectAllLinkSelector).trigger('click');