ACP2E-2174: allow qty change for cart items without errors

Author: alzota

app/code/Magento/Checkout/Model/Cart.php

@@ -523,6 +523,7 @@ public function updateItems($data)
         );
 
         $qtyRecalculatedFlag = false;
+        $itemErrors = [];
         foreach ($data as $itemId => $itemInfo) {
             $item = $this->getQuote()->getItemById($itemId);
             if (!$item) {
@@ -536,15 +537,12 @@ public function updateItems($data)
 
             $qty = isset($itemInfo['qty']) ? (double)$itemInfo['qty'] : false;
             if ($qty > 0) {
-                if ($item->getHasError() && !$item->getProduct()->isInStock()) {
-                    $item->setUseOldQty(true);
-                }
                 $item->clearMessage();
                 $item->setHasError(false);
                 $item->setQty($qty);
 
                 if ($item->getHasError()) {
-                    throw new \Magento\Framework\Exception\LocalizedException(__($item->getMessage()));
+                    $itemErrors[$item->getId()] = __($item->getMessage());
                 }
 
                 if (isset($itemInfo['before_suggest_qty']) && $itemInfo['before_suggest_qty'] != $qty) {
@@ -568,6 +566,10 @@ public function updateItems($data)
             ['cart' => $this, 'info' => $infoDataObject]
         );
 
+        if (count($itemErrors)) {
+            throw new \Magento\Framework\Exception\LocalizedException(current($itemErrors));
+        }
+
         return $this;
     }
 

dev/tests/integration/testsuite/Magento/Checkout/Controller/CartTest.php

@@ -594,10 +594,10 @@ private function updatePostRequest(
             $this->dispatch('checkout/cart/updateItemQty');
         } else {
             $this->dispatch('checkout/cart/updatePost');
+            $quote->collectTotals();
         }
         $response = $this->getResponse()->getBody();
         $response = json_decode($response, true);
-        $quote->collectTotals();
         return $response;
     }
 }